2003-02-28 09:05:51

by Duncan Sands

Subject: [PATCH] USB speedtouch: be firm when disconnected

Just say -ENODEV


speedtouch.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)


diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c
--- a/drivers/usb/misc/speedtouch.c Fri Feb 28 10:09:04 2003
+++ b/drivers/usb/misc/speedtouch.c Fri Feb 28 10:09:04 2003
@@ -648,9 +648,9 @@

dbg ("udsl_atm_send called (skb 0x%p, len %u)", skb, skb->len);

- if (!instance) {
- dbg ("NULL instance!");
- return -EINVAL;
+ if (!instance || !instance->usb_dev) {
+ dbg ("NULL data!");
+ return -ENODEV;
}

if (!instance->firmware_loaded)
@@ -701,6 +701,7 @@
tasklet_kill (&instance->send_tasklet);
dbg ("udsl_atm_dev_close: freeing instance");
kfree (instance);
+ dev->dev_data = NULL;
}


@@ -776,8 +777,8 @@

dbg ("udsl_atm_open called");

- if (!instance) {
- dbg ("NULL instance!");
+ if (!instance || !instance->usb_dev) {
+ dbg ("NULL data!");
return -ENODEV;
}

2003-02-28 21:31:02

by Greg KH

Subject: Re: [PATCH] USB speedtouch: be firm when disconnected

On Fri, Feb 28, 2003 at 10:15:37AM +0100, Duncan Sands wrote:
> Just say -ENODEV

Applied, thanks.

greg k-h