This is a kernel issue and should be fixed in kernel unless we want
to do something in <sys/sysctl.h>.
H.J.
---
--- include/linux/sysctl.h.user 2003-05-29 07:36:51.000000000 -0700
+++ include/linux/sysctl.h 2003-05-29 08:47:21.000000000 -0700
@@ -28,6 +28,11 @@
#include <linux/types.h>
#include <linux/list.h>
+#ifdefine __KERNEL__
+#undef __user
+#define __user
+#endif
+
struct file;
#define CTL_MAXNAME 10 /* how many path components do we allow in a
On Thu, May 29, 2003 at 08:04:46AM -0700, ismail donmez wrote:
>
> --- "H. J. Lu" <[email protected]> wrote:
> > What is the problem? Does linux/sysctl.h include
> > linux/compiler.h?
> No it doesnt include it directly. It includes
> linux/kernel.h and linux/kernel.h does a trick like
>
> #ifdef __KERNEL__
> .......
> #include <linux/compiler.h>
>
> So we never get __user defined.
>
> > Does your compiler define __CHECKER__?
> >
> No.
>
> Would it be too bad to a trick like
>
> #include <linux/version.h>
> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,70)
> #define __user
> #endif
>
> What do you think?
>
> Regards,
> /ismail
>
> =====
> Microsoft Windows: made for the internet
> The Internet: made for UNIX
>
> __________________________________
> Do you Yahoo!?
> Yahoo! Calendar - Free online calendar with sync to Outlook(TM).
> http://calendar.yahoo.com
On Thu, May 29, 2003 at 08:49:48AM -0700, H. J. Lu wrote:
> This is a kernel issue and should be fixed in kernel unless we want
> to do something in <sys/sysctl.h>.
You should not include kernel headers from userspace.
Hi,
> On Thu, May 29, 2003 at 08:49:48AM -0700, H. J. Lu wrote:
> > This is a kernel issue and should be fixed in kernel unless we want
> > to do something in <sys/sysctl.h>.
>
> You should not include kernel headers from userspace.
Old story I know but I dont think binutils would use kernel headers if it
doesnt need it.
Regards,
/ismail
P.S: Yeah I am [email protected]
On Thu, May 29, 2003 at 07:21:47PM +0300, ismail (cartman) donmez wrote:
> Hi,
> > On Thu, May 29, 2003 at 08:49:48AM -0700, H. J. Lu wrote:
> > > This is a kernel issue and should be fixed in kernel unless we want
> > > to do something in <sys/sysctl.h>.
> >
> > You should not include kernel headers from userspace.
>
> Old story I know but I dont think binutils would use kernel headers if it
> doesnt need it.
>
<sys/sysctl.h> includes <linux/sysctl.h>. That is what I meant by "do
something in <sys/sysctl.h>."
H.J.
On Thu, May 29, 2003 at 09:59:40AM -0700, H. J. Lu wrote:
> > > > This is a kernel issue and should be fixed in kernel unless we want
> > > > to do something in <sys/sysctl.h>.
> > >
> > > You should not include kernel headers from userspace.
> >
> > Old story I know but I dont think binutils would use kernel headers if it
> > doesnt need it.
> >
>
> <sys/sysctl.h> includes <linux/sysctl.h>. That is what I meant by "do
> something in <sys/sysctl.h>."
I know. and <linux/sysctl.h> is a kernel header libc shouldn't include.
So you want to do something to <sys/sysctl.h>, namely get rid of it's
depency on kernel headers.
On Fri, May 30, 2003 at 12:45:26PM +0300, ismail (cartman) donmez wrote:
> On Friday 30 May 2003 11:48, Christoph Hellwig wrote:
> > I know. and <linux/sysctl.h> is a kernel header libc shouldn't include.
> > So you want to do something to <sys/sysctl.h>, namely get rid of it's
> > depency on kernel headers.
> Wouldn't this result in glibc-kernel inconsistency in headers?
How so? If the sysctl values change you're screwed anyway.
On Friday 30 May 2003 11:48, Christoph Hellwig wrote:
> I know. and <linux/sysctl.h> is a kernel header libc shouldn't include.
> So you want to do something to <sys/sysctl.h>, namely get rid of it's
> depency on kernel headers.
Wouldn't this result in glibc-kernel inconsistency in headers?
Regards,
/ismail
On Friday 30 May 2003 12:48, Christoph Hellwig wrote:
> How so? If the sysctl values change you're screwed anyway.
Heh that was what I mean like what if glibc header and kernel header differs a
lot. Its bringing more harm than goodness but including linux/sysctl.h in
sys/sysctl.h makes two header synchronised.
Wondering what glibc guys think to solve this ? Ulrich Drepper or some other
glibc hacker make a comment please?
Regards,
/ismail