Hi Anton,
Recently I am correcting warnings when compiling with GCC 3.2
kernel 2.4.22-rcX, had created a patch that eliminates these warnings of
the code ntfs, which is sent it to Marcelo Tosatti so that it includes
it, but it said me that is sent it to you, and that you verify it and is
sent it to him.
for reference:
http://marc.theaimsgroup.com/?l=linux-kernel&m=106076494608869&w=2
(originaly without considering -DDEBUG and file fs.c)
Ok, this patch only fix warnings and no other modifications.
The warnings is "warning: concatenation of string literals with
__FUNCTION__ is deprecated" that appears 190 (with -DDEBUG) times,
and also fix this "warning: deprecated use of label at end of compound
statement" that appers one time in fs.h.
Please review, and confirm to Marcelo Tosatti, for include in the kernel
main line.
The syntax that uses to correct this, is the same one used in
kernel.
fixes:
dir.c 18
fs.c 13+1
inode.c 85
super.c 74
total 191 warnings fixed!!! (it took enough hours to me)
Thanks in advance.
Take Care,
djgera
(sorry my english)
--
Gerardo Exequiel Pozzi ( djgera )
http://www.vmlinuz.com.ar http://www.djgera.com.ar
KeyID: 0x1B8C330D
Key fingerprint = 0CAA D5D4 CD85 4434 A219 76ED 39AB 221B 1B8C 330D
Hi djgera,
Anton isn't ignoring you, he's just extremely busy.
> total 191 warnings fixed!!! (it took enough hours to me)
Wow, thank you very much. You've done an amazing job.
I've read through the patch (yawn) and tested it. I found a couple of
problems (debug only), but they weren't your fault. Several of the
ntfs_debug's had the wrong arguments. I've rebuilt the patch and put it
here:
http://flatcap.org/ntfs/fix.warning.deprecated.ntfs.patch2
http://flatcap.org/ntfs/fix.warning.deprecated.ntfs.patch2.bz2
> Please review, and confirm to Marcelo Tosatti
Now we just need to keep poking Anton :-)
Thanks for your hard work.
Cheers,
FlatCap (Rich)
[email protected]
WWW: http://linux-ntfs.sourceforge.net
IRC: #ntfs on irc.freenode.net
On 17 Aug 2003 21:30:13 +0100, Richard Russon wrote:
>Hi djgera,
>
>Anton isn't ignoring you, he's just extremely busy.
>
no problem, he I answer myself Marcelo and my, accepting the patch.
>> total 191 warnings fixed!!! (it took enough hours to me)
>
>Wow, thank you very much. You've done an amazing job.
>
:) it was a pleasure.
>I've read through the patch (yawn) and tested it. I found a couple of
>problems (debug only), but they weren't your fault. Several of the
>ntfs_debug's had the wrong arguments. I've rebuilt the patch and put
>it here:
>
> http://flatcap.org/ntfs/fix.warning.deprecated.ntfs.patch2
> http://flatcap.org/ntfs/fix.warning.deprecated.ntfs.patch2.bz2
>
>> Please review, and confirm to Marcelo Tosatti
>
yup, by the way it forgets to me to comment to them of the lack of
arguments in original code (sorry), and thanks to correct
them.
>Now we just need to keep poking Anton :-)
>
>Thanks for your hard work.
>
excelent!
my patch is at the moment in the tree of Alan, since -ac3.
Best Regards,
djgera
--
Gerardo Exequiel Pozzi ( djgera )
http://www.vmlinuz.com.ar http://www.djgera.com.ar
KeyID: 0x1B8C330D
Key fingerprint = 0CAA D5D4 CD85 4434 A219 76ED 39AB 221B 1B8C 330D