2003-09-27 01:21:33

by Chris Wright

Subject: [PATCH] ACPI pci irq routing fix

If irq.active is set from _CRS, make sure to use it, rather than trying
anything from the from the _PRS list, as some machines don't handle this
properly. This patch is against current linux-acpi-test-2.6.0. It's
been floating about for a while, and fixes bug #1186.

Patch originally from Andrew de Quincey.

thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net

===== drivers/acpi/pci_link.c 1.19 vs edited =====
--- 1.19/drivers/acpi/pci_link.c Thu Sep 18 11:29:36 2003
+++ edited/drivers/acpi/pci_link.c Fri Sep 26 14:36:15 2003
@@ -500,15 +500,15 @@
irq = link->irq.active;
} else {
irq = link->irq.possible[0];
- }

- /*
- * Select the best IRQ. This is done in reverse to promote
- * the use of IRQs 9, 10, 11, and >15.
- */
- for (i=(link->irq.possible_count-1); i>0; i--) {
- if (acpi_irq_penalty[irq] > acpi_irq_penalty[link->irq.possible[i]])
- irq = link->irq.possible[i];
+ /*
+ * Select the best IRQ. This is done in reverse to promote
+ * the use of IRQs 9, 10, 11, and >15.
+ */
+ for (i=(link->irq.possible_count-1); i>0; i--) {
+ if (acpi_irq_penalty[irq] > acpi_irq_penalty[link->irq.possible[i]])
+ irq = link->irq.possible[i];
+ }
}

/* Attempt to enable the link device at this IRQ. */

2003-09-27 05:56:12

by Nick Piggin

Subject: Re: [PATCH] ACPI pci irq routing fix

Chris Wright wrote:

>If irq.active is set from _CRS, make sure to use it, rather than trying
>anything from the from the _PRS list, as some machines don't handle this
>properly. This patch is against current linux-acpi-test-2.6.0. It's
>been floating about for a while, and fixes bug #1186.
>
>Patch originally from Andrew de Quincey.
>
>thanks,
>-chris
>

This fixes my bug #1257.

2003-09-30 05:18:16

by Brown, Len

Subject: Re: [PATCH] ACPI pci irq routing fix

On Sat, 2003-09-27 at 01:54, Nick Piggin wrote:
> Chris Wright wrote:
>
> >If irq.active is set from _CRS, make sure to use it
...
> and fixes bug #1186.
> >
> >Patch originally from Andrew de Quincey.
> >
>
> This fixes my bug #1257.
>

This fix has been integrated with others in the ACPI patch,
and is available now in these bitkeeper trees:

http://linux-acpi.bkbits.net/linux-acpi-test-2.4.22
http://linux-acpi.bkbits.net/linux-acpi-test-2.4.23
http://linux-acpi.bkbits.net/linux-acpi-test-2.6.0

It is also available as a plain patch "acpi_pci_link_allocate" here:

ftp.kernel.org:/pub/linux/kernel/people/lenb/acpi/patches/test/*

thanks,
-Len

2003-09-30 06:08:31

by Chris Wright

Subject: Re: [PATCH] ACPI pci irq routing fix

* Len Brown ([email protected]) wrote:
>
> This fix has been integrated with others in the ACPI patch,
> and is available now in these bitkeeper trees:

Great, thanks Len.
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net