Hello,
I'm getting an Oops when ifup'ing a Compaq Netelligent card that
uses the tlan driver running 2.6. The oops causes the ifconfig and
modprobe (invoked by kmod) processes to hang and the network doesn't
come up.
The oops only happens when CONFIG_HOTPLUG=n. I've seen the
problem in -test8, test9, and test9-bk11. This is a Compaq Proliant
5000 with quad PPro processors. The box has EISA slots so I have
CONFIG_EISA=y but all three NICs are pci Netelligents.
I had thought this was a problem that started in -test9, not
realizing I had turned hotplug support off when updating from -test8.
This might not be that big deal now that the problem is known -- would
it be useful to file this in the kernel Bugzilla to keep track of it?
It looks like tlan.c hasn't been touched in a long time.
I'm subscribed to linux-kernel, but not netdev. Thanks for any help.
The Oops, dmesg, .config, and lspci -v are attached as plain text:
--
Joseph Fannin
[email protected]
"Linus, please apply. Breaks everything. But is cool." -- Rusty Russell.
[email protected] (Joseph Fannin) wrote:
>
> I'm getting an Oops when ifup'ing a Compaq Netelligent card that
> uses the tlan driver running 2.6.
Does this fix it?
diff -puN drivers/net/tlan.c~tlan-oops-fix drivers/net/tlan.c
--- 25/drivers/net/tlan.c~tlan-oops-fix 2003-11-11 15:29:32.000000000 -0800
+++ 25-akpm/drivers/net/tlan.c 2003-11-11 15:29:38.000000000 -0800
@@ -234,7 +234,7 @@ static struct board {
const char *deviceLabel;
u32 flags;
u16 addrOfs;
-} board_info[] __devinitdata = {
+} board_info[] = {
{ "Compaq Netelligent 10 T PCI UTP", TLAN_ADAPTER_ACTIVITY_LED, 0x83 },
{ "Compaq Netelligent 10/100 TX PCI UTP", TLAN_ADAPTER_ACTIVITY_LED, 0x83 },
{ "Compaq Integrated NetFlex-3/P", TLAN_ADAPTER_NONE, 0x83 },
_
On Tue, 11 Nov 2003 15:30:13 -0800
Andrew Morton <[email protected]> wrote:
> Does this fix it?
...
> -} board_info[] __devinitdata = {
> +} board_info[] = {
This fix is needed, definitely. Even if it doesn't cure this
specific bug.
I'll merge this into my networking tree and push to Linus.
Thanks Andrew.
On Tue, Nov 11, 2003 at 03:55:18PM -0800, David S. Miller wrote:
> On Tue, 11 Nov 2003 15:30:13 -0800
> Andrew Morton <[email protected]> wrote:
>
> > Does this fix it?
> ...
> > -} board_info[] __devinitdata = {
> > +} board_info[] = {
>
> This fix is needed, definitely. Even if it doesn't cure this
> specific bug.
>
> I'll merge this into my networking tree and push to Linus.
Even better, it fixes the bug. :-) Thank you.
--
Joseph Fannin
[email protected]
"That's all I have to say about that." -- Forrest Gump.