2004-01-24 11:13:51

by John Cherry

Subject: IA32 (2.6.2-rc1 - 2004-01-23.22.30) - 2 New warnings (gcc 3.2.2)

arch/i386/kernel/dmi_scan.c:287: warning: `apm_is_horked_d850md' defined but not used
fs/xfs/xfs_log_recover.c:1534: warning: `flags' might be used uninitialized in this function

2004-01-24 12:01:18

by Tim Cambrant

Subject: [PATCH] Re: IA32 (2.6.2-rc1 - 2004-01-23.22.30) - 2 New warnings (gcc 3.2.2)

On Sat, Jan 24, 2004 at 03:13:49AM -0800, John Cherry wrote:
> fs/xfs/xfs_log_recover.c:1534: warning: `flags' might be used uninitialized in this function

This patch will initialize the ushort 'flags'. This is _really_ trivial, and
isn't needed, but if it's important to remove as many warnings as possible,
then this patch will sort it out.


--- linux-2.6.2-rc/fs/xfs/xfs_log_recover.c.orig Sat Jan 24 12:49:07 2004
+++ linux-2.6.2-rc/fs/xfs/xfs_log_recover.c Sat Jan 24 12:51:38 2004
@@ -1531,7 +1531,7 @@ xlog_recover_reorder_trans(
xlog_recover_item_t *first_item, *itemq, *itemq_next;
xfs_buf_log_format_t *buf_f;
xfs_buf_log_format_v1_t *obuf_f;
- ushort flags;
+ ushort flags = 0;

first_item = itemq = trans->r_itemq;
trans->r_itemq = NULL;


Apply this if it's really needed. GCC 3.4 doesn't give any warnings though.

Tim Cambrant