2004-04-08 23:48:57

by Chris Wright

[permalink] [raw]
Subject: [PATCH] fix load_elf_binary error path on unshare_files error

Make sure to return proper retval on unshare_files() error in
load_elf_binary. Patch against 2.4.26-rc2.

Error noted by Kirill Korotaev <[email protected]>.

===== fs/binfmt_elf.c 1.28 vs edited =====
--- 1.28/fs/binfmt_elf.c Thu Jan 29 15:08:42 2004
+++ edited/fs/binfmt_elf.c Thu Apr 8 15:12:15 2004
@@ -479,7 +479,8 @@
goto out_free_ph;

files = current->files; /* Refcounted so ok */
- if(unshare_files() < 0)
+ retval = unshare_files();
+ if (retval < 0)
goto out_free_ph;
if (files == current->files) {
put_files_struct(files);