2004-04-22 16:41:27

by Jakub Bogusz

[permalink] [raw]
Subject: [PATCH 2.4, 2.6] rivafb 16bpp text background colour fix

I sent it already to Ani Joshi long time ago (December 2002),
but it seems to be lost somewhere in time.
I noticed that Pawel Goleniowski made the same patch and sent to LKML
in December 2003 and January 2004:
http://www.uwsg.iu.edu/hypermail/linux/kernel/0312.2/1258.html
http://www.uwsg.iu.edu/hypermail/linux/kernel/0401.1/0225.html
but it's still not fixed.

The same applies to 2.6.x series, only filename
(linux-2.6.*/drivers/video/riva/fbdev.c instead of .../riva/accel.c)
and whitespace (tabs are used now instead of spaces) differ.

Original description (written in Dec 2002):
> I noticed, that text background in 16bpp (only) modes is displayed
> incorrectly. That's because convert_bgcolor_16() converts value to RGBA
> from 15bpp, not 16bpp.
>
> The fix is attached (works for me, tested by one more person).
> Patch was made against Linux 2.4.19, but should apply to 2.4.20 and
> 2.5.x without changes.


--
Jakub Bogusz http://cyber.cs.net.pl/~qboosh/


Attachments:
(No filename) (970.00 B)
linux-rivafb16-bgcolor.patch (611.00 B)
linux-2.6-rivafb16.patch (583.00 B)
Download all attachments

2004-04-22 18:43:22

by James Simmons

[permalink] [raw]
Subject: Re: [PATCH 2.4, 2.6] rivafb 16bpp text background colour fix


I applied it to the newer Nvidia driver I have. I plan to o stream line in
the next few weeks.


On Thu, 22 Apr 2004, Jakub Bogusz wrote:

> I sent it already to Ani Joshi long time ago (December 2002),
> but it seems to be lost somewhere in time.
> I noticed that Pawel Goleniowski made the same patch and sent to LKML
> in December 2003 and January 2004:
> http://www.uwsg.iu.edu/hypermail/linux/kernel/0312.2/1258.html
> http://www.uwsg.iu.edu/hypermail/linux/kernel/0401.1/0225.html
> but it's still not fixed.
>
> The same applies to 2.6.x series, only filename
> (linux-2.6.*/drivers/video/riva/fbdev.c instead of .../riva/accel.c)
> and whitespace (tabs are used now instead of spaces) differ.
>
> Original description (written in Dec 2002):
> > I noticed, that text background in 16bpp (only) modes is displayed
> > incorrectly. That's because convert_bgcolor_16() converts value to RGBA
> > from 15bpp, not 16bpp.
> >
> > The fix is attached (works for me, tested by one more person).
> > Patch was made against Linux 2.4.19, but should apply to 2.4.20 and
> > 2.5.x without changes.
>
>
>