Hi, Joe
Here's a trivial patch to call to dm_vcalloc(). The patch doesn't
actually change the behavior of the code. But I think this change
makes the call more in the spirit of the declaration for dm_vcallc().
this is to your latest udm1 patch to 2.6.6-rc2.
diff -ur rc2-mm1-UDM1-original/drivers/md/dm-table.c rc2-mm1-UDM1-patched/drivers/md/dm-table.c
--- rc2-mm1-UDM1-original/drivers/md/dm-table.c 2004-04-23 14:53:20.000000000 -0700
+++ rc2-mm1-UDM1-patched/drivers/md/dm-table.c 2004-04-23 14:57:20.000000000 -0700
@@ -181,8 +181,8 @@
/*
* Allocate both the target array and offset array at once.
*/
- n_highs = (sector_t *) dm_vcalloc(sizeof(struct dm_target) +
- sizeof(sector_t), num);
+ n_highs = (sector_t *) dm_vcalloc(num, sizeof(struct dm_target) +
+ sizeof(sector_t));
if (!n_highs)
return -ENOMEM;
On Fri, Apr 23, 2004 at 03:08:06PM -0700, Dave Olien wrote:
> Here's a trivial patch to call to dm_vcalloc().
Merged into udm.
Thanks,
- Joe