2004-06-11 20:05:20

by Chris Wright

Subject: [PATCH] sparse fix for void return in selinux/hooks.c

CHECK security/selinux/hooks.c
security/selinux/hooks.c:1383:34: warning: return expression in void function
security/selinux/hooks.c:3548:30: warning: return expression in void function
CC security/selinux/hooks.o

From: Mika Kukkonen <[email protected]>
Signed-off-by: Chris Wright <[email protected]>

===== security/selinux/hooks.c 1.40 vs edited =====
--- 1.40/security/selinux/hooks.c 2004-05-10 04:25:52 -07:00
+++ edited/security/selinux/hooks.c 2004-06-11 12:54:44 -07:00
@@ -1380,7 +1380,7 @@
if (error)
return;

- return secondary_ops->capset_set(target, effective, inheritable, permitted);
+ secondary_ops->capset_set(target, effective, inheritable, permitted);
}

static int selinux_capable(struct task_struct *tsk, int cap)
@@ -3545,7 +3545,7 @@

static void selinux_msg_msg_free_security(struct msg_msg *msg)
{
- return msg_msg_free_security(msg);
+ msg_msg_free_security(msg);
}

/* message queue security operations */