2004-06-14 18:53:12

by Adrian Bunk

[permalink] [raw]
Subject: [patch] 2.6: modular scsi/mca_53c9x doesn't work (fwd)

The issue described in the mail forwarded below is still present in
2.6.7-rc3-mm2 (but not specific to -mm).

I'd suggest the following workaround:

--- linux-2.6.7-rc3-mm2-modular-no-smp/drivers/scsi/Kconfig.old 2004-06-14 20:45:20.000000000 +0200
+++ linux-2.6.7-rc3-mm2-modular-no-smp/drivers/scsi/Kconfig 2004-06-14 20:51:40.000000000 +0200
@@ -1136,7 +1136,7 @@
than 1 device on a SCSI bus. The normal answer therefore is N.

config SCSI_MCA_53C9X
- tristate "NCR MCA 53C9x SCSI support"
+ bool "NCR MCA 53C9x SCSI support"
depends on MCA_LEGACY && SCSI && BROKEN_ON_SMP
help
Some MicroChannel machines, notably the NCR 35xx line, use a SCSI




----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Sat, 20 Dec 2003 00:17:12 +0100
From: Adrian Bunk <[email protected]>
To: [email protected], [email protected]
Cc: [email protected]
Subject: 2.6: modular scsi/mca_53c9x doesn't work

I got the following mesage when trying to build modular a mca_53c9x in
2.6.0-test11-mm1:

<-- snip -->

...
*** Warning: "esp_reset" [drivers/scsi/mca_53c9x.ko] undefined!
*** Warning: "esp_abort" [drivers/scsi/mca_53c9x.ko] undefined!
*** Warning: "esp_queue" [drivers/scsi/mca_53c9x.ko] undefined!
*** Warning: "esps_in_use" [drivers/scsi/mca_53c9x.ko] undefined!
*** Warning: "esp_initialize" [drivers/scsi/mca_53c9x.ko] undefined!
*** Warning: "esp_allocate" [drivers/scsi/mca_53c9x.ko] undefined!
*** Warning: "esp_intr" [drivers/scsi/mca_53c9x.ko] undefined!
*** Warning: "esp_deallocate" [drivers/scsi/mca_53c9x.ko] undefined!
...

<-- snip -->

It seems there are some EXPORT_SYMBOL's needed in NCR53C9x.c?

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


2004-06-14 19:22:19

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [patch] 2.6: modular scsi/mca_53c9x doesn't work (fwd)

On Mon, Jun 14, 2004 at 08:52:56PM +0200, Adrian Bunk wrote:
> The issue described in the mail forwarded below is still present in
> 2.6.7-rc3-mm2 (but not specific to -mm).
>
> I'd suggest the following workaround:

Please add the exports instead. It'll affect all the other 53C9X-based
drivers aswell.

2004-06-14 22:53:48

by Adrian Bunk

[permalink] [raw]
Subject: Re: [patch] 2.6: modular scsi/mca_53c9x doesn't work (fwd)

On Mon, Jun 14, 2004 at 08:22:15PM +0100, Christoph Hellwig wrote:
> On Mon, Jun 14, 2004 at 08:52:56PM +0200, Adrian Bunk wrote:
> > The issue described in the mail forwarded below is still present in
> > 2.6.7-rc3-mm2 (but not specific to -mm).
> >
> > I'd suggest the following workaround:
>
> Please add the exports instead. It'll affect all the other 53C9X-based
> drivers aswell.

This sounds like a better solution.

Patch below.

cu
Adrian

--- linux-2.6.7-rc3-mm2-modular-no-smp/drivers/scsi/NCR53C9x.c.old 2004-06-15 00:44:36.000000000 +0200
+++ linux-2.6.7-rc3-mm2-modular-no-smp/drivers/scsi/NCR53C9x.c 2004-06-15 00:47:23.000000000 +0200
@@ -3646,4 +3646,15 @@
}
#endif

+EXPORT_SYMBOL(esp_abort);
+EXPORT_SYMBOL(esp_allocate);
+EXPORT_SYMBOL(esp_deallocate);
+EXPORT_SYMBOL(esp_initialize);
+EXPORT_SYMBOL(esp_intr);
+EXPORT_SYMBOL(esp_queue);
+EXPORT_SYMBOL(esp_reset);
+EXPORT_SYMBOL(esp_slave_alloc);
+EXPORT_SYMBOL(esp_slave_destroy);
+EXPORT_SYMBOL(esps_in_use);
+
MODULE_LICENSE("GPL");

2004-06-15 07:17:25

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [patch] 2.6: modular scsi/mca_53c9x doesn't work (fwd)

On Tue, Jun 15, 2004 at 12:53:36AM +0200, Adrian Bunk wrote:
> On Mon, Jun 14, 2004 at 08:22:15PM +0100, Christoph Hellwig wrote:
> > On Mon, Jun 14, 2004 at 08:52:56PM +0200, Adrian Bunk wrote:
> > > The issue described in the mail forwarded below is still present in
> > > 2.6.7-rc3-mm2 (but not specific to -mm).
> > >
> > > I'd suggest the following workaround:
> >
> > Please add the exports instead. It'll affect all the other 53C9X-based
> > drivers aswell.
>
> This sounds like a better solution.
>
> Patch below.
>
> cu
> Adrian
>
> --- linux-2.6.7-rc3-mm2-modular-no-smp/drivers/scsi/NCR53C9x.c.old 2004-06-15 00:44:36.000000000 +0200
> +++ linux-2.6.7-rc3-mm2-modular-no-smp/drivers/scsi/NCR53C9x.c 2004-06-15 00:47:23.000000000 +0200
> @@ -3646,4 +3646,15 @@
> }
> #endif
>
> +EXPORT_SYMBOL(esp_abort);
> +EXPORT_SYMBOL(esp_allocate);
> +EXPORT_SYMBOL(esp_deallocate);
> +EXPORT_SYMBOL(esp_initialize);
> +EXPORT_SYMBOL(esp_intr);
> +EXPORT_SYMBOL(esp_queue);
> +EXPORT_SYMBOL(esp_reset);
> +EXPORT_SYMBOL(esp_slave_alloc);
> +EXPORT_SYMBOL(esp_slave_destroy);
> +EXPORT_SYMBOL(esps_in_use);
> +
> MODULE_LICENSE("GPL");

Looks good to me, thanks.