2004-09-01 21:46:04

by Adrian Bunk

[permalink] [raw]
Subject: 2.6.9-rc1-mm2: IP_NF_COMPAT_IPCHAINS compilation broken

On Tue, Aug 31, 2004 at 03:13:45PM -0700, Rick Lindsley wrote:
> Getting an error of:
>
> net/built-in.o(.text+0x64047): In function `tcp_in_window':
> net/ipv4/netfilter/ip_conntrack_proto_tcp.c:683: undefined reference to `ip_ct_log_invalid'
> net/built-in.o(.text+0x6431f): In function `tcp_error':
> net/ipv4/netfilter/ip_conntrack_proto_tcp.c:792: undefined reference to `ip_ct_log_invalid'
> net/built-in.o(.text+0x64421):net/ipv4/netfilter/ip_conntrack_proto_tcp.c:817: undefined reference to `ip_ct_log_invalid'
> net/built-in.o(.text+0x64450):net/ipv4/netfilter/ip_conntrack_proto_tcp.c:808: undefined reference to `ip_ct_log_invalid'
> net/built-in.o(.text+0x64487):net/ipv4/netfilter/ip_conntrack_proto_tcp.c:784: undefined reference to `ip_ct_log_invalid'
> net/built-in.o(.text+0x6478a):net/ipv4/netfilter/ip_conntrack_proto_tcp.c:877: more undefined references to `ip_ct_log_invalid' follow
>
> The error is for all references of the LOG_INVALID macro in
> ip_conntrack_proto_tcp.c.
>...

Harald, the LOG_INVALID macro from your

[NETFILTER]: Move error tracking into conntrack protocol helper

patch in Linus' tree breaks compilation with
CONFIG_IP_NF_COMPAT_IPCHAINS=y, since ip_ct_log_invalid isn't available
in this case due to CONFIG_IP_NF_CONNTRACK=n.


cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed