2004-09-05 02:29:56

by Adam J. Richter

[permalink] [raw]
Subject: [Patch 2.6.9-rc1-bk11] cdu31a: fix msleep patch typo

linux-2.6.9-rc1-bk11 integrated the patch "cdu31a: replace
schedule_timeout() with msleep()". That patch contained a typo,
causing the cdu31a driver to fail to compile. Here is a fix for
the typo.

Of course I have tested this patch to verify that it compiles.
I do not, however, have a Sony cdu-31a or cdu-33a drive handy to actually
test that the driver works. I wonder if anyone out there still has a
Sony cdu-31a or cdu-33a CD-ROM drive on a machine running Linux.

Signed-off-by: Adam J. Richter <[email protected]>

__ ______________
Adam J. Richter \ /
[email protected] | g g d r a s i l


--- linux-2.6.9-rc1-bk11/drivers/cdrom/cdu31a.c 2004-09-05 09:11:23.000000000 -0700
+++ linux/drivers/cdrom/cdu31a.c 2004-09-05 10:09:42.000000000 -0700
@@ -959,7 +959,7 @@
if (((result_buffer[0] & 0xf0) == 0x20)
&& (num_retries < MAX_CDU31A_RETRIES)) {
num_retries++;
- msleep(100):
+ msleep(100);
goto retry_cd_operation;
}


2004-09-06 19:50:22

by maximilian attems

[permalink] [raw]
Subject: Re: [Patch 2.6.9-rc1-bk11] cdu31a: fix msleep patch typo

On Sun, 05 Sep 2004, Adam J. Richter wrote:

> linux-2.6.9-rc1-bk11 integrated the patch "cdu31a: replace
> schedule_timeout() with msleep()". That patch contained a typo,
> causing the cdu31a driver to fail to compile. Here is a fix for
> the typo.

thanks it already got reported,
similiar patch from adrian bunk is on the way to be merged.

> Of course I have tested this patch to verify that it compiles.
> I do not, however, have a Sony cdu-31a or cdu-33a drive handy to actually
> test that the driver works. I wonder if anyone out there still has a
> Sony cdu-31a or cdu-33a CD-ROM drive on a machine running Linux.
>
> Signed-off-by: Adam J. Richter <[email protected]>

wooow cool :)
sounds like you volounteer to maintain that beast?
do you want to be added to MAINTAINERS?


--
maks
kernel janitor http://janitor.kernelnewbies.org/