Greg, are you going to send pci-sysfs-rom-22.patch upstream? Or do I
need to do it, if so how? Jesse's objection turned out to be a problem
in another piece of code.
=====
Jon Smirl
[email protected]
__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - 100MB free storage!
http://promotions.yahoo.com/new_mail
On Tue, Sep 07, 2004 at 08:15:37PM -0700, Jon Smirl wrote:
> Greg, are you going to send pci-sysfs-rom-22.patch upstream? Or do I
> need to do it, if so how?
I'll do it. I'm behind in patches, as I've been on the road for a week.
I'll get to it tommorrow.
Sorry for the delay.
thanks,
greg k-h
On Tue, Sep 07, 2004 at 08:15:37PM -0700, Jon Smirl wrote:
> Greg, are you going to send pci-sysfs-rom-22.patch upstream? Or do I
> need to do it, if so how? Jesse's objection turned out to be a problem
> in another piece of code.
Ok, I've applied this to my kernel trees and it will show up in the next
-mm release. Nice job everyone.
thanks,
greg k-h
Linus has requested that the sysfs rom attribute be changed to require
enabling before it works. echo "0" to the attribute to disable,
echoing anything else enables the rom output. The concern is that
something like a file browser could inadvertently read the attribute
and change the state of the hardware without the user's knowledge.
The attached patch includes the previous patch plus the enabling logic.
[root@smirl 0000:02:02.0]#
[root@smirl 0000:02:02.0]# cat rom
cat: rom: Invalid argument
[root@smirl 0000:02:02.0]# echo "1" >rom
[root@smirl 0000:02:02.0]# hexdump -C -n 20 rom
00000000 55 aa 60 e9 d6 01 00 00 00 00 00 00 00 00 00 00 |U.`.............|
00000010 00 00 00 00 |....|
00000014
[root@smirl 0000:02:02.0]# echo "0" >rom
[root@smirl 0000:02:02.0]# hexdump -C -n 20 rom
hexdump: rom: Invalid argument
[root@smirl 0000:02:02.0]#
--
Jon Smirl
[email protected]
On Thu, Oct 07, 2004 at 10:20:39PM -0400, Jon Smirl wrote:
> Linus has requested that the sysfs rom attribute be changed to require
> enabling before it works. echo "0" to the attribute to disable,
> echoing anything else enables the rom output. The concern is that
> something like a file browser could inadvertently read the attribute
> and change the state of the hardware without the user's knowledge.
>
> The attached patch includes the previous patch plus the enabling logic.
Applied, thanks.
greg k-h