2004-09-27 15:35:13

by Linus Torvalds

Subject: Re: PATCH: TTY ldisc and termios locking work

Alan,
this seems to be corrupted. A quick read-through found this in
generic_serial.c:

+ ld = tty_ldisc_ref(tty);
+ if (ld != NULL) {
+ ld->flush_buffer)
+ ld->flush_buffer(tty);
+ tty_ldisc_deref(ld);
+ }

I can see the missing "if (" in my mind, but I'm wondering what else I
might have missed. Ie can we have this patch be tested a bit more first?

Linus

2004-09-27 15:42:06

by Alan Cox

Subject: Re: PATCH: TTY ldisc and termios locking work

On Mon, Sep 27, 2004 at 08:34:50AM -0700, Linus Torvalds wrote:
> + ld = tty_ldisc_ref(tty);
> + if (ld != NULL) {
> + ld->flush_buffer)
> + ld->flush_buffer(tty);
> + tty_ldisc_deref(ld);
> + }
>
> I can see the missing "if (" in my mind, but I'm wondering what else I
> might have missed. Ie can we have this patch be tested a bit more first?

Its been running for several days. generic_serial got missed because its
BROKEN_ON_SMP for all users and so never got built. Fixed in my tree now.

Alan