2004-10-25 22:08:50

by Pavel Machek

Subject: kill pm_access & friends from input layer

Hi!

pm_access is a NOP (both in CONFIG_PM and !CONFIG_PM cases, its simply
obsolete), and ugly one, too. This removes it from input layer. Please
apply,

Pavel


--- clean/drivers/input/input.c 2004-08-15 19:14:56.000000000 +0200
+++ linux/drivers/input/input.c 2004-10-25 23:54:57.000000000 +0200
@@ -67,9 +67,6 @@
{
struct input_handle *handle;

- if (dev->pm_dev)
- pm_access(dev->pm_dev);
-
if (type > EV_MAX || !test_bit(type, dev->evbit))
return;

@@ -230,8 +227,6 @@

int input_open_device(struct input_handle *handle)
{
- if (handle->dev->pm_dev)
- pm_access(handle->dev->pm_dev);
handle->open++;
if (handle->dev->open)
return handle->dev->open(handle->dev);
@@ -249,8 +244,6 @@
void input_close_device(struct input_handle *handle)
{
input_release_device(handle);
- if (handle->dev->pm_dev)
- pm_dev_idle(handle->dev->pm_dev);
if (handle->dev->close)
handle->dev->close(handle->dev);
handle->open--;

--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

2004-10-26 01:25:45

by Dmitry Torokhov

Subject: Re: kill pm_access & friends from input layer

On Monday 25 October 2004 05:00 pm, Pavel Machek wrote:
> Hi!
>
> pm_access is a NOP (both in CONFIG_PM and !CONFIG_PM cases, its simply
> obsolete), and ugly one, too. This removes it from input layer. Please
> apply,
>
Hi,

It is already in Vojtech's tee (Pat killed them).

--
Dmitry