On Mon, Dec 27, 2004 at 02:19:43PM -0500, Dmitry Torokhov wrote:
> On Monday 27 December 2004 09:28 am, Vojtech Pavlik wrote:
> > [email protected], 2004-10-21 23:52:36-05:00, [email protected]
> > ? Input: i8042 - allow turning debugging on and off "on-fly"
> > ? ? ? ? ?so people do not have to recompile their kernels to
> > ? ? ? ? ?provide debug info.
> > ?
> > ? ? ? ? ?Adds new parameter i8042.debug also accessible through
> > ? ? ? ? ?sysfs.
> > ?
> > ? Signed-off-by: Dmitry Torokhov <[email protected]>
>
> Hi,
>
> This one needs the patch below to correct permissions braindamage.
Applied. Linus, please pull now.
> ===================================================================
>
>
> [email protected], 2004-11-25 00:33:20-05:00, [email protected]
> Input: i8042 - fix "debug" parameter sysfs permissions.
>
> Signed-off-by: Dmitry Torokhov <[email protected]>
>
>
> i8042.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> ===================================================================
>
>
>
> diff -Nru a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
> --- a/drivers/input/serio/i8042.c 2004-11-25 01:27:15 -05:00
> +++ b/drivers/input/serio/i8042.c 2004-11-25 01:27:15 -05:00
> @@ -68,7 +68,7 @@
> #define DEBUG
> #ifdef DEBUG
> static int i8042_debug;
> -module_param_named(debug, i8042_debug, bool, 600);
> +module_param_named(debug, i8042_debug, bool, 0600);
> MODULE_PARM_DESC(debug, "Turn i8042 debugging mode on and off");
> #endif
--
Vojtech Pavlik
SuSE Labs, SuSE CR
I pulled and immediately unpulled again.
Vojtech, stuff like this is unacceptable:
PS/2 driver library (SERIO_LIBPS2) [N/m/y/?] (NEW) ?
Say Y here if you are using a driver for device connected
to a PS/2 port, such as PS/2 mouse or standard AT keyboard.
Stop messing with peoples minds. The default config should contain
keyboard and mouse support, and unless the user asks for "Embedded" or the
year 2010 comes along and you can't find computers with non-USB keyboards
anyway, that's how it's going to remain.
We had this _idiocy_ early in 2.5.x, and it caused untold silly problems.
We fixed it. We're not going to re-do that mistake.
Please re-do your BK tree without this. Also, considering that every
_single_ time we've messed with the legacy keyboard/mouse controller there
have been compatibility problems, I want to know what the advantages are.
Does the work actually _fix_ anything, and has it in any way been tested
on the millions of different versions of kbd controller clones out there?
Linus
On Tuesday 04 January 2005 12:54 am, Linus Torvalds wrote:
>
> I pulled and immediately unpulled again.
>
> Vojtech, stuff like this is unacceptable:
>
> PS/2 driver library (SERIO_LIBPS2) [N/m/y/?] (NEW) ?
>
> Say Y here if you are using a driver for device connected
> to a PS/2 port, such as PS/2 mouse or standard AT keyboard.
>
> Stop messing with peoples minds. The default config should contain
> keyboard and mouse support, and unless the user asks for "Embedded" or the
> year 2010 comes along and you can't find computers with non-USB keyboards
> anyway, that's how it's going to remain.
>
> We had this _idiocy_ early in 2.5.x, and it caused untold silly problems.
> We fixed it. We're not going to re-do that mistake.
>
When I do "make oldconfig" it silently sets SERIO_LIBPS2 to Y if I have
either atkbd or psmouse built-in and if both of them are modules it gives
option [M/y]. Do you have atkbd or psmouse selected?
> Please re-do your BK tree without this. Also, considering that every
> _single_ time we've messed with the legacy keyboard/mouse controller there
> have been compatibility problems, I want to know what the advantages are.
It folds sizeable chunks of the same code from atkbd and psmouse so for ease
of maintenance.
--
Dmitry
On Mon, Jan 03, 2005 at 09:54:33PM -0800, Linus Torvalds wrote:
> I pulled and immediately unpulled again.
>
> Vojtech, stuff like this is unacceptable:
>
> PS/2 driver library (SERIO_LIBPS2) [N/m/y/?] (NEW) ?
>
> Say Y here if you are using a driver for device connected
> to a PS/2 port, such as PS/2 mouse or standard AT keyboard.
>
> Stop messing with peoples minds. The default config should contain
> keyboard and mouse support, and unless the user asks for "Embedded" or the
> year 2010 comes along and you can't find computers with non-USB keyboards
> anyway, that's how it's going to remain.
What machine this was on? Kernel config won't allow you to unselect that
option if AT Keyboard is selected, and that's always selected when
CONFIG_PC is.
> We had this _idiocy_ early in 2.5.x, and it caused untold silly problems.
> We fixed it. We're not going to re-do that mistake.
> Please re-do your BK tree without this
I tested it then, and now again. And I can't get the prompt you're
getting.
$ bk clone linus test
$ cd test
$ bk -r get
$ make defconfig
$ bk pull ../input
$ make oldconfig
doesn't ask ANY questions.
I can imagine that option being asked about on a Mac, but there it might
make sense, or at least cause no harm if you enable it, even if it's
not needed.
> Also, considering that every
> _single_ time we've messed with the legacy keyboard/mouse controller there
> have been compatibility problems, I want to know what the advantages are.
The changes to the keyboard/mouse controller code (i8042.c) are added
powermanagement callbacks, which are very much needed, and added ACPI
probing, which, although not strictly needed, is a less intrusive way of
detecting whether a kbd/mouse controller is present.
Regarding libps2, that doesn't touch the controller code itself, only
the mouse and keyboard drivers. It's a refactoring of the code,
eliminating a bunch of duplicate code which had a tendency of diverging
and that was causing problems. It shouldn't change any functionality per
se.
> Does the work actually _fix_ anything,
The refactoring itself didn't fix any problems, and it wasn't intended
to, but it uncovered some bugs that when fixed, made real problems go
away, like the ACK timeouts in RESET_BAT code path.
> and has it in any way been tested on the millions of different
> versions of kbd controller clones out there?
Does a few months in Andrew's tree count?
--
Vojtech Pavlik
SuSE Labs, SuSE CR
On Tue, Jan 04, 2005 at 01:14:26AM -0500, Dmitry Torokhov wrote:
> On Tuesday 04 January 2005 12:54 am, Linus Torvalds wrote:
> >
> > I pulled and immediately unpulled again.
> >
> > Vojtech, stuff like this is unacceptable:
> >
> > PS/2 driver library (SERIO_LIBPS2) [N/m/y/?] (NEW) ?
> >
> > Say Y here if you are using a driver for device connected
> > to a PS/2 port, such as PS/2 mouse or standard AT keyboard.
> >
> > Stop messing with peoples minds. The default config should contain
> > keyboard and mouse support, and unless the user asks for "Embedded" or the
> > year 2010 comes along and you can't find computers with non-USB keyboards
> > anyway, that's how it's going to remain.
> >
> > We had this _idiocy_ early in 2.5.x, and it caused untold silly problems.
> > We fixed it. We're not going to re-do that mistake.
>
> When I do "make oldconfig" it silently sets SERIO_LIBPS2 to Y if I have
> either atkbd or psmouse built-in and if both of them are modules it gives
> option [M/y]. Do you have atkbd or psmouse selected?
>...
As far as I can see, you are correct, and unless you are on !X86 or have
EMBEDDED enabled SERIO_LIBPS2 is always forced to yes.
But although it doesn't seem to be a problem, I'm wondering why
SERIO_LIBPS2 is a user-visible option?
> Dmitry
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Tue, 4 Jan 2005 15:50:11 +0100, Adrian Bunk <[email protected]> wrote:
> On Tue, Jan 04, 2005 at 01:14:26AM -0500, Dmitry Torokhov wrote:
> > When I do "make oldconfig" it silently sets SERIO_LIBPS2 to Y if I have
> > either atkbd or psmouse built-in and if both of them are modules it gives
> > option [M/y]. Do you have atkbd or psmouse selected?
> >...
>
> As far as I can see, you are correct, and unless you are on !X86 or have
> EMBEDDED enabled SERIO_LIBPS2 is always forced to yes.
>
> But although it doesn't seem to be a problem, I'm wondering why
> SERIO_LIBPS2 is a user-visible option?
>
LIBPS2 is a mid-level library for accessing a device behing PS/2 port.
Like with CRC library there potentially could be some out-of-tree
moules using it so user has an option of building the library in the
kernel, or as a module, or omitting it.
For the vast majority of users it is selected automatically without any
questions.
--
Dmitry
On Tue, 4 Jan 2005, Vojtech Pavlik wrote:
>
> What machine this was on? Kernel config won't allow you to unselect that
> option if AT Keyboard is selected, and that's always selected when
> CONFIG_PC is.
Ahh. It's a G5 mac, so I guess it isn't needed. Even so, that thing
shouldn't show up. If I don't have AT keyboard _or_ mouse selected, it
shouldn't be there - they should "select" it, and if nothing uses it, then
there isn't anything to do. In no case should it show up as a question.
> > and has it in any way been tested on the millions of different
> > versions of kbd controller clones out there?
>
> Does a few months in Andrew's tree count?
So it has been part of the -mm tree? Good.
Linus
On Tue, 4 Jan 2005, Vojtech Pavlik wrote:
>
> I can hide it, the reasoning was that it may be useful for out-of-kernel
> modules, and because of that it's possible to enable it even when there
> are no users, and only then it's an option.
>
> atkbd and psmouse do "select" it.
Ok, that seems fine. I'll hide it behind "EMBEDDED" at least until
somebody actually has an out-of-tree user on any platform where it makes
any sense (on a PC it will be enabled _anyway_ by the kbd/mouse thing, and
on anything else I don't see it making any sense anyway, and it clearly
only confuses people - since it confused me).
> > So it has been part of the -mm tree? Good.
>
> Yes.
Ok. I'll re-pull and make it embedded to make that irritating question go
away.
Linus
On Tue, Jan 04, 2005 at 07:58:50AM -0800, Linus Torvalds wrote:
> > What machine this was on? Kernel config won't allow you to unselect that
> > option if AT Keyboard is selected, and that's always selected when
> > CONFIG_PC is.
> Ahh. It's a G5 mac, so I guess it isn't needed. Even so, that thing
> shouldn't show up. If I don't have AT keyboard _or_ mouse selected, it
> shouldn't be there - they should "select" it, and if nothing uses it, then
> there isn't anything to do. In no case should it show up as a question.
I can hide it, the reasoning was that it may be useful for out-of-kernel
modules, and because of that it's possible to enable it even when there
are no users, and only then it's an option.
atkbd and psmouse do "select" it.
> > > and has it in any way been tested on the millions of different
> > > versions of kbd controller clones out there?
> >
> > Does a few months in Andrew's tree count?
>
> So it has been part of the -mm tree? Good.
Yes.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
On Tue, Jan 04, 2005 at 07:58:50AM -0800, Linus Torvalds wrote:
> Ahh. It's a G5 mac, so I guess it isn't needed. Even so, that thing
> shouldn't show up. If I don't have AT keyboard _or_ mouse selected, it
> shouldn't be there - they should "select" it, and if nothing uses it, then
> there isn't anything to do. In no case should it show up as a question.
Compiling in PC keyboard controller support will actually crash your
shiny G5 mac ;-)
On Tue, 4 Jan 2005 08:14:52 -0800 (PST), Linus Torvalds
<[email protected]> wrote:
>
>
> On Tue, 4 Jan 2005, Vojtech Pavlik wrote:
> >
> > I can hide it, the reasoning was that it may be useful for out-of-kernel
> > modules, and because of that it's possible to enable it even when there
> > are no users, and only then it's an option.
> >
> > atkbd and psmouse do "select" it.
>
> Ok, that seems fine. I'll hide it behind "EMBEDDED" at least until
> somebody actually has an out-of-tree user on any platform where it makes
> any sense (on a PC it will be enabled _anyway_ by the kbd/mouse thing, and
> on anything else I don't see it making any sense anyway, and it clearly
> only confuses people - since it confused me).
>
i8042-style ports are not limited to PC - maceps2.c, q40kbd.c,
rpckbd.c and sa1111ps2.c also implement them that's why libps2 wasn't
limited to x86 arch.
--
Dmitry
On Tue, Jan 04, 2005 at 08:14:52AM -0800, Linus Torvalds wrote:
> On Tue, 4 Jan 2005, Vojtech Pavlik wrote:
> >
> > I can hide it, the reasoning was that it may be useful for out-of-kernel
> > modules, and because of that it's possible to enable it even when there
> > are no users, and only then it's an option.
> >
> > atkbd and psmouse do "select" it.
>
> Ok, that seems fine. I'll hide it behind "EMBEDDED" at least until
> somebody actually has an out-of-tree user on any platform where it makes
> any sense (on a PC it will be enabled _anyway_ by the kbd/mouse thing, and
> on anything else I don't see it making any sense anyway, and it clearly
> only confuses people - since it confused me).
Ok.
> > > So it has been part of the -mm tree? Good.
> >
> > Yes.
>
> Ok. I'll re-pull and make it embedded to make that irritating question go
> away.
Thanks.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
On Tue, 4 Jan 2005 17:40:25 +0100, Vojtech Pavlik <[email protected]> wrote:
> On Tue, Jan 04, 2005 at 08:14:52AM -0800, Linus Torvalds wrote:
>
> > Ok. I'll re-pull and make it embedded to make that irritating question go
> > away.
>
> Thanks.
>
Ok, now only couple of things were left out:
http://marc.theaimsgroup.com/?l=linux-kernel&m=110430679525030&w=2
08-atkbd-keycode-size.patch
Fix keycode table size initialization that got broken by my changes
that exported 'set' and other settings via sysfs.
setkeycodes should work again now.
http://marc.theaimsgroup.com/?l=linux-kernel&m=110430749420252&w=2
06-ps2pp-mouse-name.patch
Set mouse name to "Mouse" instead of leaving it NULL when using
PS2++ protocol and don't have any other information (Wheel, Touchpad)
about the mouse.
06 is not too critical but without 08 setkeycodes will not work.
In any case I'd like the following patches (01-08, see
http://marc.theaimsgroup.com/?l=linux-kernel&m=110430597110513&w=2) to
be moved forward as they were also staged in -mm tree for over a month
and work fine on my 3 boxes.
--
Dmitry
On Tue, Jan 04, 2005 at 12:22:17PM -0500, Dmitry Torokhov wrote:
> On Tue, 4 Jan 2005 17:40:25 +0100, Vojtech Pavlik <[email protected]> wrote:
> > On Tue, Jan 04, 2005 at 08:14:52AM -0800, Linus Torvalds wrote:
> >
> > > Ok. I'll re-pull and make it embedded to make that irritating question go
> > > away.
> >
> > Thanks.
> >
>
> Ok, now only couple of things were left out:
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110430679525030&w=2
> 08-atkbd-keycode-size.patch
> Fix keycode table size initialization that got broken by my changes
> that exported 'set' and other settings via sysfs.
> setkeycodes should work again now.
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110430749420252&w=2
> 06-ps2pp-mouse-name.patch
> Set mouse name to "Mouse" instead of leaving it NULL when using
> PS2++ protocol and don't have any other information (Wheel, Touchpad)
> about the mouse.
>
> 06 is not too critical but without 08 setkeycodes will not work.
>
> In any case I'd like the following patches (01-08, see
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110430597110513&w=2) to
> be moved forward as they were also staged in -mm tree for over a month
> and work fine on my 3 boxes.
OK, I'll merge them, and prepare yet another pull for Linus.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
On Tue, 4 Jan 2005, Dmitry Torokhov wrote:
>
> i8042-style ports are not limited to PC - maceps2.c, q40kbd.c,
> rpckbd.c and sa1111ps2.c also implement them that's why libps2 wasn't
> limited to x86 arch.
So?
If you select ATKBD then LIBPS2 should be selected _automatically_.
My point is that there is _never_ a reason to ask about it. Ever.
I'll let crazy people select EMBEDDED if they want to see the question,
but even that is in my opinion likely unnecessary.
Linus
On Tue, 4 Jan 2005 10:03:19 -0800 (PST), Linus Torvalds
<[email protected]> wrote:
>
>
> On Tue, 4 Jan 2005, Dmitry Torokhov wrote:
> >
> > i8042-style ports are not limited to PC - maceps2.c, q40kbd.c,
> > rpckbd.c and sa1111ps2.c also implement them that's why libps2 wasn't
> > limited to x86 arch.
>
> So?
>
I was referring to your statement that on PCs it is selected
automatically as if only PC can use libps2.
> If you select ATKBD then LIBPS2 should be selected _automatically_.
>
> My point is that there is _never_ a reason to ask about it. Ever.
I'll code some tiny PS/2 driver and will keep it out of the tree just
to prove you wrong ;)
--
Dmitry