2005-04-12 08:35:56

by Chen, Kenneth W

Subject: Prototype error in <linux/debugfs.h>

To lazy to write a patch, the inline debugfs function declaration
for the following three functions disagree between CONFIG_DEBUG_FS
and !CONFIG_DEBUG_FS

4th argument mismatch, looks like an obvious copy-n-paste error.
u16, u32, and u32?


static inline struct dentry *debugfs_create_u16(const char *name, mode_t mode,
struct dentry *parent,
u8 *value)
{
return ERR_PTR(-ENODEV);
}

static inline struct dentry *debugfs_create_u32(const char *name, mode_t mode,
struct dentry *parent,
u8 *value)
{
return ERR_PTR(-ENODEV);
}

static inline struct dentry *debugfs_create_bool(const char *name, mode_t mode,
struct dentry *parent,
u8 *value)
{
return ERR_PTR(-ENODEV);
}

2005-04-12 08:44:19

by Greg KH

Subject: Re: Prototype error in <linux/debugfs.h>

On Tue, Apr 12, 2005 at 01:35:51AM -0700, Chen, Kenneth W wrote:
> To lazy to write a patch, the inline debugfs function declaration
> for the following three functions disagree between CONFIG_DEBUG_FS
> and !CONFIG_DEBUG_FS
>
> 4th argument mismatch, looks like an obvious copy-n-paste error.
> u16, u32, and u32?

Already fixed in the -mm tree, patch is queued to be sent to Linus, once
he starts accepting patches again.

thanks,

greg k-h