2005-10-18 23:45:15

by Tom Rini

[permalink] [raw]
Subject: [PATCH 2.6.14-rc4][RESEND] Export RCS_TAR_IGNORE for rpm targets

[ Originally sent Oct 10, no comments but should be clearly correct ]

The variable RCS_TAR_IGNORE is used in scripts/packaging/Makefile, but
not exported from the main Makefile, so it's never used.

This results in the rpm targets being very unhappy in quilted trees.

Signed-off-by: Tom Rini <[email protected]>

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -372,7 +372,7 @@ export MODVERDIR := $(if $(KBUILD_EXTMOD
# Files to ignore in find ... statements

RCS_FIND_IGNORE := \( -name SCCS -o -name BitKeeper -o -name .svn -o -name CVS -o -name .pc -o -name .hg \) -prune -o
-RCS_TAR_IGNORE := --exclude SCCS --exclude BitKeeper --exclude .svn --exclude CVS --exclude .pc --exclude .hg
+export RCS_TAR_IGNORE := --exclude SCCS --exclude BitKeeper --exclude .svn --exclude CVS --exclude .pc --exclude .hg

# ===========================================================================
# Rules shared between *config targets and build targets

--
Tom Rini
http://gate.crashing.org/~trini/


2005-10-19 06:04:31

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH 2.6.14-rc4][RESEND] Export RCS_TAR_IGNORE for rpm targets

Andrew - please apply. It's an obvious bugfix.

Sam

On Tue, Oct 18, 2005 at 04:45:12PM -0700, Tom Rini wrote:
> [ Originally sent Oct 10, no comments but should be clearly correct ]
>
> The variable RCS_TAR_IGNORE is used in scripts/packaging/Makefile, but
> not exported from the main Makefile, so it's never used.
>
> This results in the rpm targets being very unhappy in quilted trees.
>
> Signed-off-by: Tom Rini <[email protected]>
Signed-off-by: Sam Ravnborg <[email protected]>

>
> diff --git a/Makefile b/Makefile
> --- a/Makefile
> +++ b/Makefile
> @@ -372,7 +372,7 @@ export MODVERDIR := $(if $(KBUILD_EXTMOD
> # Files to ignore in find ... statements
>
> RCS_FIND_IGNORE := \( -name SCCS -o -name BitKeeper -o -name .svn -o -name CVS -o -name .pc -o -name .hg \) -prune -o
> -RCS_TAR_IGNORE := --exclude SCCS --exclude BitKeeper --exclude .svn --exclude CVS --exclude .pc --exclude .hg
> +export RCS_TAR_IGNORE := --exclude SCCS --exclude BitKeeper --exclude .svn --exclude CVS --exclude .pc --exclude .hg
>
> # ===========================================================================
> # Rules shared between *config targets and build targets
>
> --
> Tom Rini
> http://gate.crashing.org/~trini/
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/