Without the included patch, I get the following compile error for um:
arch/um/kernel/tt/uaccess.c: In function `copy_from_user_tt':
arch/um/kernel/tt/uaccess.c:11: error: `FIXADDR_USER_START' undeclared (first use in this function)
arch/um/kernel/tt/uaccess.c:11: error: (Each undeclared identifier is reported only once
arch/um/kernel/tt/uaccess.c:11: error: for each function it appears in.)
The error only happens when I disable CONFIG_MODE_SKAS.
Signed-off-by: Pekka Enberg <[email protected]>
---
uaccess-tt.h | 1 +
1 file changed, 1 insertion(+)
Index: 2.6/arch/um/kernel/tt/include/uaccess-tt.h
===================================================================
--- 2.6.orig/arch/um/kernel/tt/include/uaccess-tt.h
+++ 2.6/arch/um/kernel/tt/include/uaccess-tt.h
@@ -8,6 +8,7 @@
#include "linux/string.h"
#include "linux/sched.h"
+#include "asm/fixmap.h"
#include "asm/processor.h"
#include "asm/errno.h"
#include "asm/current.h"
On Tuesday 06 December 2005 21:24, Pekka Enberg wrote:
> Without the included patch, I get the following compile error for um:
>
> arch/um/kernel/tt/uaccess.c: In function `copy_from_user_tt':
> arch/um/kernel/tt/uaccess.c:11: error: `FIXADDR_USER_START' undeclared
> (first use in this function) arch/um/kernel/tt/uaccess.c:11: error: (Each
> undeclared identifier is reported only once arch/um/kernel/tt/uaccess.c:11:
> error: for each function it appears in.)
>
> The error only happens when I disable CONFIG_MODE_SKAS.
Ok, fine, just a note - the header inclusion should be added to
arch/um/include/um_uaccess.h
where it is effectively used (the offending macros, using FIXADDR_USER_*, are
__access_ok_vsyscall.
For the rest it's ok.
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
___________________________________
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB
http://mail.yahoo.it
Hi,
On Wed, 7 Dec 2005, Blaisorblade wrote:
> Ok, fine, just a note - the header inclusion should be added to
>
> arch/um/include/um_uaccess.h
>
> where it is effectively used (the offending macros, using FIXADDR_USER_*, are
> __access_ok_vsyscall.
>
> For the rest it's ok.
Here's an updated patch.
[PATCH] um: fix compile error for tt
Without the included patch, I get the following compile error for um:
arch/um/kernel/tt/uaccess.c: In function `copy_from_user_tt':
arch/um/kernel/tt/uaccess.c:11: error: `FIXADDR_USER_START' undeclared (first use in this function)
arch/um/kernel/tt/uaccess.c:11: error: (Each undeclared identifier is reported only once
arch/um/kernel/tt/uaccess.c:11: error: for each function it appears in.)
I get the compile error when I disable CONFIG_MODE_SKAS.
Signed-off-by: Pekka Enberg <[email protected]>
---
include/um_uaccess.h | 2 ++
kernel/skas/include/uaccess-skas.h | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)
Index: 2.6/arch/um/include/um_uaccess.h
===================================================================
--- 2.6.orig/arch/um/include/um_uaccess.h
+++ 2.6/arch/um/include/um_uaccess.h
@@ -17,6 +17,8 @@
#include "uaccess-skas.h"
#endif
+#include "asm/fixmap.h"
+
#define __under_task_size(addr, size) \
(((unsigned long) (addr) < TASK_SIZE) && \
(((unsigned long) (addr) + (size)) < TASK_SIZE))
Index: 2.6/arch/um/kernel/skas/include/uaccess-skas.h
===================================================================
--- 2.6.orig/arch/um/kernel/skas/include/uaccess-skas.h
+++ 2.6/arch/um/kernel/skas/include/uaccess-skas.h
@@ -7,7 +7,6 @@
#define __SKAS_UACCESS_H
#include "asm/errno.h"
-#include "asm/fixmap.h"
/* No SKAS-specific checking. */
#define access_ok_skas(type, addr, size) 0
On Wednesday 07 December 2005 14:39, Pekka J Enberg wrote:
> Hi,
>
> On Wed, 7 Dec 2005, Blaisorblade wrote:
> > Ok, fine, just a note - the header inclusion should be added to
> >
> > arch/um/include/um_uaccess.h
> >
> > where it is effectively used (the offending macros, using FIXADDR_USER_*,
> > are __access_ok_vsyscall.
> >
> > For the rest it's ok.
>
> Here's an updated patch.
ACK - Andrew, please merge (and queue for -linus), or notify if it needs to be
resent. Thanks.
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
___________________________________
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB
http://mail.yahoo.it