2006-01-09 19:15:18

by Stephen Hemminger

Subject: [PATCH] random: get rid of sparse warning

Get rid of bogus extern attribute that causes sparse warning.

Signed-off-by: Stephen Hemminger <[email protected]>


--- linux-2.6.orig/drivers/char/random.c
+++ linux-2.6/drivers/char/random.c
@@ -632,7 +632,7 @@ out:
preempt_enable();
}

-extern void add_input_randomness(unsigned int type, unsigned int code,
+void add_input_randomness(unsigned int type, unsigned int code,
unsigned int value)
{
static unsigned char last_value;

2006-01-09 19:25:12

by Matt Mackall

Subject: Re: [PATCH] random: get rid of sparse warning

On Mon, Jan 09, 2006 at 11:15:07AM -0800, Stephen Hemminger wrote:
> Get rid of bogus extern attribute that causes sparse warning.
>
> Signed-off-by: Stephen Hemminger <[email protected]>

Death to extern!

Acked-by: Matt Mackall <[email protected]>

--
Mathematics is the supreme nostalgia of our time.