2006-01-23 13:52:33

by Dan Aloni

Subject: Re: [PATCH] x86_64: Remove useless KDB vector

> It was set as an NMI, but the NMI bit always forces an interrupt
> to end up at vector 2. So it was never used. Remove.

So with this function removed, what is the proper fix for using
the kdb x86_64 patch (forward-ported from 2.6.14) on 2.6.16-rc1?
Can I expect it to work properly if I just remove the function
call?

--
Dan Aloni
[email protected], [email protected], [email protected], [email protected]

2006-01-23 14:19:04

by Andi Kleen

Subject: Re: [PATCH] x86_64: Remove useless KDB vector

On Monday 23 January 2006 14:55, Dan Aloni wrote:
> > It was set as an NMI, but the NMI bit always forces an interrupt
> > to end up at vector 2. So it was never used. Remove.
>
> So with this function removed, what is the proper fix for using
> the kdb x86_64 patch (forward-ported from 2.6.14) on 2.6.16-rc1?
> Can I expect it to work properly if I just remove the function
> call?

Add this code snippet to arch/x86_64/kdb/kdbasupport.c

#include <asm/mach_apic.h>
#include <asm/hw_irq.h>
void smp_kdb_stop(void)
{
send_IPI_allbutself(NMI_VECTOR);
}


-Andi