2006-01-25 06:41:01

by Herbert Poetzl

Subject: [Patch] quota: fix error code for ext2_new_inode()

Hi Honza!

the quota check in ext2_new_inode() returns ENOSPC where
IMHO it should return EDQUOT instead. here is a trivial
patch to fix that ...

rationale: ext3, reiser, udf and ufs do similar checks
and already return EDQUOT

best,
Herbert

Signed-off-by: Herbert P?tzl <[email protected]>

--- ./fs/ext2/ialloc.c.orig 2006-01-03 17:29:56 +0100
+++ ./fs/ext2/ialloc.c 2006-01-25 07:26:42 +0100
@@ -605,7 +605,7 @@ got:
insert_inode_hash(inode);

if (DQUOT_ALLOC_INODE(inode)) {
- err = -ENOSPC;
+ err = -EDQUOT;
goto fail_drop;
}

2006-01-25 12:19:28

by Jan Kara

Subject: Re: [Patch] quota: fix error code for ext2_new_inode()

Hi,

> the quota check in ext2_new_inode() returns ENOSPC where
> IMHO it should return EDQUOT instead. here is a trivial
> patch to fix that ...
>
> rationale: ext3, reiser, udf and ufs do similar checks
> and already return EDQUOT
Of course, you're right! Andrew please commit this one too.

Honza


> Signed-off-by: Herbert P?tzl <[email protected]>
Acked-by: Jan Kara <[email protected]>

> --- ./fs/ext2/ialloc.c.orig 2006-01-03 17:29:56 +0100
> +++ ./fs/ext2/ialloc.c 2006-01-25 07:26:42 +0100
> @@ -605,7 +605,7 @@ got:
> insert_inode_hash(inode);
>
> if (DQUOT_ALLOC_INODE(inode)) {
> - err = -ENOSPC;
> + err = -EDQUOT;
> goto fail_drop;
> }
>
>
--
Jan Kara <[email protected]>
SuSE CR Labs