2006-02-01 17:55:54

by Stephen Hemminger

Subject: [PATCH] sysctl initialization of zone_reclaim_mode

Fix warning about initialization of sysctl table in current 2.6.16-rc1
git tree. It could cause a nasty if anyone wrote to it.

Signed-off-by: Stephen Hemminger <[email protected]>

--- linux-2.6.orig/kernel/sysctl.c
+++ linux-2.6/kernel/sysctl.c
@@ -878,7 +878,8 @@ static ctl_table vm_table[] = {
.maxlen = sizeof(zone_reclaim_mode),
.mode = 0644,
.proc_handler = &proc_dointvec,
- .strategy = &zero,
+ .strategy = &sysctl_intvec,
+ .extra1 = &zero,
},
#endif
{ .ctl_name = 0 }

2006-02-01 18:05:23

by Linus Torvalds

Subject: Re: [PATCH] sysctl initialization of zone_reclaim_mode

On Wed, 1 Feb 2006, Stephen Hemminger wrote:
>
> Fix warning about initialization of sysctl table in current 2.6.16-rc1
> git tree. It could cause a nasty if anyone wrote to it.

Already fixed in the current tree by Christoph Lameter,

Linus

2006-02-01 18:31:23

by Christoph Lameter

Subject: Re: [PATCH] sysctl initialization of zone_reclaim_mode

A cleanup patch has been in Andrews tree for awhile and I hope that Linus
applies it today. This is the ., hmm .... 4th time the patch was posted.

On Wed, 1 Feb 2006, Stephen Hemminger wrote:

> Fix warning about initialization of sysctl table in current 2.6.16-rc1
> git tree. It could cause a nasty if anyone wrote to it.
>
> Signed-off-by: Stephen Hemminger <[email protected]>
>
> --- linux-2.6.orig/kernel/sysctl.c
> +++ linux-2.6/kernel/sysctl.c
> @@ -878,7 +878,8 @@ static ctl_table vm_table[] = {
> .maxlen = sizeof(zone_reclaim_mode),
> .mode = 0644,
> .proc_handler = &proc_dointvec,
> - .strategy = &zero,
> + .strategy = &sysctl_intvec,
> + .extra1 = &zero,
> },
> #endif
> { .ctl_name = 0 }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>