2006-03-27 23:04:23

by Randy Dunlap

Subject: [PATCH] edac_752x needs CONFIG_HOTPLUG

From: Randy Dunlap <[email protected]>

EDAC_752X uses pci_scan_single_device(), which is only available
if CONFIG_HOTPLUG is enabled, so limit this driver with HOTPLUG.

Signed-off-by: Randy Dunlap <[email protected]>
---
drivers/edac/Kconfig | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2616-g13.orig/drivers/edac/Kconfig
+++ linux-2616-g13/drivers/edac/Kconfig
@@ -71,7 +71,7 @@ config EDAC_E7XXX

config EDAC_E752X
tristate "Intel e752x (e7520, e7525, e7320)"
- depends on EDAC_MM_EDAC && PCI && X86
+ depends on EDAC_MM_EDAC && PCI && X86 && HOTPLUG
help
Support for error detection and correction on the Intel
E7520, E7525, E7320 server chipsets.

---

2006-03-27 23:38:44

by Andrew Morton

Subject: Re: [PATCH] edac_752x needs CONFIG_HOTPLUG

"Randy.Dunlap" <[email protected]> wrote:
>
> EDAC_752X uses pci_scan_single_device(), which is only available
> if CONFIG_HOTPLUG is enabled

hm. That's not a hotpluggable device, surely?

If not then either a) PCI should be implementing pci_scan_single_device()
if !CONFIG_HOTPLUG or b) EDAC shouldn't be using pci_scan_single_device().

2006-03-27 23:47:08

by Randy Dunlap

Subject: Re: [PATCH] edac_752x needs CONFIG_HOTPLUG

On Mon, 27 Mar 2006 15:40:55 -0800 Andrew Morton wrote:

> "Randy.Dunlap" <[email protected]> wrote:
> >
> > EDAC_752X uses pci_scan_single_device(), which is only available
> > if CONFIG_HOTPLUG is enabled
>
> hm. That's not a hotpluggable device, surely?
>
> If not then either a) PCI should be implementing pci_scan_single_device()
> if !CONFIG_HOTPLUG or b) EDAC shouldn't be using pci_scan_single_device().

or just that one if block should be surrounded by CONFIG_HOTPLUG
(done cleanly, of course).

---
~Randy