2006-08-07 21:12:26

by Randy Dunlap

Subject: [PATCH 5/9] Replace ARCH_HAS_FLUSH_ANON_PAGE with CONFIG_ARCH_FLUSH_ANON_PAGE

From: Randy Dunlap <[email protected]>

Replace ARCH_HAS_FLUSH_ANON_PAGE with CONFIG_ARCH_FLUSH_ANON_PAGE.

Signed-off-by: Randy Dunlap <[email protected]>
---
arch/parisc/Kconfig | 3 +++
include/asm-parisc/cacheflush.h | 1 -
include/linux/highmem.h | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)

--- linux-2618-rc4-arch.orig/include/asm-parisc/cacheflush.h
+++ linux-2618-rc4-arch/include/asm-parisc/cacheflush.h
@@ -189,7 +189,6 @@ flush_anon_page(struct page *page, unsig
if (PageAnon(page))
flush_user_dcache_page(vmaddr);
}
-#define ARCH_HAS_FLUSH_ANON_PAGE

static inline void
flush_kernel_dcache_page(struct page *page)
--- linux-2618-rc4-arch.orig/include/linux/highmem.h
+++ linux-2618-rc4-arch/include/linux/highmem.h
@@ -6,7 +6,7 @@

#include <asm/cacheflush.h>

-#ifndef ARCH_HAS_FLUSH_ANON_PAGE
+#ifndef CONFIG_ARCH_FLUSH_ANON_PAGE
static inline void flush_anon_page(struct page *page, unsigned long vmaddr)
{
}
--- linux-2618-rc4-arch.orig/arch/parisc/Kconfig
+++ linux-2618-rc4-arch/arch/parisc/Kconfig
@@ -16,6 +16,9 @@ config PARISC
config MMU
def_bool y

+config ARCH_FLUSH_ANON_PAGE
+ def_bool y
+
config STACK_GROWSUP
def_bool y



---

2006-08-08 08:52:25

by Christoph Hellwig

Subject: Re: [PATCH 5/9] Replace ARCH_HAS_FLUSH_ANON_PAGE with CONFIG_ARCH_FLUSH_ANON_PAGE

On Mon, Aug 07, 2006 at 02:10:08PM -0700, Randy.Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Replace ARCH_HAS_FLUSH_ANON_PAGE with CONFIG_ARCH_FLUSH_ANON_PAGE.

Please just put the dummy flush_anon_page in every architectures header.

2006-08-08 14:18:14

by Kyle McMartin

Subject: Re: [PATCH 5/9] Replace ARCH_HAS_FLUSH_ANON_PAGE with CONFIG_ARCH_FLUSH_ANON_PAGE

On Tue, Aug 08, 2006 at 09:52:23AM +0100, Christoph Hellwig wrote:
> Please just put the dummy flush_anon_page in every architectures header.
>

That sounds much cleaner.

2006-08-08 15:53:38

by Randy Dunlap

Subject: Re: [PATCH 5/9] Replace ARCH_HAS_FLUSH_ANON_PAGE with CONFIG_ARCH_FLUSH_ANON_PAGE

On Tue, 8 Aug 2006 09:52:23 +0100 Christoph Hellwig wrote:

> On Mon, Aug 07, 2006 at 02:10:08PM -0700, Randy.Dunlap wrote:
> > From: Randy Dunlap <[email protected]>
> >
> > Replace ARCH_HAS_FLUSH_ANON_PAGE with CONFIG_ARCH_FLUSH_ANON_PAGE.
>
> Please just put the dummy flush_anon_page in every architectures header.

Nope, someone else can do that.

---
~Randy