2006-08-16 08:36:13

by Greg KH

[permalink] [raw]
Subject: Re: [linux-usb-devel] [PATCH] usb: The HID Simple Driver Interface 0.3.1 (core)

On Wed, Aug 16, 2006 at 02:23:12PM +0800, liyu wrote:
>
> Well, Where I can get some guide for how use #ifdef/#if ?

Documentation/CodingStyle.

Basically, don't use it in .c files, but only in .h files if necessary.

> Also, I found I can not send mail to <[email protected]> now,
> the reject reply like this:
>
> Connected to 209.132.176.167 but sender was rejected.
> Remote host said: 553 5.7.1 Hello [210.76.114.181], for your MAIL FROM address <[email protected]> policy analysis reported: Your address is not liked source for email
>
>
> Is it looked my mail as spam mail? Who should I send to for help me
> resolving this problem?

Go here:
http://vger.kernel.org/mxverify.html
to see how to fix this up.

good luck,

greg k-h


2006-08-16 09:15:23

by liyu

[permalink] [raw]
Subject: Re: [linux-usb-devel] [PATCH] usb: The HID Simple Driver Interface 0.3.1 (core)


Greg KH wrote:
> Go here:
> http://vger.kernel.org/mxverify.html
> to see how to fix this up.
>
>
That test site reply me "Apparently OK!", however, I still can not
send/receive any mail from LKML.

Also, I will review CodingStyle. Sorry for uncleanly code.

2006-08-16 14:51:10

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [linux-usb-devel] [PATCH] usb: The HID Simple Driver Interface 0.3.1 (core)

On Wednesday 16 August 2006 05:14, [email protected] wrote:
>
> Greg KH wrote:
> > Go here:
> > http://vger.kernel.org/mxverify.html
> > to see how to fix this up.
> >
> >
> That test site reply me "Apparently OK!", however, I still can not
> send/receive any mail from LKML.
>
> Also, I will review CodingStyle. Sorry for uncleanly code.
>

Hi,

Just an overall comment. I like the idea of simple plugins for HID but we
somehow need to allow them be built as modules and loaded on demand so
when I plug a device that needs special handling an appropriate piece
will get loaded and attached to the HID driver before my device is bound
to it. Built-ins are not very nice when you look from a distribution POV
becuase they have to enable every option and there are qute a few of devices
that need special handling.

--
Dmitry