2006-08-26 17:42:47

by Blaisorblade

[permalink] [raw]
Subject: [PATCH RFP-V4 02/13] Fix comment about remap_file_pages

From: Paolo 'Blaisorblade' Giarrusso <[email protected]>

This comment is a bit unclear and also stale. So fix it. Thanks to Hugh Dickins
for explaining me what it really referred to, and correcting my first fix.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[email protected]>
---

mm/fremap.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/mm/fremap.c b/mm/fremap.c
index 21b7d0c..cdeabad 100644
--- a/mm/fremap.c
+++ b/mm/fremap.c
@@ -215,9 +215,10 @@ #endif
pgoff, flags & MAP_NONBLOCK);

/*
- * We can't clear VM_NONLINEAR because we'd have to do
- * it after ->populate completes, and that would prevent
- * downgrading the lock. (Locks can't be upgraded).
+ * We would like to clear VM_NONLINEAR, in the case when
+ * sys_remap_file_pages covers the whole vma, so making
+ * it linear again. But cannot do so until after a
+ * successful populate, and have no way to upgrade sem.
*/
}
if (likely(!has_write_lock))
Chiacchiera con i tuoi amici in tempo reale!
http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com