2006-08-31 10:04:18

by Akinobu Mita

Subject: [PATCH] rate limiting for socket allocation failure messages

(Resending due to local mail server trouble)

This patch limits the warning messages when socket allocation
failures happen. It happens under memory pressure.

Cc: David Miller <[email protected]>
Signed-off-by: Akinobu Mita <[email protected]>

net/socket.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Index: work-shouldfail/net/socket.c
===================================================================
--- work-shouldfail.orig/net/socket.c
+++ work-shouldfail/net/socket.c
@@ -1178,7 +1178,8 @@ static int __sock_create(int family, int
*/

if (!(sock = sock_alloc())) {
- printk(KERN_WARNING "socket: no more sockets\n");
+ if (net_ratelimit())
+ printk(KERN_WARNING "socket: no more sockets\n");
err = -ENFILE; /* Not exactly a match, but its the
closest posix thing */
goto out;

2006-08-31 22:21:57

by David Miller

Subject: Re: [PATCH] rate limiting for socket allocation failure messages

From: Akinobu Mita <[email protected]>
Date: Thu, 31 Aug 2006 18:59:21 +0900

> (Resending due to local mail server trouble)
>
> This patch limits the warning messages when socket allocation
> failures happen. It happens under memory pressure.
>
> Cc: David Miller <[email protected]>
> Signed-off-by: Akinobu Mita <[email protected]>

Patch applied, thanks a lot.