2006-10-22 16:42:40

by Lu, Yinghai

[permalink] [raw]
Subject: [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS

Using cpu_online_map instead of APIC_ALL_CPUS for flat apic mode, So
__assign_irq_vector can refer correct per_cpu data.

Cc: Muli Ben-Yehuda <[email protected]>
Signed-off-by: Yinghai Lu <[email protected]>

Attachments:
(No filename) (207.00 B)
 vector_allocation_domain.diff (485.00 B)
 Download all attachments

2006-10-22 16:50:20

by Muli Ben-Yehuda

[permalink] [raw]
Subject: Re: [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS

On Sun, Oct 22, 2006 at 09:42:38AM -0700, Yinghai Lu wrote:
> Using cpu_online_map instead of APIC_ALL_CPUS for flat apic mode, So
> __assign_irq_vector can refer correct per_cpu data.
>
> Cc: Muli Ben-Yehuda <[email protected]>
> Signed-off-by: Yinghai Lu <[email protected]>

Acked-by: Muli Ben-Yehuda <[email protected]>

Cheers,
Muli

2006-10-22 17:57:32

by Eric W. Biederman

[permalink] [raw]
Subject: Re: [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS

"Yinghai Lu" <[email protected]> writes:

> Using cpu_online_map instead of APIC_ALL_CPUS for flat apic mode, So
> __assign_irq_vector can refer correct per_cpu data.
>
> Cc: Muli Ben-Yehuda <[email protected]>
> Signed-off-by: Yinghai Lu <[email protected]>

Nack. This fixes the symptom not the bug.
More comprehensive patches follow.

Eric

2006-10-22 19:59:00

by Lu, Yinghai

[permalink] [raw]
Subject: Re: [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS

Muli,

Can you test this one?

YH

On 10/22/06, Eric W. Biederman <[email protected]> wrote:
> "Yinghai Lu" <[email protected]> writes:
>
> > Using cpu_online_map instead of APIC_ALL_CPUS for flat apic mode, So
> > __assign_irq_vector can refer correct per_cpu data.
> >
> > Cc: Muli Ben-Yehuda <[email protected]>
> > Signed-off-by: Yinghai Lu <[email protected]>
>
> Nack. This fixes the symptom not the bug.
> More comprehensive patches follow.
>
> Eric
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

Attachments:
(No filename) (720.00 B)
 io_apic.diff (446.00 B)
 Download all attachments

2006-10-23 07:43:40

by Muli Ben-Yehuda

[permalink] [raw]
Subject: Re: [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS

On Sun, Oct 22, 2006 at 12:58:57PM -0700, Yinghai Lu wrote:

> Muli,
>
> Can you test this one?

I assume it was superceded by a later patch, please let me know if it
wasn't.

Cheers,
Muli

2006-10-23 08:06:00

by Yinghai Lu

[permalink] [raw]
Subject: Re: [PATCH] x86-64: using cpu_online_map instead of APIC_ALL_CPUS

Please test two patchs from eric.

YH

On 10/23/06, Muli Ben-Yehuda <[email protected]> wrote:
> On Sun, Oct 22, 2006 at 12:58:57PM -0700, Yinghai Lu wrote:
>
> > Muli,
> >
> > Can you test this one?
>
> I assume it was superceded by a later patch, please let me know if it
> wasn't.
>
> Cheers,
> Muli
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>