2007-01-08 13:30:39

by Christoph Hellwig

[permalink] [raw]
Subject: kallsyms_lookup export in -mm

This beast definitly shouldn't be exported. drivers/mtd/ubi/debug.c
should probably be just removed instead - it's an utter mess anyway.


2007-01-08 18:34:27

by Andrew Morton

[permalink] [raw]
Subject: Re: kallsyms_lookup export in -mm

On Mon, 8 Jan 2007 13:30:36 +0000
Christoph Hellwig <[email protected]> wrote:

> This beast definitly shouldn't be exported. drivers/mtd/ubi/debug.c
> should probably be just removed instead - it's an utter mess anyway.

I think that's happening. Partially, at least.

2007-01-08 18:54:17

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: kallsyms_lookup export in -mm

On Mon, 2007-01-08 at 10:34 -0800, Andrew Morton wrote:
> On Mon, 8 Jan 2007 13:30:36 +0000
> Christoph Hellwig <[email protected]> wrote:
>
> > This beast definitly shouldn't be exported. drivers/mtd/ubi/debug.c
> > should probably be just removed instead - it's an utter mess anyway.
>
> I think that's happening. Partially, at least.

I will remove kallsyms_lookup exporting, just wait a bit - I have HDD
crash :-(

About utter mess - I do not agree, but I would carefully listen to
arguments and of course would fix the mess.

--
Best regards,
Artem Bityutskiy (Битюцкий Артём)

2007-01-11 10:36:25

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: kallsyms_lookup export in -mm

On Mon, 2007-01-08 at 10:34 -0800, Andrew Morton wrote:
> On Mon, 8 Jan 2007 13:30:36 +0000
> Christoph Hellwig <[email protected]> wrote:
>
> > This beast definitly shouldn't be exported. drivers/mtd/ubi/debug.c
> > should probably be just removed instead - it's an utter mess anyway.
>
> I think that's happening. Partially, at least.

This is fixed now.

Andrew, I'll be at LCA, so I apologize for being not very responsive in
advance.

--
Best regards,
Artem Bityutskiy (Битюцкий Артём)