2007-05-04 19:17:07

by Sergei Shtylyov

[permalink] [raw]
Subject: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core
from checking them...

Signed-off-by: Sergei Shtylyov <[email protected]>

---
Michal, sorry for unintended breakage, please verify the patch... :-)

drivers/ide/pci/hpt366.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletion(-)

Index: linux-2.6/drivers/ide/pci/hpt366.c
===================================================================
--- linux-2.6.orig/drivers/ide/pci/hpt366.c
+++ linux-2.6/drivers/ide/pci/hpt366.c
@@ -1,5 +1,5 @@
/*
- * linux/drivers/ide/pci/hpt366.c Version 1.02 Apr 18, 2007
+ * linux/drivers/ide/pci/hpt366.c Version 1.03 May 4, 2007
*
* Copyright (C) 1999-2003 Andre Hedrick <[email protected]>
* Portions Copyright (C) 2001 Sun Microsystems, Inc.
@@ -1527,7 +1527,12 @@ static int __devinit init_setup_hpt366(s
if (rev > 2)
goto init_single;

+ /*
+ * HPT36x chips are single channel and
+ * do not seem to have the channel enable bit...
+ */
d->channels = 1;
+ d->enablebits[0].reg = 0;

if ((dev2 = pci_get_slot(dev->bus, dev->devfn + 1)) != NULL) {
u8 pin1 = 0, pin2 = 0;


Subject: Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

On Friday 04 May 2007, Sergei Shtylyov wrote:
> HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core
> from checking them...
>
> Signed-off-by: Sergei Shtylyov <[email protected]>

applied

2007-05-05 20:16:35

by Sergei Shtylyov

[permalink] [raw]
Subject: Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

Hello.

Bartlomiej Zolnierkiewicz wrote:

>>HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core
>>from checking them...

>>Signed-off-by: Sergei Shtylyov <[email protected]>

> applied

I'm getting "403 Forbidden" trying to browse this patch (and
ide-cs-recognize-2gb-compactflash-from-transcend.patch as well).

MBR, Sergei

Subject: Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

On Saturday 05 May 2007, Sergei Shtylyov wrote:
> Hello.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> >>HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core
> >>from checking them...
>
> >>Signed-off-by: Sergei Shtylyov <[email protected]>
>
> > applied
>
> I'm getting "403 Forbidden" trying to browse this patch (and
> ide-cs-recognize-2gb-compactflash-from-transcend.patch as well).

Should be fixed now - sorry for that.

While at it I replaced mine version of "the hpt366: simplify UltraDMA
filtering (take 2)" with the official one ;) and fixed my damn scripts
to always do "chmod 644 pata-2.6/patches/*.patch" before pushing updates
to kernel.org.

Bart

2007-05-06 22:53:54

by Andries E. Brouwer

[permalink] [raw]
Subject: Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

On Fri, May 04, 2007 at 11:18:37PM +0400, Sergei Shtylyov wrote:
> HPT36x chip don't seem to have the channel enable bits,
> so prevent the IDE core from checking them...
>
> Signed-off-by: Sergei Shtylyov <[email protected]>

Earlier this evening I reported that HPT366 was broken in 2.6.21.
I confirm that this fixes it for me.

Andries