2007-06-07 05:03:34

by Andrew Morton

[permalink] [raw]
Subject: 2.6.22-rc4-mm2


ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/

- Basically a bugfixed version of 2.6.22-rc4-mm1. None of the subsystem
trees were repulled, several bad patches were dropped, a few were fixed.


Boilerplate:

- See the `hot-fixes' directory for any important updates to this patchset.

- To fetch an -mm tree using git, use (for example)

git-fetch git://git.kernel.org/pub/scm/linux/kernel/git/smurf/linux-trees.git tag v2.6.16-rc2-mm1
git-checkout -b local-v2.6.16-rc2-mm1 v2.6.16-rc2-mm1

- -mm kernel commit activity can be reviewed by subscribing to the
mm-commits mailing list.

echo "subscribe mm-commits" | mail [email protected]

- If you hit a bug in -mm and it is not obvious which patch caused it, it is
most valuable if you can perform a bisection search to identify which patch
introduced the bug. Instructions for this process are at

http://www.zip.com.au/~akpm/linux/patches/stuff/bisecting-mm-trees.txt

But beware that this process takes some time (around ten rebuilds and
reboots), so consider reporting the bug first and if we cannot immediately
identify the faulty patch, then perform the bisection search.

- When reporting bugs, please try to Cc: the relevant maintainer and mailing
list on any email.

- When reporting bugs in this kernel via email, please also rewrite the
email Subject: in some manner to reflect the nature of the bug. Some
developers filter by Subject: when looking for messages to read.

- Occasional snapshots of the -mm lineup are uploaded to
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/ and are announced on
the mm-commits list.



Changes since 2.6.22-rc4-mm1:

git-acpi.patch
git-alsa.patch
git-arm-master.patch
git-arm.patch
git-avr32.patch
git-cifs.patch
git-cpufreq.patch
git-drm.patch
git-dvb.patch
git-gfs2-nmw.patch
git-hid.patch
git-ieee1394.patch
git-infiniband.patch
git-input.patch
git-kbuild.patch
git-kvm.patch
git-leds.patch
git-libata-all.patch
git-md-accel.patch
git-mips.patch
git-mmc.patch
git-ubi.patch
git-netdev-all.patch
git-net.patch
git-backlight.patch
git-battery.patch
git-ioat.patch
git-nfs.patch
git-nfs-server-cluster-locking-api.patch
git-ocfs2.patch
git-parisc.patch
git-r8169.patch
git-selinux.patch
git-s390.patch
git-sh.patch
git-scsi-misc.patch
git-scsi-rc-fixes.patch
git-scsi-target.patch
git-unionfs.patch
git-watchdog.patch
git-wireless.patch
git-ipwireless_cs.patch
git-newsetup.patch
git-xfs.patch
git-cryptodev.patch
git-xtensa.patch
git-gccbug.patch

git trees

+char-stallion-dont-fail-with-less-than-max-panels.patch
+char-stallion-alloc-tty-before-pci-devices-init.patch
+char-stallion-proper-fail-return-values.patch
+frv-build-fix.patch
+uml-get-declaration-of-simple_strtoul.patch
+isdn-diva-fix-section-mismatch.patch

2.6.22 queue

+git-acpi-disable-acpi_processor_throttling_seq_show.patch

Attempt to stop acpi oopsing

+toshica_acpi-fix-section-mismatch-in-allyesconfig.patch

section fix

+revert-gregkh-driver-block-device.patch

Revert dud patch from driver tree

+mac80211-fix-1-bit-bitfield-to-unsigned.patch

wireless sparse fix

+x86_64-acpi-disable-srat-when-numa-emulation-succeeds-fix.patch

Fix x86_64-acpi-disable-srat-when-numa-emulation-succeeds.patch

-mmconfig-validate-against-acpi-motherboard-resources.patch

Dropped due to compilation errors

+paravirt-helper-to-disable-all-io-space-fix-2.patch
+paravirt-helper-to-disable-all-io-space-fix-3.patch

Fix paravirt-helper-to-disable-all-io-space-fix.patch

+sata_promise-use-tf-interface-for-polling-nodata-commands.patch

SATA Promise fix

+serial-convert-early_uart-to-earlycon-for-8250-fix.patch

Fix serial-convert-early_uart-to-earlycon-for-8250.patch for ia64

-slub-use-ilog2-instead-of-series-of-constant-comparisons.patch

Dropped due to gcc-3.3.3 bustage

+mm-merge-nopfn-into-fault-spufs-fix.patch

Fix mm-merge-nopfn-into-fault.patch compile

+pm-introduce-hibernation-and-suspend-notifiers-fix-fix.patch

Fix pm-introduce-hibernation-and-suspend-notifiers.patch compile again

-define-new-percpu-interface-for-shared-data.patch
-use-the-new-percpu-interface-for-shared-data.patch

Dropped because it caused hangs in Michal's testing

+undeprecate-raw-driver.patch
+hfsplus-change-kmalloc-memset-to-kzalloc.patch
+submitchecklist-update-fix-spelling-error.patch
+fix-typo-in-prefetchh.patch

Misc fixes

+spi_mpc83xxc-underclocking-hotfix.patch

Fix an SPI driver

-sane-irq-initialization-in-sedlbauer-hisax.patch
+sane-irq-initialization-in-sedlbauer-hisax.patch

New, fixed version of this ISDN patch

+matroxfb-color-setting-fixes-fix.patch

fbdev fix

+schedstats-fix-printk-format.patch

printk fix

-arch-personality-independent-stack-top.patch
-audit-rework-execve-audit.patch
-audit-rework-execve-audit-fix.patch
-mm-move_page_tables_up.patch
-mm-variable-length-argument-support.patch
-mm-variable-length-argument-support-fix.patch

Dropped due to build problems and some BUG_ON() triggerings. Will be
updated.

+drivers-edac-new-intel-5000-mc-driver-fix.patch

Fix drivers-edac-new-intel-5000-mc-driver.patch

+containersv10-basic-container-framework-fix-2.patch

Fix boot-time hangs caused by
containersv10-basic-container-framework-fix.patch



All 1208 patches:

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/patch-list




2007-06-07 06:41:41

by William Lee Irwin III

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
> - Basically a bugfixed version of 2.6.22-rc4-mm1. None of the subsystem
> trees were repulled, several bad patches were dropped, a few were fixed.

create-the-zone_movable-zone.patch breaks the build on sparc32.


-- wli

$ good=0; bad=`quilt series -v | wc -l`; time while [[ $(( $bad - $good )) -gt 1 ]]; do cur=`quilt series -v |egrep -c '(=|\+)'`; chkpt=$(( ($good + $bad)/2 )); delta=$(( $chkpt - $cur )); if [[ $delta -lt 0 ]]; then (quilt pop $(( 0 - $delta )) ) >& /dev/null; elif [[ $delta -gt 0 ]]; then (quilt push $delta) >& /dev/null; else true; fi; cur=$chkpt; (yes "" | make ARCH=sparc CROSS_COMPILE="sparc-linux-" CC="gcc-sparc-4.1" quiet=1 -j16 defconfig) >& /dev/null; echo "last known good = $good, first known bad = $bad, trying $chkpt"; yes "" | make ARCH=sparc CROSS_COMPILE="sparc-linux-" CC="gcc-sparc-4.1" quiet=1 -j16 image modules; s=$?; if [[ $s -ne 0 ]]; then echo "$chkpt bad"; bad=$chkpt; else echo "$chkpt good"; good=$chkpt; fi; done
...
last known good = 641, first known bad = 645, trying 643
scripts/kconfig/conf -s arch/sparc/Kconfig
drivers/macintosh/Kconfig:116:warning: 'select' used by config symbol 'PMAC_APM_EMU' refers to undefined symbol 'APM_EMULATION'
drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
drivers/input/mouse/Kconfig:182:warning: 'select' used by config symbol 'MOUSE_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
sound/soc/sh/Kconfig:6:warning: 'select' used by config symbol 'SND_SOC_PCM_SH7760' refers to undefined symbol 'SH_DMABRG'
CHK include/linux/version.h
CHK include/linux/utsrelease.h
<stdin>:752:2: warning: #warning syscall setresuid not implemented
<stdin>:756:2: warning: #warning syscall getresuid not implemented
<stdin>:776:2: warning: #warning syscall setresgid not implemented
<stdin>:780:2: warning: #warning syscall getresgid not implemented
CHK include/linux/compile.h
mm/page_alloc.c: In function 'nr_free_pagecache_pages':
mm/page_alloc.c:1706: error: 'GFP_HIGH_MOVABLE' undeclared (first use in this function)
mm/page_alloc.c:1706: error: (Each undeclared identifier is reported only once
mm/page_alloc.c:1706: error: for each function it appears in.)
make[1]: *** [mm/page_alloc.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [mm] Error 2
make: *** Waiting for unfinished jobs....
drivers/char/rtc.c:118: warning: 'hpet_rtc_interrupt' defined but not used
make: *** wait: No child processes. Stop.

2007-06-07 06:51:50

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Wed, 6 Jun 2007 23:42:31 -0700 William Lee Irwin III <[email protected]> wrote:

> On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
> > - Basically a bugfixed version of 2.6.22-rc4-mm1. None of the subsystem
> > trees were repulled, several bad patches were dropped, a few were fixed.
>
> create-the-zone_movable-zone.patch breaks the build on sparc32.
>
>
> -- wli
>
> $ good=0; bad=`quilt series -v | wc -l`; time while [[ $(( $bad - $good )) -gt 1 ]]; do cur=`quilt series -v |egrep -c '(=|\+)'`; chkpt=$(( ($good + $bad)/2 )); delta=$(( $chkpt - $cur )); if [[ $delta -lt 0 ]]; then (quilt pop $(( 0 - $delta )) ) >& /dev/null; elif [[ $delta -gt 0 ]]; then (quilt push $delta) >& /dev/null; else true; fi; cur=$chkpt; (yes "" | make ARCH=sparc CROSS_COMPILE="sparc-linux-" CC="gcc-sparc-4.1" quiet=1 -j16 defconfig) >& /dev/null; echo "last known good = $good, first known bad = $bad, trying $chkpt"; yes "" | make ARCH=sparc CROSS_COMPILE="sparc-linux-" CC="gcc-sparc-4.1" quiet=1 -j16 image modules; s=$?; if [[ $s -ne 0 ]]; then echo "$chkpt bad"; bad=$chkpt; else echo "$chkpt good"; good=$chkpt; fi; done
> ...
> last known good = 641, first known bad = 645, trying 643
> scripts/kconfig/conf -s arch/sparc/Kconfig
> drivers/macintosh/Kconfig:116:warning: 'select' used by config symbol 'PMAC_APM_EMU' refers to undefined symbol 'APM_EMULATION'
> drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
> drivers/input/mouse/Kconfig:182:warning: 'select' used by config symbol 'MOUSE_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
> sound/soc/sh/Kconfig:6:warning: 'select' used by config symbol 'SND_SOC_PCM_SH7760' refers to undefined symbol 'SH_DMABRG'
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> <stdin>:752:2: warning: #warning syscall setresuid not implemented
> <stdin>:756:2: warning: #warning syscall getresuid not implemented
> <stdin>:776:2: warning: #warning syscall setresgid not implemented
> <stdin>:780:2: warning: #warning syscall getresgid not implemented
> CHK include/linux/compile.h
> mm/page_alloc.c: In function 'nr_free_pagecache_pages':
> mm/page_alloc.c:1706: error: 'GFP_HIGH_MOVABLE' undeclared (first use in this function)
> mm/page_alloc.c:1706: error: (Each undeclared identifier is reported only once
> mm/page_alloc.c:1706: error: for each function it appears in.)
> make[1]: *** [mm/page_alloc.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [mm] Error 2
> make: *** Waiting for unfinished jobs....
> drivers/char/rtc.c:118: warning: 'hpet_rtc_interrupt' defined but not used
> make: *** wait: No child processes. Stop.

Nope, there are no instances of GFP_HIGH_MOVABLE in the tree once all
patches are applied. You hit a bad bisection point: between
create-the-zone_movable-zone.patch and
create-the-zone_movable-zone-fix.patch.

2007-06-07 06:54:58

by William Lee Irwin III

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Wed, 6 Jun 2007 23:42:31 -0700 William Lee Irwin III <[email protected]> wrote:
>> create-the-zone_movable-zone.patch breaks the build on sparc32.

On Wed, Jun 06, 2007 at 11:51:31PM -0700, Andrew Morton wrote:
> Nope, there are no instances of GFP_HIGH_MOVABLE in the tree once all
> patches are applied. You hit a bad bisection point: between
> create-the-zone_movable-zone.patch and
> create-the-zone_movable-zone-fix.patch.

The fully-applied tree fails with a link error having to do with
movable_zone. I'm not entirely sure what arches are supposed to do
about that.


-- wli

2007-06-07 07:01:54

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Wed, 6 Jun 2007 23:55:44 -0700 William Lee Irwin III <[email protected]> wrote:

> On Wed, 6 Jun 2007 23:42:31 -0700 William Lee Irwin III <[email protected]> wrote:
> >> create-the-zone_movable-zone.patch breaks the build on sparc32.
>
> On Wed, Jun 06, 2007 at 11:51:31PM -0700, Andrew Morton wrote:
> > Nope, there are no instances of GFP_HIGH_MOVABLE in the tree once all
> > patches are applied. You hit a bad bisection point: between
> > create-the-zone_movable-zone.patch and
> > create-the-zone_movable-zone-fix.patch.
>
> The fully-applied tree fails with a link error having to do with
> movable_zone. I'm not entirely sure what arches are supposed to do
> about that.
>

config, please?

2007-06-07 07:03:14

by William Lee Irwin III

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Wed, 6 Jun 2007 23:55:44 -0700 William Lee Irwin III <[email protected]> wrote:
>> The fully-applied tree fails with a link error having to do with
>> movable_zone. I'm not entirely sure what arches are supposed to do
>> about that.

On Thu, Jun 07, 2007 at 12:01:25AM -0700, Andrew Morton wrote:
> config, please?

It's the sparc32 defconfig. Included below for completeness.


-- wli

#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.22-rc4-mm2
# Thu Jun 7 00:01:24 2007
#
CONFIG_MMU=y
CONFIG_HIGHMEM=y
CONFIG_ZONE_DMA=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"

#
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=32

#
# General setup
#
CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
# CONFIG_IPC_NS is not set
CONFIG_SYSVIPC_SYSCTL=y
CONFIG_POSIX_MQUEUE=y
# CONFIG_BSD_PROCESS_ACCT is not set
# CONFIG_TASKSTATS is not set
# CONFIG_UTS_NS is not set
# CONFIG_AUDIT is not set
# CONFIG_IKCONFIG is not set
CONFIG_LOG_BUF_SHIFT=14
CONFIG_SYSFS_DEPRECATED=y
# CONFIG_RELAY is not set
CONFIG_BLK_DEV_INITRD=y
CONFIG_INITRAMFS_SOURCE=""
# CONFIG_CC_OPTIMIZE_FOR_SIZE is not set
CONFIG_SYSCTL=y
# CONFIG_EMBEDDED is not set
CONFIG_UID16=y
CONFIG_SYSCTL_SYSCALL=y
CONFIG_KALLSYMS=y
# CONFIG_KALLSYMS_ALL is not set
# CONFIG_KALLSYMS_EXTRA_PASS is not set
CONFIG_HOTPLUG=y
CONFIG_PRINTK=y
CONFIG_BUG=y
CONFIG_ELF_CORE=y
CONFIG_BASE_FULL=y
CONFIG_FUTEX=y
CONFIG_ANON_INODES=y
CONFIG_EPOLL=y
CONFIG_SIGNALFD=y
CONFIG_TIMERFD=y
CONFIG_EVENTFD=y
CONFIG_SHMEM=y
CONFIG_VM_EVENT_COUNTERS=y
CONFIG_SLAB=y
# CONFIG_SLUB is not set
# CONFIG_SLOB is not set
CONFIG_RT_MUTEXES=y
# CONFIG_TINY_SHMEM is not set
CONFIG_BASE_SMALL=0

#
# Loadable module support
#
CONFIG_MODULES=y
CONFIG_MODULE_UNLOAD=y
# CONFIG_MODULE_FORCE_UNLOAD is not set
# CONFIG_MODVERSIONS is not set
# CONFIG_MODULE_SRCVERSION_ALL is not set
CONFIG_KMOD=y
CONFIG_BLOCK=y
# CONFIG_LBD is not set
# CONFIG_BLK_DEV_IO_TRACE is not set
# CONFIG_LSF is not set

#
# IO Schedulers
#
CONFIG_IOSCHED_NOOP=y
CONFIG_IOSCHED_AS=y
CONFIG_IOSCHED_DEADLINE=y
CONFIG_IOSCHED_CFQ=y
# CONFIG_DEFAULT_AS is not set
# CONFIG_DEFAULT_DEADLINE is not set
CONFIG_DEFAULT_CFQ=y
# CONFIG_DEFAULT_NOOP is not set
CONFIG_DEFAULT_IOSCHED="cfq"

#
# General machine setup
#
# CONFIG_SMP is not set
CONFIG_SPARC=y
CONFIG_SPARC32=y
CONFIG_SBUS=y
CONFIG_SBUSCHAR=y
CONFIG_SERIAL_CONSOLE=y
CONFIG_SUN_AUXIO=y
CONFIG_SUN_IO=y
CONFIG_RWSEM_GENERIC_SPINLOCK=y
CONFIG_GENERIC_FIND_NEXT_BIT=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
# CONFIG_ARCH_HAS_ILOG2_U32 is not set
# CONFIG_ARCH_HAS_ILOG2_U64 is not set
CONFIG_EMULATED_CMPXCHG=y
CONFIG_SUN_PM=y
# CONFIG_SUN4 is not set
CONFIG_PCI=y
# CONFIG_ARCH_SUPPORTS_MSI is not set
# CONFIG_PCI_DEBUG is not set
CONFIG_SUN_OPENPROMFS=m
# CONFIG_SPARC_LED is not set
CONFIG_BINFMT_ELF=y
CONFIG_BINFMT_AOUT=y
CONFIG_BINFMT_MISC=m
CONFIG_SUNOS_EMUL=y
CONFIG_SELECT_MEMORY_MODEL=y
CONFIG_FLATMEM_MANUAL=y
# CONFIG_DISCONTIGMEM_MANUAL is not set
# CONFIG_SPARSEMEM_MANUAL is not set
CONFIG_FLATMEM=y
CONFIG_FLAT_NODE_MEM_MAP=y
# CONFIG_SPARSEMEM_STATIC is not set
CONFIG_SPLIT_PTLOCK_CPUS=4
# CONFIG_RESOURCES_64BIT is not set
CONFIG_ZONE_DMA_FLAG=1

#
# Networking
#
CONFIG_NET=y

#
# Networking options
#
CONFIG_PACKET=y
# CONFIG_PACKET_MMAP is not set
CONFIG_UNIX=y
CONFIG_XFRM=y
CONFIG_XFRM_USER=m
# CONFIG_XFRM_SUB_POLICY is not set
# CONFIG_XFRM_MIGRATE is not set
CONFIG_NET_KEY=m
# CONFIG_NET_KEY_MIGRATE is not set
CONFIG_INET=y
# CONFIG_IP_MULTICAST is not set
# CONFIG_IP_ADVANCED_ROUTER is not set
CONFIG_IP_FIB_HASH=y
CONFIG_IP_PNP=y
CONFIG_IP_PNP_DHCP=y
# CONFIG_IP_PNP_BOOTP is not set
# CONFIG_IP_PNP_RARP is not set
# CONFIG_NET_IPIP is not set
# CONFIG_NET_IPGRE is not set
# CONFIG_ARPD is not set
# CONFIG_SYN_COOKIES is not set
CONFIG_INET_AH=y
CONFIG_INET_ESP=y
CONFIG_INET_IPCOMP=y
CONFIG_INET_XFRM_TUNNEL=y
CONFIG_INET_TUNNEL=y
CONFIG_INET_XFRM_MODE_TRANSPORT=y
CONFIG_INET_XFRM_MODE_TUNNEL=y
CONFIG_INET_XFRM_MODE_BEET=y
CONFIG_INET_DIAG=y
CONFIG_INET_TCP_DIAG=y
# CONFIG_TCP_CONG_ADVANCED is not set
CONFIG_TCP_CONG_CUBIC=y
CONFIG_DEFAULT_TCP_CONG="cubic"
# CONFIG_TCP_MD5SIG is not set
CONFIG_IPV6=m
CONFIG_IPV6_PRIVACY=y
# CONFIG_IPV6_ROUTER_PREF is not set
# CONFIG_IPV6_OPTIMISTIC_DAD is not set
CONFIG_INET6_AH=m
CONFIG_INET6_ESP=m
CONFIG_INET6_IPCOMP=m
# CONFIG_IPV6_MIP6 is not set
CONFIG_INET6_XFRM_TUNNEL=m
CONFIG_INET6_TUNNEL=m
CONFIG_INET6_XFRM_MODE_TRANSPORT=m
CONFIG_INET6_XFRM_MODE_TUNNEL=m
CONFIG_INET6_XFRM_MODE_BEET=m
# CONFIG_INET6_XFRM_MODE_ROUTEOPTIMIZATION is not set
CONFIG_IPV6_SIT=m
CONFIG_IPV6_TUNNEL=m
# CONFIG_IPV6_MULTIPLE_TABLES is not set
# CONFIG_NETWORK_SECMARK is not set
# CONFIG_NETFILTER is not set
# CONFIG_IP_DCCP is not set
CONFIG_IP_SCTP=m
# CONFIG_SCTP_DBG_MSG is not set
CONFIG_SCTP_DBG_OBJCNT=y
# CONFIG_SCTP_HMAC_NONE is not set
# CONFIG_SCTP_HMAC_SHA1 is not set
CONFIG_SCTP_HMAC_MD5=y
# CONFIG_TIPC is not set
# CONFIG_ATM is not set
# CONFIG_BRIDGE is not set
# CONFIG_VLAN_8021Q is not set
# CONFIG_DECNET is not set
# CONFIG_LLC2 is not set
# CONFIG_IPX is not set
# CONFIG_ATALK is not set
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
# CONFIG_ECONET is not set
# CONFIG_WAN_ROUTER is not set

#
# QoS and/or fair queueing
#
# CONFIG_NET_SCHED is not set

#
# Network testing
#
CONFIG_NET_PKTGEN=m
# CONFIG_HAMRADIO is not set
# CONFIG_IRDA is not set
# CONFIG_BT is not set
CONFIG_AF_RXRPC=m
# CONFIG_AF_RXRPC_DEBUG is not set
# CONFIG_RXKAD is not set

#
# Wireless
#
# CONFIG_CFG80211 is not set
# CONFIG_WIRELESS_EXT is not set
# CONFIG_MAC80211 is not set
# CONFIG_IEEE80211 is not set
# CONFIG_RFKILL is not set

#
# Device Drivers
#

#
# Generic Driver Options
#
CONFIG_STANDALONE=y
CONFIG_PREVENT_FIRMWARE_BUILD=y
# CONFIG_FW_LOADER is not set
# CONFIG_DEBUG_DRIVER is not set
# CONFIG_DEBUG_DEVRES is not set
# CONFIG_SYS_HYPERVISOR is not set

#
# Connector - unified userspace <-> kernelspace linker
#
# CONFIG_CONNECTOR is not set
# CONFIG_MTD is not set

#
# Parallel port support
#
# CONFIG_PARPORT is not set

#
# Plug and Play support
#
# CONFIG_PNPACPI is not set
CONFIG_BLK_DEV=y
# CONFIG_BLK_DEV_FD is not set
# CONFIG_BLK_CPQ_DA is not set
# CONFIG_BLK_CPQ_CISS_DA is not set
# CONFIG_BLK_DEV_DAC960 is not set
# CONFIG_BLK_DEV_UMEM is not set
# CONFIG_BLK_DEV_COW_COMMON is not set
CONFIG_BLK_DEV_LOOP=m
CONFIG_BLK_DEV_CRYPTOLOOP=m
# CONFIG_BLK_DEV_NBD is not set
# CONFIG_BLK_DEV_SX8 is not set
CONFIG_BLK_DEV_RAM=y
CONFIG_BLK_DEV_RAM_COUNT=16
CONFIG_BLK_DEV_RAM_SIZE=4096
CONFIG_BLK_DEV_RAM_BLOCKSIZE=1024
# CONFIG_CDROM_PKTCDVD is not set
# CONFIG_ATA_OVER_ETH is not set

#
# Misc devices
#
# CONFIG_PHANTOM is not set
# CONFIG_SGI_IOC4 is not set
# CONFIG_TIFM_CORE is not set
# CONFIG_BLINK is not set
# CONFIG_EEPROM_93CX6 is not set
# CONFIG_IDE is not set

#
# SCSI device support
#
# CONFIG_RAID_ATTRS is not set
CONFIG_SCSI=y
CONFIG_SCSI_DMA=y
# CONFIG_SCSI_TGT is not set
# CONFIG_SCSI_NETLINK is not set
CONFIG_SCSI_PROC_FS=y

#
# SCSI support type (disk, tape, CD-ROM)
#
CONFIG_BLK_DEV_SD=y
# CONFIG_CHR_DEV_ST is not set
# CONFIG_CHR_DEV_OSST is not set
CONFIG_BLK_DEV_SR=m
# CONFIG_BLK_DEV_SR_VENDOR is not set
CONFIG_CHR_DEV_SG=m
# CONFIG_CHR_DEV_SCH is not set

#
# Some SCSI devices (e.g. CD jukebox) support multiple LUNs
#
# CONFIG_SCSI_MULTI_LUN is not set
# CONFIG_SCSI_CONSTANTS is not set
# CONFIG_SCSI_LOGGING is not set
# CONFIG_SCSI_SCAN_ASYNC is not set
CONFIG_SCSI_WAIT_SCAN=m

#
# SCSI Transports
#
CONFIG_SCSI_SPI_ATTRS=y
# CONFIG_SCSI_FC_ATTRS is not set
# CONFIG_SCSI_ISCSI_ATTRS is not set
# CONFIG_SCSI_SAS_ATTRS is not set
# CONFIG_SCSI_SAS_LIBSAS is not set
CONFIG_SCSI_LOWLEVEL=y
# CONFIG_ISCSI_TCP is not set
# CONFIG_BLK_DEV_3W_XXXX_RAID is not set
# CONFIG_SCSI_3W_9XXX is not set
# CONFIG_SCSI_ACARD is not set
# CONFIG_SCSI_AACRAID is not set
# CONFIG_SCSI_AIC7XXX is not set
# CONFIG_SCSI_AIC7XXX_OLD is not set
# CONFIG_SCSI_AIC79XX is not set
# CONFIG_SCSI_AIC94XX is not set
# CONFIG_SCSI_DPT_I2O is not set
# CONFIG_SCSI_ARCMSR is not set
# CONFIG_MEGARAID_NEWGEN is not set
# CONFIG_MEGARAID_LEGACY is not set
# CONFIG_MEGARAID_SAS is not set
# CONFIG_SCSI_HPTIOP is not set
# CONFIG_SCSI_DMX3191D is not set
# CONFIG_SCSI_FUTURE_DOMAIN is not set
# CONFIG_SCSI_IPS is not set
# CONFIG_SCSI_INITIO is not set
# CONFIG_SCSI_INIA100 is not set
# CONFIG_SCSI_STEX is not set
# CONFIG_SCSI_SYM53C8XX_2 is not set
# CONFIG_SCSI_QLOGIC_1280 is not set
CONFIG_SCSI_QLOGICPTI=m
# CONFIG_SCSI_QLA_FC is not set
# CONFIG_SCSI_QLA_ISCSI is not set
# CONFIG_SCSI_LPFC is not set
# CONFIG_SCSI_DC395x is not set
# CONFIG_SCSI_DC390T is not set
# CONFIG_SCSI_NSP32 is not set
# CONFIG_SCSI_DEBUG is not set
CONFIG_SCSI_SUNESP=y
# CONFIG_SCSI_SRP is not set
# CONFIG_ATA is not set

#
# Multi-device support (RAID and LVM)
#
# CONFIG_MD is not set

#
# Fusion MPT device support
#
# CONFIG_FUSION is not set
# CONFIG_FUSION_SPI is not set
# CONFIG_FUSION_FC is not set
# CONFIG_FUSION_SAS is not set

#
# IEEE 1394 (FireWire) support
#
# CONFIG_FIREWIRE is not set
# CONFIG_IEEE1394 is not set

#
# I2O device support
#
# CONFIG_I2O is not set
CONFIG_NETDEVICES=y
CONFIG_DUMMY=m
# CONFIG_BONDING is not set
# CONFIG_EQUALIZER is not set
CONFIG_TUN=m
# CONFIG_ARCNET is not set
# CONFIG_PHYLIB is not set
CONFIG_NET_ETHERNET=y
CONFIG_MII=m
CONFIG_SUNLANCE=y
CONFIG_HAPPYMEAL=m
CONFIG_SUNBMAC=m
CONFIG_SUNQE=m
# CONFIG_SUNGEM is not set
# CONFIG_CASSINI is not set
# CONFIG_NET_VENDOR_3COM is not set
# CONFIG_NET_TULIP is not set
# CONFIG_HP100 is not set
# CONFIG_NET_PCI is not set
# CONFIG_B44 is not set
CONFIG_NETDEV_1000=y
# CONFIG_ACENIC is not set
# CONFIG_DL2K is not set
# CONFIG_E1000 is not set
# CONFIG_MYRI_SBUS is not set
# CONFIG_NS83820 is not set
# CONFIG_HAMACHI is not set
# CONFIG_YELLOWFIN is not set
# CONFIG_R8169 is not set
# CONFIG_SIS190 is not set
# CONFIG_SKGE is not set
# CONFIG_SKY2 is not set
# CONFIG_SK98LIN is not set
# CONFIG_VIA_VELOCITY is not set
# CONFIG_TIGON3 is not set
# CONFIG_BNX2 is not set
# CONFIG_QLA3XXX is not set
# CONFIG_ATL1 is not set
CONFIG_NETDEV_10000=y
# CONFIG_CHELSIO_T1 is not set
# CONFIG_CHELSIO_T3 is not set
# CONFIG_IXGB is not set
# CONFIG_S2IO is not set
# CONFIG_MYRI10GE is not set
# CONFIG_NETXEN_NIC is not set
# CONFIG_MLX4_CORE is not set
# CONFIG_TR is not set

#
# Wireless LAN
#
# CONFIG_WLAN_PRE80211 is not set
# CONFIG_WLAN_80211 is not set
# CONFIG_RTL818X is not set
# CONFIG_WAN is not set
# CONFIG_FDDI is not set
# CONFIG_HIPPI is not set
# CONFIG_PPP is not set
# CONFIG_SLIP is not set
# CONFIG_NET_FC is not set
# CONFIG_SHAPER is not set
# CONFIG_NETCONSOLE is not set
# CONFIG_NETPOLL is not set
# CONFIG_NET_POLL_CONTROLLER is not set

#
# ISDN subsystem
#
# CONFIG_ISDN is not set

#
# Telephony Support
#
# CONFIG_PHONE is not set

#
# Input device support
#
CONFIG_INPUT=y
# CONFIG_INPUT_FF_MEMLESS is not set

#
# Userland interfaces
#
CONFIG_INPUT_MOUSEDEV=y
CONFIG_INPUT_MOUSEDEV_PSAUX=y
CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024
CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768
CONFIG_INPUT_JOYDEV=m
# CONFIG_INPUT_TSDEV is not set
CONFIG_INPUT_EVDEV=m
CONFIG_INPUT_EVBUG=m

#
# Input Device Drivers
#
CONFIG_INPUT_KEYBOARD=y
CONFIG_KEYBOARD_ATKBD=m
CONFIG_KEYBOARD_SUNKBD=m
# CONFIG_KEYBOARD_LKKBD is not set
# CONFIG_KEYBOARD_XTKBD is not set
# CONFIG_KEYBOARD_NEWTON is not set
# CONFIG_KEYBOARD_STOWAWAY is not set
CONFIG_INPUT_MOUSE=y
CONFIG_MOUSE_PS2=m
CONFIG_MOUSE_PS2_ALPS=y
CONFIG_MOUSE_PS2_LOGIPS2PP=y
CONFIG_MOUSE_PS2_SYNAPTICS=y
CONFIG_MOUSE_PS2_LIFEBOOK=y
CONFIG_MOUSE_PS2_TRACKPOINT=y
# CONFIG_MOUSE_PS2_TOUCHKIT is not set
CONFIG_MOUSE_SERIAL=m
# CONFIG_MOUSE_APPLETOUCH is not set
# CONFIG_MOUSE_VSXXXAA is not set
# CONFIG_INPUT_JOYSTICK is not set
# CONFIG_INPUT_TABLET is not set
# CONFIG_INPUT_TOUCHSCREEN is not set
# CONFIG_INPUT_MISC is not set

#
# Hardware I/O ports
#
CONFIG_SERIO=m
# CONFIG_SERIO_I8042 is not set
CONFIG_SERIO_SERPORT=m
# CONFIG_SERIO_PCIPS2 is not set
CONFIG_SERIO_LIBPS2=m
# CONFIG_SERIO_RAW is not set
# CONFIG_GAMEPORT is not set

#
# Character devices
#
CONFIG_VT=y
CONFIG_VT_CONSOLE=y
CONFIG_HW_CONSOLE=y
# CONFIG_VT_HW_CONSOLE_BINDING is not set
# CONFIG_SERIAL_NONSTANDARD is not set
# CONFIG_NOZOMI is not set

#
# Serial drivers
#

#
# Non-8250 serial port support
#
CONFIG_SERIAL_SUNCORE=y
CONFIG_SERIAL_SUNZILOG=y
CONFIG_SERIAL_SUNZILOG_CONSOLE=y
CONFIG_SERIAL_SUNSU=y
CONFIG_SERIAL_SUNSU_CONSOLE=y
# CONFIG_SERIAL_SUNSAB is not set
CONFIG_SERIAL_CORE=y
CONFIG_SERIAL_CORE_CONSOLE=y
# CONFIG_SERIAL_JSM is not set
CONFIG_UNIX98_PTYS=y
CONFIG_LEGACY_PTYS=y
CONFIG_LEGACY_PTY_COUNT=256

#
# IPMI
#
# CONFIG_IPMI_HANDLER is not set
# CONFIG_WATCHDOG is not set
CONFIG_HW_RANDOM=m
CONFIG_RTC=m
# CONFIG_R3964 is not set
# CONFIG_APPLICOM is not set
# CONFIG_RAW_DRIVER is not set

#
# TPM devices
#
# CONFIG_TCG_TPM is not set
CONFIG_DEVPORT=y
# CONFIG_I2C is not set

#
# SPI support
#
# CONFIG_SPI is not set
# CONFIG_SPI_MASTER is not set

#
# Dallas's 1-wire bus
#
# CONFIG_W1 is not set
# CONFIG_POWER_SUPPLY is not set
CONFIG_HWMON=y
# CONFIG_HWMON_VID is not set
# CONFIG_SENSORS_ABITUGURU is not set
# CONFIG_SENSORS_F71805F is not set
# CONFIG_SENSORS_PC87360 is not set
# CONFIG_SENSORS_PC87427 is not set
# CONFIG_SENSORS_SIS5595 is not set
# CONFIG_SENSORS_SMSC47M1 is not set
# CONFIG_SENSORS_SMSC47B397 is not set
# CONFIG_SENSORS_VIA686A is not set
# CONFIG_SENSORS_VT1211 is not set
# CONFIG_SENSORS_W83627HF is not set
# CONFIG_HWMON_DEBUG_CHIP is not set

#
# Sonics Silicon Backplane
#
# CONFIG_SSB is not set

#
# Multifunction device drivers
#
# CONFIG_MFD_SM501 is not set

#
# Multimedia devices
#
# CONFIG_VIDEO_DEV is not set
# CONFIG_DVB_CORE is not set
# CONFIG_DAB is not set

#
# Graphics support
#
# CONFIG_BACKLIGHT_LCD_SUPPORT is not set

#
# Display device support
#
# CONFIG_DISPLAY_SUPPORT is not set
# CONFIG_VGASTATE is not set
CONFIG_VIDEO_OUTPUT_CONTROL=m
# CONFIG_FB is not set

#
# Console display driver support
#
# CONFIG_PROM_CONSOLE is not set
CONFIG_DUMMY_CONSOLE=y

#
# Sound
#
# CONFIG_SOUND is not set
CONFIG_HID_SUPPORT=y
CONFIG_HID=y
# CONFIG_HID_DEBUG is not set
# CONFIG_HIDRAW is not set
CONFIG_USB_SUPPORT=y
CONFIG_USB_ARCH_HAS_HCD=y
CONFIG_USB_ARCH_HAS_OHCI=y
CONFIG_USB_ARCH_HAS_EHCI=y
# CONFIG_USB is not set
# CONFIG_USB_EHCI_FSL is not set

#
# NOTE: USB_STORAGE enables SCSI, and 'SCSI disk support'
#

#
# USB Gadget Support
#
# CONFIG_USB_GADGET is not set
# CONFIG_MMC is not set
# CONFIG_NEW_LEDS is not set
# CONFIG_INFINIBAND is not set

#
# EDAC - error detection and reporting (RAS) (EXPERIMENTAL)
#

#
# Real Time Clock
#
# CONFIG_RTC_CLASS is not set

#
# DMA Engine support
#
# CONFIG_DMA_ENGINE is not set

#
# DMA Clients
#

#
# DMA Devices
#

#
# Userspace I/O
#
# CONFIG_UIO is not set

#
# Misc Linux/SPARC drivers
#
CONFIG_SUN_OPENPROMIO=m
CONFIG_SUN_MOSTEK_RTC=m
# CONFIG_SUN_BPP is not set
# CONFIG_SUN_VIDEOPIX is not set
# CONFIG_TADPOLE_TS102_UCTRL is not set
# CONFIG_SUN_JSFLASH is not set

#
# Unix98 PTY support
#
CONFIG_UNIX98_PTY_COUNT=256

#
# File systems
#
CONFIG_EXT2_FS=y
CONFIG_EXT2_FS_XATTR=y
CONFIG_EXT2_FS_POSIX_ACL=y
CONFIG_EXT2_FS_SECURITY=y
# CONFIG_EXT2_FS_XIP is not set
# CONFIG_EXT3_FS is not set
# CONFIG_EXT4DEV_FS is not set
CONFIG_FS_MBCACHE=y
# CONFIG_REISERFS_FS is not set
# CONFIG_JFS_FS is not set
CONFIG_FS_POSIX_ACL=y
CONFIG_XFS_FS=m
CONFIG_XFS_QUOTA=y
CONFIG_XFS_SECURITY=y
CONFIG_XFS_POSIX_ACL=y
CONFIG_XFS_RT=y
# CONFIG_GFS2_FS is not set
# CONFIG_OCFS2_FS is not set
CONFIG_ROMFS_FS=m
CONFIG_ROMFS_ON_BLOCK=y
CONFIG_INOTIFY=y
CONFIG_INOTIFY_USER=y
# CONFIG_QUOTA is not set
CONFIG_QUOTACTL=y
CONFIG_DNOTIFY=y
CONFIG_AUTOFS_FS=m
CONFIG_AUTOFS4_FS=m
# CONFIG_FUSE_FS is not set

#
# CD-ROM/DVD Filesystems
#
CONFIG_ISO9660_FS=m
# CONFIG_JOLIET is not set
# CONFIG_ZISOFS is not set
# CONFIG_UDF_FS is not set

#
# DOS/FAT/NT Filesystems
#
# CONFIG_MSDOS_FS is not set
# CONFIG_VFAT_FS is not set
# CONFIG_NTFS_FS is not set

#
# Pseudo filesystems
#
CONFIG_PROC_FS=y
CONFIG_PROC_KCORE=y
CONFIG_PROC_SYSCTL=y
CONFIG_SYSFS=y
# CONFIG_TMPFS is not set
# CONFIG_HUGETLB_PAGE is not set
CONFIG_RAMFS=y
# CONFIG_CONFIGFS_FS is not set

#
# Layered filesystems
#
# CONFIG_ECRYPT_FS is not set
# CONFIG_UNION_FS is not set

#
# Miscellaneous filesystems
#
# CONFIG_HFS_FS is not set
# CONFIG_HFSPLUS_FS is not set
CONFIG_BEFS_FS=m
# CONFIG_BEFS_DEBUG is not set
# CONFIG_BFS_FS is not set
# CONFIG_EFS_FS is not set
# CONFIG_CRAMFS is not set
# CONFIG_VXFS_FS is not set
# CONFIG_HPFS_FS is not set
# CONFIG_QNX4FS_FS is not set

#
# Network File Systems
#
CONFIG_NFS_FS=y
# CONFIG_NFS_V3 is not set
# CONFIG_NFS_V4 is not set
# CONFIG_NFS_DIRECTIO is not set
# CONFIG_NFSD is not set
CONFIG_ROOT_NFS=y
CONFIG_LOCKD=y
CONFIG_NFS_COMMON=y
CONFIG_SUNRPC=y
CONFIG_SUNRPC_GSS=m
# CONFIG_SUNRPC_BIND34 is not set
CONFIG_RPCSEC_GSS_KRB5=m
# CONFIG_RPCSEC_GSS_SPKM3 is not set
# CONFIG_SMB_FS is not set
CONFIG_CIFS=m
# CONFIG_CIFS_STATS is not set
# CONFIG_CIFS_WEAK_PW_HASH is not set
# CONFIG_CIFS_XATTR is not set
# CONFIG_CIFS_DEBUG2 is not set
# CONFIG_CIFS_EXPERIMENTAL is not set
# CONFIG_NCP_FS is not set
# CONFIG_CODA_FS is not set
CONFIG_AFS_FS=m
# CONFIG_AFS_DEBUG is not set
# CONFIG_9P_FS is not set

#
# Partition Types
#
# CONFIG_PARTITION_ADVANCED is not set
CONFIG_MSDOS_PARTITION=y
CONFIG_SUN_PARTITION=y

#
# Native Language Support
#
CONFIG_NLS=y
CONFIG_NLS_DEFAULT="iso8859-1"
# CONFIG_NLS_CODEPAGE_437 is not set
# CONFIG_NLS_CODEPAGE_737 is not set
# CONFIG_NLS_CODEPAGE_775 is not set
# CONFIG_NLS_CODEPAGE_850 is not set
# CONFIG_NLS_CODEPAGE_852 is not set
# CONFIG_NLS_CODEPAGE_855 is not set
# CONFIG_NLS_CODEPAGE_857 is not set
# CONFIG_NLS_CODEPAGE_860 is not set
# CONFIG_NLS_CODEPAGE_861 is not set
# CONFIG_NLS_CODEPAGE_862 is not set
# CONFIG_NLS_CODEPAGE_863 is not set
# CONFIG_NLS_CODEPAGE_864 is not set
# CONFIG_NLS_CODEPAGE_865 is not set
# CONFIG_NLS_CODEPAGE_866 is not set
# CONFIG_NLS_CODEPAGE_869 is not set
# CONFIG_NLS_CODEPAGE_936 is not set
# CONFIG_NLS_CODEPAGE_950 is not set
# CONFIG_NLS_CODEPAGE_932 is not set
# CONFIG_NLS_CODEPAGE_949 is not set
# CONFIG_NLS_CODEPAGE_874 is not set
# CONFIG_NLS_ISO8859_8 is not set
# CONFIG_NLS_CODEPAGE_1250 is not set
# CONFIG_NLS_CODEPAGE_1251 is not set
# CONFIG_NLS_ASCII is not set
# CONFIG_NLS_ISO8859_1 is not set
# CONFIG_NLS_ISO8859_2 is not set
# CONFIG_NLS_ISO8859_3 is not set
# CONFIG_NLS_ISO8859_4 is not set
# CONFIG_NLS_ISO8859_5 is not set
# CONFIG_NLS_ISO8859_6 is not set
# CONFIG_NLS_ISO8859_7 is not set
# CONFIG_NLS_ISO8859_9 is not set
# CONFIG_NLS_ISO8859_13 is not set
# CONFIG_NLS_ISO8859_14 is not set
# CONFIG_NLS_ISO8859_15 is not set
# CONFIG_NLS_KOI8_R is not set
# CONFIG_NLS_KOI8_U is not set
# CONFIG_NLS_UTF8 is not set

#
# Distributed Lock Manager
#
# CONFIG_DLM is not set

#
# Instrumentation Support
#
# CONFIG_PROFILING is not set

#
# Kernel hacking
#
# CONFIG_PRINTK_TIME is not set
CONFIG_ENABLE_MUST_CHECK=y
CONFIG_MAGIC_SYSRQ=y
# CONFIG_UNUSED_SYMBOLS is not set
# CONFIG_DEBUG_FS is not set
# CONFIG_HEADERS_CHECK is not set
CONFIG_DEBUG_KERNEL=y
CONFIG_DETECT_SOFTLOCKUP=y
# CONFIG_SCHEDSTATS is not set
# CONFIG_TIMER_STATS is not set
# CONFIG_DEBUG_SLAB is not set
# CONFIG_DEBUG_RT_MUTEXES is not set
# CONFIG_RT_MUTEX_TESTER is not set
# CONFIG_DEBUG_SPINLOCK is not set
# CONFIG_DEBUG_MUTEXES is not set
# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
# CONFIG_DEBUG_LOCKING_API_SELFTESTS is not set
# CONFIG_DEBUG_KOBJECT is not set
# CONFIG_DEBUG_HIGHMEM is not set
CONFIG_DEBUG_BUGVERBOSE=y
# CONFIG_DEBUG_INFO is not set
# CONFIG_DEBUG_VM is not set
# CONFIG_DEBUG_LIST is not set
# CONFIG_UNWIND_INFO is not set
CONFIG_FORCED_INLINING=y
# CONFIG_RCU_TORTURE_TEST is not set
# CONFIG_FAULT_INJECTION is not set
# CONFIG_DEBUG_STACK_USAGE is not set

#
# Security options
#
CONFIG_KEYS=y
# CONFIG_KEYS_DEBUG_PROC_KEYS is not set
# CONFIG_SECURITY is not set
CONFIG_CRYPTO=y
CONFIG_CRYPTO_ALGAPI=y
CONFIG_CRYPTO_BLKCIPHER=y
CONFIG_CRYPTO_HASH=y
CONFIG_CRYPTO_MANAGER=y
CONFIG_CRYPTO_HMAC=y
# CONFIG_CRYPTO_XCBC is not set
CONFIG_CRYPTO_NULL=m
CONFIG_CRYPTO_MD4=y
CONFIG_CRYPTO_MD5=y
CONFIG_CRYPTO_SHA1=y
CONFIG_CRYPTO_SHA256=m
CONFIG_CRYPTO_SHA512=m
# CONFIG_CRYPTO_WP512 is not set
# CONFIG_CRYPTO_TGR192 is not set
# CONFIG_CRYPTO_GF128MUL is not set
CONFIG_CRYPTO_ECB=m
CONFIG_CRYPTO_CBC=y
CONFIG_CRYPTO_PCBC=m
# CONFIG_CRYPTO_LRW is not set
# CONFIG_CRYPTO_CRYPTD is not set
CONFIG_CRYPTO_DES=y
# CONFIG_CRYPTO_FCRYPT is not set
CONFIG_CRYPTO_BLOWFISH=m
CONFIG_CRYPTO_TWOFISH=m
CONFIG_CRYPTO_TWOFISH_COMMON=m
CONFIG_CRYPTO_SERPENT=m
CONFIG_CRYPTO_AES=m
CONFIG_CRYPTO_CAST5=m
CONFIG_CRYPTO_CAST6=m
# CONFIG_CRYPTO_TEA is not set
CONFIG_CRYPTO_ARC4=m
# CONFIG_CRYPTO_KHAZAD is not set
# CONFIG_CRYPTO_ANUBIS is not set
CONFIG_CRYPTO_DEFLATE=y
CONFIG_CRYPTO_MICHAEL_MIC=m
CONFIG_CRYPTO_CRC32C=m
# CONFIG_CRYPTO_CAMELLIA is not set
# CONFIG_CRYPTO_TEST is not set

#
# Hardware crypto devices
#

#
# Library routines
#
CONFIG_BITREVERSE=y
# CONFIG_CRC_CCITT is not set
# CONFIG_CRC16 is not set
# CONFIG_CRC_ITU_T is not set
CONFIG_CRC32=y
CONFIG_LIBCRC32C=m
CONFIG_ZLIB_INFLATE=y
CONFIG_ZLIB_DEFLATE=y
CONFIG_PLIST=y
CONFIG_HAS_IOMEM=y
CONFIG_HAS_IOPORT=y
CONFIG_HAS_DMA=y

2007-06-07 07:04:30

by William Lee Irwin III

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Thu, Jun 07, 2007 at 12:01:25AM -0700, Andrew Morton wrote:
>> config, please?

On Thu, Jun 07, 2007 at 12:04:07AM -0700, William Lee Irwin III wrote:
> It's the sparc32 defconfig. Included below for completeness.

The error output looks like the following.


-- wli

$ quilt top create-the-zone_movable-zone-fix.patch $ (yes "" | make ARCH=sparc CROSS_COMPILE="sparc-linux-" CC="gcc-sparc-4.1" quiet=1 -j16 defconfig) >& /dev/null; yes "" | make ARCH=sparc CROSS_COMPILE="sparc-linux-" CC="gcc-sparc-4.1" quiet=1 -j16 image modules scripts/kconfig/conf -s arch/sparc/Kconfig
drivers/macintosh/Kconfig:116:warning: 'select' used by config symbol 'PMAC_APM_EMU' refers to undefined symbol 'APM_EMULATION'
drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
drivers/input/mouse/Kconfig:182:warning: 'select' used by config symbol 'MOUSE_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'
sound/soc/sh/Kconfig:6:warning: 'select' used by config symbol 'SND_SOC_PCM_SH7760' refers to undefined symbol 'SH_DMABRG'
CHK include/linux/version.h
UPD include/linux/version.h
CHK include/linux/utsrelease.h
UPD include/linux/utsrelease.h
SYMLINK include/asm -> include/asm-sparc
<stdin>:752:2: warning: #warning syscall setresuid not implemented
<stdin>:756:2: warning: #warning syscall getresuid not implemented
<stdin>:776:2: warning: #warning syscall setresgid not implemented
<stdin>:780:2: warning: #warning syscall getresgid not implemented
CHK include/linux/compile.h
UPD include/linux/compile.h
ipc/msg.c: In function 'sys_msgctl':
ipc/msg.c:390: warning: 'setbuf.qbytes' may be used uninitialized in this function
ipc/msg.c:390: warning: 'setbuf.uid' may be used uninitialized in this function
ipc/msg.c:390: warning: 'setbuf.gid' may be used uninitialized in this function
ipc/msg.c:390: warning: 'setbuf.mode' may be used uninitialized in this function
ipc/sem.c: In function 'sys_semctl':
ipc/sem.c:861: warning: 'setbuf.uid' may be used uninitialized in this function
ipc/sem.c:861: warning: 'setbuf.gid' may be used uninitialized in this function
ipc/sem.c:861: warning: 'setbuf.mode' may be used uninitialized in this function
mm/vmalloc.c: In function 'unmap_kernel_range':
mm/vmalloc.c:75: warning: unused variable 'start'
drivers/char/rtc.c:118: warning: 'hpet_rtc_interrupt' defined but not used
kernel/time/ntp.c: In function 'do_adjtimex':
kernel/time/ntp.c:309: warning: comparison of distinct pointer types lacks a cast
kernel/time/ntp.c:312: warning: comparison of distinct pointer types lacks a cast
drivers/pci/search.c: In function 'pci_find_slot':
drivers/pci/search.c:99: warning: 'pci_find_device' is deprecated (declared at include/linux/pci.h:478)
drivers/pci/search.c: At top level:
drivers/pci/search.c:434: warning: 'pci_find_device' is deprecated (declared at drivers/pci/search.c:241)
drivers/pci/search.c:434: warning: 'pci_find_device' is deprecated (declared at drivers/pci/search.c:241)
drivers/pci/search.c:435: warning: 'pci_find_slot' is deprecated (declared at drivers/pci/search.c:96)
drivers/pci/search.c:435: warning: 'pci_find_slot' is deprecated (declared at drivers/pci/search.c:96)
drivers/pci/syscall.c: In function 'sys_pciconfig_read':
drivers/pci/syscall.c:22: warning: 'dev' may be used uninitialized in this function
fs/partitions/check.c: In function 'add_partition':
fs/partitions/check.c:392: warning: ignoring return value of 'kobject_add', declared with attribute warn_unused_result
fs/partitions/check.c:395: warning: ignoring return value of 'sysfs_create_link', declared with attribute warn_unused_result
fs/partitions/check.c:402: warning: ignoring return value of 'sysfs_create_file', declared with attribute warn_unused_result
CHK include/linux/compile.h
UPD include/linux/compile.h
WARNING: arch/sparc/kernel/head.o(.text+0x9040): Section mismatch: reference to .init.text:no_sun4u_here (between 'current_pc' and 'already_mapped')
WARNING: arch/sparc/kernel/head.o(.text+0x9280): Section mismatch: reference to .init.text:execute_in_high_mem (after 'go_to_highmem')
WARNING: arch/sparc/kernel/head.o(.text+0x9284): Section mismatch: reference to .init.text:execute_in_high_mem (after 'go_to_highmem')
Building modules, stage 2.
WARNING: vmlinux(.text+0x9040): Section mismatch: reference to .init.text:no_sun4u_here (between 'current_pc' and 'already_mapped')
WARNING: vmlinux(.text+0x9280): Section mismatch: reference to .init.text:execute_in_high_mem (between 'go_to_highmem' and 'init_thread_union')
WARNING: vmlinux(.text+0x9284): Section mismatch: reference to .init.text:execute_in_high_mem (between 'go_to_highmem' and 'init_thread_union')
WARNING: vmlinux(.text+0x1dfb38): Section mismatch: reference to .init.text:kernel_init (between 'rest_init' and 'alloc_node_mem_map')
WARNING: vmlinux(.text+0x1dfb40): Section mismatch: reference to .init.text:kernel_init (between 'rest_init' and 'alloc_node_mem_map')
WARNING: vmlinux(.text+0x1dfbf8): Section mismatch: reference to .init.text:__alloc_bootmem_node (between 'alloc_node_mem_map' and 'zone_wait_table_init')
WARNING: vmlinux(.text+0x1dfcfc): Section mismatch: reference to .init.text:__alloc_bootmem_node (between 'zone_wait_table_init' and 'setup_cpu_cache')
WARNING: vmlinux(.text+0x1dfe20): Section mismatch: reference to .init.text:set_up_list3s (between 'setup_cpu_cache' and '__down')
WARNING: vmlinux(.text+0x1dfe94): Section mismatch: reference to .init.text:set_up_list3s (between 'setup_cpu_cache' and '__down')
ERROR: "movable_zone" [fs/romfs/romfs.ko] undefined!
ERROR: "movable_zone" [fs/isofs/isofs.ko] undefined!
ERROR: "movable_zone" [fs/cifs/cifs.ko] undefined!
ERROR: "movable_zone" [fs/afs/kafs.ko] undefined!
ERROR: "movable_zone" [drivers/block/loop.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
make: *** Waiting for unfinished jobs....
arch/sparc/mm/built-in.o: In function `kmap_atomic':
(.text+0x433c): undefined reference to `movable_zone'
arch/sparc/mm/built-in.o: In function `kmap_atomic':
(.text+0x4348): undefined reference to `movable_zone'
mm/built-in.o: In function `iov_iter_copy_from_user':
(.text+0x770): undefined reference to `movable_zone'
mm/built-in.o: In function `iov_iter_copy_from_user':
(.text+0x844): undefined reference to `movable_zone'
mm/built-in.o: In function `iov_iter_copy_from_user':
(.text+0x850): undefined reference to `movable_zone'
mm/built-in.o:(.text+0x870): more undefined references to `movable_zone' follow
make[1]: *** [arch/sparc/boot/image] Error 1
make: *** [image] Error 2

2007-06-07 07:13:05

by Paul Mundt

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Wed, Jun 06, 2007 at 11:42:31PM -0700, William Lee Irwin III wrote:
> sound/soc/sh/Kconfig:6:warning: 'select' used by config symbol 'SND_SOC_PCM_SH7760' refers to undefined symbol 'SH_DMABRG'

Manuel, can you take a look at this and fix up the select behaviour? Perhaps
sound/soc/sh/Kconfig should just have a CONFIG_SUPERH around it.

2007-06-07 07:19:45

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Thu, 7 Jun 2007 00:05:13 -0700 William Lee Irwin III <[email protected]> wrote:

> On Thu, Jun 07, 2007 at 12:01:25AM -0700, Andrew Morton wrote:
> >> config, please?
>
> On Thu, Jun 07, 2007 at 12:04:07AM -0700, William Lee Irwin III wrote:
> > It's the sparc32 defconfig. Included below for completeness.
>
> The error output looks like the following.
>
>
> ERROR: "movable_zone" [fs/romfs/romfs.ko] undefined!
> ERROR: "movable_zone" [fs/isofs/isofs.ko] undefined!
> ERROR: "movable_zone" [fs/cifs/cifs.ko] undefined!
> ERROR: "movable_zone" [fs/afs/kafs.ko] undefined!
> ERROR: "movable_zone" [drivers/block/loop.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> make: *** Waiting for unfinished jobs....
> arch/sparc/mm/built-in.o: In function `kmap_atomic':
> (.text+0x433c): undefined reference to `movable_zone'
> arch/sparc/mm/built-in.o: In function `kmap_atomic':
> (.text+0x4348): undefined reference to `movable_zone'
> mm/built-in.o: In function `iov_iter_copy_from_user':
> (.text+0x770): undefined reference to `movable_zone'
> mm/built-in.o: In function `iov_iter_copy_from_user':
> (.text+0x844): undefined reference to `movable_zone'
> mm/built-in.o: In function `iov_iter_copy_from_user':
> (.text+0x850): undefined reference to `movable_zone'
> mm/built-in.o:(.text+0x870): more undefined references to `movable_zone' follow
> make[1]: *** [arch/sparc/boot/image] Error 1

hm, OK, this seems to work:

--- a/include/linux/mmzone.h~a
+++ a/include/linux/mmzone.h
@@ -541,10 +541,13 @@ static inline int populated_zone(struct
return (!!zone->present_pages);
}

+#ifdef CONFIG_ARCH_POPULATES_NODE_MAP
extern int movable_zone;
+#endif
+
static inline int zone_movable_is_highmem(void)
{
-#ifdef CONFIG_HIGHMEM
+#if defined(CONFIG_HIGHMEM) && defined(CONFIG_ARCH_POPULATES_NODE_MAP)
return movable_zone == ZONE_HIGHMEM;
#else
return 0;
_

(the first ifdef is just there to trip things at compile time rather than
link time)

2007-06-07 07:33:11

by William Lee Irwin III

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Thu, Jun 07, 2007 at 12:19:22AM -0700, Andrew Morton wrote:
> hm, OK, this seems to work:
[...]
> -#ifdef CONFIG_HIGHMEM
> +#if defined(CONFIG_HIGHMEM) && defined(CONFIG_ARCH_POPULATES_NODE_MAP)
> return movable_zone == ZONE_HIGHMEM;
> #else
> return 0;
> _
> (the first ifdef is just there to trip things at compile time rather than
> link time)

I guess it's not the arch's fault after all. I probably would've
conditionally out-of-lined the thing so as never to expose movable_zone
but this will do just fine.


-- wli

2007-06-07 09:26:32

by Manuel Lauss

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Thu, Jun 07, 2007 at 04:11:38PM +0900, Paul Mundt wrote:
> On Wed, Jun 06, 2007 at 11:42:31PM -0700, William Lee Irwin III wrote:
> > sound/soc/sh/Kconfig:6:warning: 'select' used by config symbol 'SND_SOC_PCM_SH7760' refers to undefined symbol 'SH_DMABRG'

---

Make SND_SOC_PCM_SH7760 depend on SH_DMABRG rather than selecting it

Fixes Kconfig warning about undefined SH_DMABRG symbol on non-sh builds.


Signed-off-by: Manuel Lauss <[email protected]>


--- linux-2.6.22-rc4-mm2/sound/soc/sh/Kconfig~ 2007-06-07 11:09:30.000000000 +0200
+++ linux-2.6.22-rc4-mm2/sound/soc/sh/Kconfig 2007-06-07 11:09:30.000000000 +0200
@@ -2,8 +2,7 @@ menu "SoC Audio support for SuperH"

config SND_SOC_PCM_SH7760
tristate "SoC Audio support for Renesas SH7760"
- depends on CPU_SUBTYPE_SH7760 && SND_SOC
- select SH_DMABRG
+ depends on CPU_SUBTYPE_SH7760 && SND_SOC && SH_DMABRG
help
Enable this option for SH7760 AC97/I2S audio support.

2007-06-07 09:38:23

by Paul Mundt

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Thu, Jun 07, 2007 at 11:19:42AM +0200, Manuel Lauss wrote:
> On Thu, Jun 07, 2007 at 04:11:38PM +0900, Paul Mundt wrote:
> > On Wed, Jun 06, 2007 at 11:42:31PM -0700, William Lee Irwin III wrote:
> > > sound/soc/sh/Kconfig:6:warning: 'select' used by config symbol 'SND_SOC_PCM_SH7760' refers to undefined symbol 'SH_DMABRG'
>
> ---
>
> Make SND_SOC_PCM_SH7760 depend on SH_DMABRG rather than selecting it
>
> Fixes Kconfig warning about undefined SH_DMABRG symbol on non-sh builds.
>
Are you sure this is the way you want to go? The select here is
reasonably useful.

2007-06-07 09:46:43

by Manuel Lauss

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Thu, Jun 07, 2007 at 06:37:02PM +0900, Paul Mundt wrote:
> On Thu, Jun 07, 2007 at 11:19:42AM +0200, Manuel Lauss wrote:
> > On Thu, Jun 07, 2007 at 04:11:38PM +0900, Paul Mundt wrote:
> > > On Wed, Jun 06, 2007 at 11:42:31PM -0700, William Lee Irwin III wrote:
> > > > sound/soc/sh/Kconfig:6:warning: 'select' used by config symbol 'SND_SOC_PCM_SH7760' refers to undefined symbol 'SH_DMABRG'
> >
> > ---
> >
> > Make SND_SOC_PCM_SH7760 depend on SH_DMABRG rather than selecting it
> >
> > Fixes Kconfig warning about undefined SH_DMABRG symbol on non-sh builds.
> >
> Are you sure this is the way you want to go? The select here is
> reasonably useful.

I hope the other people using this code are smart enough to set SH_DMABRG in
their board's defconfig. (I seem to remember there was an argument about
the evilness of select; and as far as I know I am the only user of this
code anyway)

If you think select is more useful then I'll send another patch to the
alsa folks.

Thanks,
Manuel Lauss

2007-06-07 11:08:23

by Michal Piotrowski

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

Andrew Morton pisze:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
>

LTP triggered this

[ 4691.872882] ------------[ cut here ]------------
[ 4691.877619] kernel BUG at fs/buffer.c:1821!
[ 4691.881857] invalid opcode: 0000 [#1]
[ 4691.885596] PREEMPT SMP
[ 4691.888205] Modules linked in: isofs nls_base zlib_inflate autofs4 sunrpc af_packet nf_conntrack_netbios_ns nf_conntrack_ipv4 xt_state nf_conntrack nfnetlink ipt_REJECT iptable_filter ip_tables xt_tcpudp ip6t_REJECT ip6table_filter ip6_tables x_tables firmware_class binfmt_misc thermal processor fan container ipv6 nvram loop snd_intel8x0 snd_ac97_codec ac97_bus snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss snd_mixer_oss snd_pcm snd_timer i2c_i801 snd soundcore intel_agp snd_page_alloc agpgart evdev rtc
[ 4691.937384] CPU: 1
[ 4691.937385] EIP: 0060:[<c04a510f>] Not tainted VLI
[ 4691.937387] EFLAGS: 00010202 (2.6.22-rc4-mm2 #1)
[ 4691.949984] EIP is at __block_prepare_write+0x64/0x3a5
[ 4691.955164] eax: 00000001 ebx: c624fc50 ecx: c07e0910 edx: 00000001
[ 4691.962041] esi: 00000418 edi: 00000000 ebp: cc454dc0 esp: cc454d60
[ 4691.968946] ds: 007b es: 007b fs: 00d8 gs: 0033 ss: 0068
[ 4691.974850] Process vmsplice01 (pid: 8420, ti=cc454000 task=cafe6800 task.ti=cc454000)
[ 4691.982699] Stack: cc454d80 c0443c61 00000001 00000001 c7f71080 00000418 c624fc50 c98ec464
[ 4691.991372] 00000000 00000286 c04d6706 c523d7c8 00000050 c04d6706 c7f71080 c828d7f0
[ 4691.999998] c7f71094 cc454dd4 c04d673f c065cfbc c624fc50 c624fc50 00000418 00000000
[ 4692.008729] Call Trace:
[ 4692.011397] [<c04a5513>] block_write_begin+0x90/0xf4
[ 4692.016556] [<c04c9779>] ext3_write_begin+0xda/0x19b
[ 4692.021750] [<c0464b5a>] pagecache_write_begin+0x4d/0x12f
[ 4692.027349] [<c04a1a35>] pipe_to_file+0xa0/0x15f
[ 4692.032148] [<c04a14af>] __splice_from_pipe+0x63/0x1d2
[ 4692.037459] [<c04a1660>] splice_from_pipe+0x42/0x58
[ 4692.042544] [<c04a1916>] generic_file_splice_write+0x8b/0x10a
[ 4692.048477] [<c04a1409>] do_splice_from+0xca/0xd6
[ 4692.053391] [<c04a2754>] sys_splice+0x108/0x22b
[ 4692.058119] [<c040420c>] syscall_call+0x7/0xb
[ 4692.062691] [<b7f53410>] 0xb7f53410
[ 4692.066398] =======================
[ 4692.070031] INFO: lockdep is turned off.
[ 4692.074038] Code: 2c 09 7e c0 e8 2f 6e 07 00 85 c0 74 04 0f 0b eb fe 31 d2 81 7d 08 00 10 00 00 0f 97 c2 b8 10 09 7e c0 e8 11 6e 07 00 85 c0 74 04 <0f> 0b eb fe 8b 55 08 39 55 b4 0f 97 c2 0f b6 d2 b8 f4 08 7e c0
[ 4692.094556] EIP: [<c04a510f>] __block_prepare_write+0x64/0x3a5 SS:ESP 0068:cc454d60

(gdb) l *__block_prepare_write+0x64
0xc10a510f is in __block_prepare_write (fs/buffer.c:1821).
1816 unsigned blocksize, bbits;
1817 struct buffer_head *bh, *head, *wait[2], **wait_bh=wait;
1818
1819 BUG_ON(!PageLocked(page));
1820 BUG_ON(from > PAGE_CACHE_SIZE);
1821 BUG_ON(to > PAGE_CACHE_SIZE);
1822 BUG_ON(from > to);
1823
1824 blocksize = 1 << inode->i_blkbits;
1825 if (!page_has_buffers(page))

http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/2.6.22-rc4-mm2/console.log
http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/2.6.22-rc4-mm2/mm-config

Regards,
Michal

--
"Najbardziej brakowało mi twojego milczenia."
-- Andrzej Sapkowski "Coś więcej"

2007-06-07 14:29:30

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Wed, 06 Jun 2007 22:03:13 PDT, Andrew Morton said:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
>
> - Basically a bugfixed version of 2.6.22-rc4-mm1. None of the subsystem
> trees were repulled, several bad patches were dropped, a few were fixed.

Ahh.. much better. 'lvm vgscan' worked, it booted, been up for an hour-ish
without any oops, bug, or warning. Dell Latitude D820 laptop, T7200 dual-core,
x86_64 kernel....


Attachments:
(No filename) (226.00 B)

2007-06-07 15:27:00

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Thu, 07 Jun 2007 13:07:59 +0200 Michal Piotrowski <[email protected]> wrote:

> Andrew Morton pisze:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
> >
>
> LTP triggered this
>
> [ 4691.872882] ------------[ cut here ]------------
> [ 4691.877619] kernel BUG at fs/buffer.c:1821!
> [ 4691.881857] invalid opcode: 0000 [#1]
> [ 4691.885596] PREEMPT SMP
> [ 4691.888205] Modules linked in: isofs nls_base zlib_inflate autofs4 sunrpc af_packet nf_conntrack_netbios_ns nf_conntrack_ipv4 xt_state nf_conntrack nfnetlink ipt_REJECT iptable_filter ip_tables xt_tcpudp ip6t_REJECT ip6table_filter ip6_tables x_tables firmware_class binfmt_misc thermal processor fan container ipv6 nvram loop snd_intel8x0 snd_ac97_codec ac97_bus snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss snd_mixer_oss snd_pcm snd_timer i2c_i801 snd soundcore intel_agp snd_page_alloc agpgart evdev rtc
> [ 4691.937384] CPU: 1
> [ 4691.937385] EIP: 0060:[<c04a510f>] Not tainted VLI
> [ 4691.937387] EFLAGS: 00010202 (2.6.22-rc4-mm2 #1)
> [ 4691.949984] EIP is at __block_prepare_write+0x64/0x3a5
> [ 4691.955164] eax: 00000001 ebx: c624fc50 ecx: c07e0910 edx: 00000001
> [ 4691.962041] esi: 00000418 edi: 00000000 ebp: cc454dc0 esp: cc454d60
> [ 4691.968946] ds: 007b es: 007b fs: 00d8 gs: 0033 ss: 0068
> [ 4691.974850] Process vmsplice01 (pid: 8420, ti=cc454000 task=cafe6800 task.ti=cc454000)
> [ 4691.982699] Stack: cc454d80 c0443c61 00000001 00000001 c7f71080 00000418 c624fc50 c98ec464
> [ 4691.991372] 00000000 00000286 c04d6706 c523d7c8 00000050 c04d6706 c7f71080 c828d7f0
> [ 4691.999998] c7f71094 cc454dd4 c04d673f c065cfbc c624fc50 c624fc50 00000418 00000000
> [ 4692.008729] Call Trace:
> [ 4692.011397] [<c04a5513>] block_write_begin+0x90/0xf4
> [ 4692.016556] [<c04c9779>] ext3_write_begin+0xda/0x19b
> [ 4692.021750] [<c0464b5a>] pagecache_write_begin+0x4d/0x12f
> [ 4692.027349] [<c04a1a35>] pipe_to_file+0xa0/0x15f
> [ 4692.032148] [<c04a14af>] __splice_from_pipe+0x63/0x1d2
> [ 4692.037459] [<c04a1660>] splice_from_pipe+0x42/0x58
> [ 4692.042544] [<c04a1916>] generic_file_splice_write+0x8b/0x10a
> [ 4692.048477] [<c04a1409>] do_splice_from+0xca/0xd6
> [ 4692.053391] [<c04a2754>] sys_splice+0x108/0x22b
> [ 4692.058119] [<c040420c>] syscall_call+0x7/0xb
> [ 4692.062691] [<b7f53410>] 0xb7f53410
> [ 4692.066398] =======================
> [ 4692.070031] INFO: lockdep is turned off.
> [ 4692.074038] Code: 2c 09 7e c0 e8 2f 6e 07 00 85 c0 74 04 0f 0b eb fe 31 d2 81 7d 08 00 10 00 00 0f 97 c2 b8 10 09 7e c0 e8 11 6e 07 00 85 c0 74 04 <0f> 0b eb fe 8b 55 08 39 55 b4 0f 97 c2 0f b6 d2 b8 f4 08 7e c0
> [ 4692.094556] EIP: [<c04a510f>] __block_prepare_write+0x64/0x3a5 SS:ESP 0068:cc454d60
>
> (gdb) l *__block_prepare_write+0x64
> 0xc10a510f is in __block_prepare_write (fs/buffer.c:1821).
> 1816 unsigned blocksize, bbits;
> 1817 struct buffer_head *bh, *head, *wait[2], **wait_bh=wait;
> 1818
> 1819 BUG_ON(!PageLocked(page));
> 1820 BUG_ON(from > PAGE_CACHE_SIZE);
> 1821 BUG_ON(to > PAGE_CACHE_SIZE);
> 1822 BUG_ON(from > to);
> 1823
> 1824 blocksize = 1 << inode->i_blkbits;
> 1825 if (!page_has_buffers(page))

yup, thanks, I'd forgotten about that one. Nick had a protofix but afaik nobody
has tested it yet.


2007-06-07 15:38:00

by Peter Zijlstra

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2 - usb-storage

My kernel went chatty when I tried to access my usb-stick; which it
didn't seem to find.


Initializing USB Mass Storage driver...
scsi6 : SCSI emulation for USB Mass Storage devices
usb-storage: device found at 2
usb-storage: waiting for device to settle before scanning
scsi7 : SCSI emulation for USB Mass Storage devices
usb-storage: device found at 5
usb-storage: waiting for device to settle before scanning
usbcore: registered new interface driver usb-storage
USB Mass Storage support registered.
usb-storage: device scan complete
WARNING: at /usr/src/linux-2.6/drivers/usb/core/urb.c:293
usb_submit_urb()

Call Trace:
[<ffffffff8020d4c7>] show_trace+0x34/0x4f
[<ffffffff8020d4f4>] dump_stack+0x12/0x17
[<ffffffff803cac6a>] usb_submit_urb+0x9f/0x226
[<ffffffff803cc4c7>] usb_sg_wait+0x56/0x132
[<ffffffff8820519d>] :usb_storage:usb_stor_bulk_transfer_sg+0x9d/0xf3
[<ffffffff88205313>] :usb_storage:usb_stor_Bulk_transport+0x120/0x244
[<ffffffff8820577f>] :usb_storage:usb_stor_invoke_transport+0x25/0x2d2
[<ffffffff882066c0>] :usb_storage:usb_stor_control_thread+0x14b/0x1e7
[<ffffffff8024a7df>] kthread+0x47/0x74
[<ffffffff8020cc28>] child_rip+0xa/0x12

usb-storage: device scan complete
WARNING: at /usr/src/linux-2.6/drivers/usb/core/urb.c:293
usb_submit_urb()

Call Trace:
[<ffffffff8020d4c7>] show_trace+0x34/0x4f
[<ffffffff8020d4f4>] dump_stack+0x12/0x17
[<ffffffff803cac6a>] usb_submit_urb+0x9f/0x226
[<ffffffff803cc4c7>] usb_sg_wait+0x56/0x132
[<ffffffff8820519d>] :usb_storage:usb_stor_bulk_transfer_sg+0x9d/0xf3
[<ffffffff88205313>] :usb_storage:usb_stor_Bulk_transport+0x120/0x244
[<ffffffff8820577f>] :usb_storage:usb_stor_invoke_transport+0x25/0x2d2
[<ffffffff882066c0>] :usb_storage:usb_stor_control_thread+0x14b/0x1e7
[<ffffffff8024a7df>] kthread+0x47/0x74
[<ffffffff8020cc28>] child_rip+0xa/0x12



2007-06-07 19:38:11

by Joseph Fannin

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/

I don't think this was intentional:

[ 29.873254] edac_stub: module license 'unspecified' taints kernel.

--
Joseph Fannin
[email protected] || [email protected]

2007-06-07 20:01:50

by Adrian Bunk

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Thu, Jun 07, 2007 at 11:46:33AM +0200, Manuel Lauss wrote:
> On Thu, Jun 07, 2007 at 06:37:02PM +0900, Paul Mundt wrote:
> > On Thu, Jun 07, 2007 at 11:19:42AM +0200, Manuel Lauss wrote:
> > > On Thu, Jun 07, 2007 at 04:11:38PM +0900, Paul Mundt wrote:
> > > > On Wed, Jun 06, 2007 at 11:42:31PM -0700, William Lee Irwin III wrote:
> > > > > sound/soc/sh/Kconfig:6:warning: 'select' used by config symbol 'SND_SOC_PCM_SH7760' refers to undefined symbol 'SH_DMABRG'
> > >
> > > ---
> > >
> > > Make SND_SOC_PCM_SH7760 depend on SH_DMABRG rather than selecting it
> > >
> > > Fixes Kconfig warning about undefined SH_DMABRG symbol on non-sh builds.
> > >
> > Are you sure this is the way you want to go? The select here is
> > reasonably useful.
>
> I hope the other people using this code are smart enough to set SH_DMABRG in
> their board's defconfig. (I seem to remember there was an argument about
> the evilness of select; and as far as I know I am the only user of this
> code anyway)
>
> If you think select is more useful then I'll send another patch to the
> alsa folks.

There's nothing that has to be fixed.

Sam is working on changing Kconfig to no longer emit these bogus
warnings.

> Thanks,
> Manuel Lauss

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2007-06-07 20:14:10

by Sam Ravnborg

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

>
> There's nothing that has to be fixed.
>
> Sam is working on changing Kconfig to no longer emit these bogus
> warnings.
Very slowly though... :-(

Sam

2007-06-07 20:32:05

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Thu, 7 Jun 2007 15:37:51 -0400
[email protected] (Joseph Fannin) wrote:

> On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
>
> I don't think this was intentional:
>
> [ 29.873254] edac_stub: module license 'unspecified' taints kernel.
>

No, I'm sure it wasn't.

Doug, please check all that code and add suitable MODULE_LICENSEs?

2007-06-07 21:46:38

by Joseph Fannin

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2: Assigning IP address fails

On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/

I'm not able to bring an ethernet interface down and back up again
with this if avahi-autoipd is installed on my Ubuntu boxes. I've seen
it on three different computers with different NIC hardware.

I've worked out an easy way to reproduce it without
avahi-autoipd. Starting with eth0 up (address assigned by DHCP):

# ifdown eth0
< dhclient makes the normal noise about releasing the address >
# ip addr add 169.254.255.67/16 brd 169.254.255.255 label eth0:avahi scope link dev eth0
# ip addr del 169.154.255.67/16 brd 169.254.255.255 label eth0:avahi scope link dev eth0
# ifup eth0
SIOCSIFADDR: No buffer space available < -- first sign of trouble HERE
< dhclient copyright boilerplate >
Listening on LPF/eth0/<MAC addr>
Sending on LPF/eth0/<MAC addr>
Sending on Socket/fallback
DHCPDISCOVER on eth0 to 255.255.255.255 port 67 interval 5
DHCPOFFER from < DHCP server >
DHCPREQUEST on eth0 to 255.255.255.255 port 67
DHCPACK from < DHCP server >
SIOCSIFADDR: No buffer space available
SIOCSIFNETMASK: Cannot assign requested address
SIOCSIFBRDADDR: Cannot assign requested address
SIOCADDRTL No such process
bound to < IP address > -- renewal in XXXX seconds
#

At this point, the interface is up, but has no address assigned.
Manually assigning one with ifconfig fails:

# ifconfig eth0 netmask 255.255.255.0 172.16.0.1
SIOCSIFNETMASK: Cannot assign requested address
SIOCSIFADDR: No buffer space available
#

... and a reboot is the only way I've been able to get the interface
to work again.

The last kernels I tried were 2.6.22-rc3 and *I think*
2.6.22-rc1-mm1, neither of which had this problem. I will test
2.6.22-rc4 and 2.6.22-rc3-mm1 later, but I'm out of time today.

I've attached my .config .

--
Joseph Fannin
[email protected]


Attachments:
(No filename) (1.93 kB)
config (81.59 kB)
Download all attachments

2007-06-07 22:09:05

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2: Assigning IP address fails

On Thu, 7 Jun 2007 17:46:09 -0400
[email protected] (Joseph Fannin) wrote:

> On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
>
> I'm not able to bring an ethernet interface down and back up again
> with this if avahi-autoipd is installed on my Ubuntu boxes. I've seen
> it on three different computers with different NIC hardware.
>
> I've worked out an easy way to reproduce it without
> avahi-autoipd. Starting with eth0 up (address assigned by DHCP):
>
> # ifdown eth0
> < dhclient makes the normal noise about releasing the address >
> # ip addr add 169.254.255.67/16 brd 169.254.255.255 label eth0:avahi scope link dev eth0
> # ip addr del 169.154.255.67/16 brd 169.254.255.255 label eth0:avahi scope link dev eth0
> # ifup eth0
> SIOCSIFADDR: No buffer space available < -- first sign of trouble HERE
> < dhclient copyright boilerplate >
> Listening on LPF/eth0/<MAC addr>
> Sending on LPF/eth0/<MAC addr>
> Sending on Socket/fallback
> DHCPDISCOVER on eth0 to 255.255.255.255 port 67 interval 5
> DHCPOFFER from < DHCP server >
> DHCPREQUEST on eth0 to 255.255.255.255 port 67
> DHCPACK from < DHCP server >
> SIOCSIFADDR: No buffer space available
> SIOCSIFNETMASK: Cannot assign requested address
> SIOCSIFBRDADDR: Cannot assign requested address
> SIOCADDRTL No such process
> bound to < IP address > -- renewal in XXXX seconds
> #
>
> At this point, the interface is up, but has no address assigned.
> Manually assigning one with ifconfig fails:
>
> # ifconfig eth0 netmask 255.255.255.0 172.16.0.1
> SIOCSIFNETMASK: Cannot assign requested address
> SIOCSIFADDR: No buffer space available
> #
>
> ... and a reboot is the only way I've been able to get the interface
> to work again.
>
> The last kernels I tried were 2.6.22-rc3 and *I think*
> 2.6.22-rc1-mm1, neither of which had this problem. I will test
> 2.6.22-rc4 and 2.6.22-rc3-mm1 later, but I'm out of time today.
>
> I've attached my .config .

Yep, thanks - Miles has reported the same thing.

2007-06-07 22:20:23

by Alan Stern

[permalink] [raw]
Subject: Re: [usb-storage] 2.6.22-rc4-mm2 - usb-storage

On Thu, 7 Jun 2007, Peter Zijlstra wrote:

> My kernel went chatty when I tried to access my usb-stick; which it
> didn't seem to find.

> WARNING: at /usr/src/linux-2.6/drivers/usb/core/urb.c:293
> usb_submit_urb()
>
> Call Trace:
> [<ffffffff8020d4c7>] show_trace+0x34/0x4f
> [<ffffffff8020d4f4>] dump_stack+0x12/0x17
> [<ffffffff803cac6a>] usb_submit_urb+0x9f/0x226
> [<ffffffff803cc4c7>] usb_sg_wait+0x56/0x132
> [<ffffffff8820519d>] :usb_storage:usb_stor_bulk_transfer_sg+0x9d/0xf3
> [<ffffffff88205313>] :usb_storage:usb_stor_Bulk_transport+0x120/0x244
> [<ffffffff8820577f>] :usb_storage:usb_stor_invoke_transport+0x25/0x2d2
> [<ffffffff882066c0>] :usb_storage:usb_stor_control_thread+0x14b/0x1e7
> [<ffffffff8024a7df>] kthread+0x47/0x74
> [<ffffffff8020cc28>] child_rip+0xa/0x12

This is false-alarm output from something intended to track down a
reported bug. The patch responsible is this one:

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/broken-out/usb-try-to-debug-bug-8561.patch

It was removed from -mm just recently; you can simply revert it in your
kernel source.

Alan Stern

2007-06-07 22:56:06

by Herbert Xu

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2: Assigning IP address fails

On Thu, Jun 07, 2007 at 03:06:53PM -0700, Andrew Morton wrote:
>
> > I'm not able to bring an ethernet interface down and back up again
> > with this if avahi-autoipd is installed on my Ubuntu boxes. I've seen
> > it on three different computers with different NIC hardware.

Sorry, it was my patch. This patch should fix it.

[IPV4]: Do not remove idev when addresses are cleared

Now that we create idev before addresses are added, it no longer makes
sense to remove them when addresses are all deleted.

Signed-off-by: Herbert Xu <[email protected]>

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 354e800..0cf813f 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -327,12 +327,8 @@ static void __inet_del_ifa(struct in_device *in_dev, struct in_ifaddr **ifap,
}

}
- if (destroy) {
+ if (destroy)
inet_free_ifa(ifa1);
-
- if (!in_dev->ifa_list)
- inetdev_destroy(in_dev);
- }
}

static void inet_del_ifa(struct in_device *in_dev, struct in_ifaddr **ifap,

2007-06-08 01:35:59

by David Miller

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2: Assigning IP address fails

From: Herbert Xu <[email protected]>
Date: Fri, 8 Jun 2007 08:54:52 +1000

> On Thu, Jun 07, 2007 at 03:06:53PM -0700, Andrew Morton wrote:
> >
> > > I'm not able to bring an ethernet interface down and back up again
> > > with this if avahi-autoipd is installed on my Ubuntu boxes. I've seen
> > > it on three different computers with different NIC hardware.
>
> Sorry, it was my patch. This patch should fix it.
>
> [IPV4]: Do not remove idev when addresses are cleared
>
> Now that we create idev before addresses are added, it no longer makes
> sense to remove them when addresses are all deleted.
>
> Signed-off-by: Herbert Xu <[email protected]>

Applied, thanks Herbert.

2007-06-08 08:56:38

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [usb-storage] 2.6.22-rc4-mm2 - usb-storage

On Thu, 2007-06-07 at 18:20 -0400, Alan Stern wrote:
> On Thu, 7 Jun 2007, Peter Zijlstra wrote:
>
> > My kernel went chatty when I tried to access my usb-stick; which it
> > didn't seem to find.
>
> > WARNING: at /usr/src/linux-2.6/drivers/usb/core/urb.c:293
> > usb_submit_urb()
> >
> > Call Trace:
> > [<ffffffff8020d4c7>] show_trace+0x34/0x4f
> > [<ffffffff8020d4f4>] dump_stack+0x12/0x17
> > [<ffffffff803cac6a>] usb_submit_urb+0x9f/0x226
> > [<ffffffff803cc4c7>] usb_sg_wait+0x56/0x132
> > [<ffffffff8820519d>] :usb_storage:usb_stor_bulk_transfer_sg+0x9d/0xf3
> > [<ffffffff88205313>] :usb_storage:usb_stor_Bulk_transport+0x120/0x244
> > [<ffffffff8820577f>] :usb_storage:usb_stor_invoke_transport+0x25/0x2d2
> > [<ffffffff882066c0>] :usb_storage:usb_stor_control_thread+0x14b/0x1e7
> > [<ffffffff8024a7df>] kthread+0x47/0x74
> > [<ffffffff8020cc28>] child_rip+0xa/0x12
>
> This is false-alarm output from something intended to track down a
> reported bug. The patch responsible is this one:

Right, well then I have another problem. Because it doesn't find my
usb-stick.

I noticed from D states (quite easy to reproduce, just modprobe
usb-storage):

scsi_eh_6 D ffff8100079ed640 0 3568 2 (L-TLB)
ffff81000ac45e10 0000000000000046 0000000000000000 0000000180252936
0000000000000002 0000000100000000 ffff81000ac42700 ffff8100043ca240
ffff81000ac42978 ffffffff8024fc8d 00000000000000ff ffff81000ac42700
Call Trace:
[<ffffffff804775a9>] wait_for_completion+0x82/0xc1
[<ffffffff88201673>] :usb_storage:command_abort+0x7c/0x86
[<ffffffff8805f54f>] :scsi_mod:scsi_error_handler+0x28e/0x4cc
[<ffffffff8024a7ff>] kthread+0x47/0x74
[<ffffffff8020cc28>] child_rip+0xa/0x12

usb-storage D ffff8100079ed640 0 3570 2 (L-TLB)
ffff81000ac4dd30 0000000000000046 0000000000000000 0000000100000046
0000000000000002 0000000100000000 ffff81000ac4a780 ffff8100043ca240
ffff81000ac4a9f8 ffffffff802518f5 00000000000000ff ffff81000ac4a780
Call Trace:
[<ffffffff804775a9>] wait_for_completion+0x82/0xc1
[<ffffffff803cc896>] usb_sg_wait+0x115/0x132
[<ffffffff8820219d>] :usb_storage:usb_stor_bulk_transfer_sg+0x9d/0xf3
[<ffffffff88202313>] :usb_storage:usb_stor_Bulk_transport+0x120/0x244
[<ffffffff8820277f>] :usb_storage:usb_stor_invoke_transport+0x25/0x2d2
[<ffffffff882036c0>] :usb_storage:usb_stor_control_thread+0x14b/0x1e7
[<ffffffff8024a7ff>] kthread+0x47/0x74
[<ffffffff8020cc28>] child_rip+0xa/0x12

scsi_eh_7 D ffff8100079ed640 0 3574 2 (L-TLB)
ffff81000ac39e10 0000000000000046 0000000000000000 0000000100000046
0000000000000002 0000000100000000 ffff81000ac16640 ffff8100043ca240
ffff81000ac168b8 ffffffff8024fc8d 00000000000000ff ffff81000ac16640
Call Trace:
[<ffffffff804775a9>] wait_for_completion+0x82/0xc1
[<ffffffff88201673>] :usb_storage:command_abort+0x7c/0x86
[<ffffffff8805f54f>] :scsi_mod:scsi_error_handler+0x28e/0x4cc
[<ffffffff8024a7ff>] kthread+0x47/0x74
[<ffffffff8020cc28>] child_rip+0xa/0x12

usb-storage D ffff81000773f140 0 3575 2 (L-TLB)
ffff81000ac5fd30 0000000000000046 0000000000000000 0000000000000001
ffffffff8020c310 0000000100000001 ffff81000ac5c880 ffff8100043ca240
ffff81000ac5caf8 ffff81000ac2f8e8 00000000000000ff ffffffff80840f30
Call Trace:
[<ffffffff804775a9>] wait_for_completion+0x82/0xc1
[<ffffffff803cc896>] usb_sg_wait+0x115/0x132
[<ffffffff8820219d>] :usb_storage:usb_stor_bulk_transfer_sg+0x9d/0xf3
[<ffffffff88202313>] :usb_storage:usb_stor_Bulk_transport+0x120/0x244
[<ffffffff8820277f>] :usb_storage:usb_stor_invoke_transport+0x25/0x2d2
[<ffffffff882036c0>] :usb_storage:usb_stor_control_thread+0x14b/0x1e7
[<ffffffff8024a7ff>] kthread+0x47/0x74
[<ffffffff8020cc28>] child_rip+0xa/0x12

scsi_scan_6 D ffff8100079ed640 0 3579 2 (L-TLB)
ffff81000ac4fa90 0000000000000046 0000000000000000 000000010ac46740
0000000000000002 0000000100000000 ffff81000ac46740 ffff8100043ca240
ffff81000ac469b8 ffffffff802518f5 00000000000000ff ffff81000ac46740
Call Trace:
[<ffffffff804775a9>] wait_for_completion+0x82/0xc1
[<ffffffff803439e6>] blk_execute_rq+0xb3/0xd3
[<ffffffff88061074>] :scsi_mod:scsi_execute+0xca/0xe6
[<ffffffff88061149>] :scsi_mod:scsi_execute_req+0xb9/0xde
[<ffffffff880622d2>] :scsi_mod:scsi_probe_and_add_lun+0x241/0xa8b
[<ffffffff880630f3>] :scsi_mod:__scsi_scan_target+0xb5/0x5df
[<ffffffff88063662>] :scsi_mod:scsi_scan_channel+0x45/0x70
[<ffffffff8806375c>] :scsi_mod:scsi_scan_host_selected+0xcf/0x10a
[<ffffffff88063979>] :scsi_mod:do_scan_async+0x16/0x12c
[<ffffffff8024a7ff>] kthread+0x47/0x74
[<ffffffff8020cc28>] child_rip+0xa/0x12

scsi_scan_7 D ffff81000773f140 0 3580 2 (L-TLB)
ffff81000ac53a90 0000000000000046 0000000000000000 000000010ac507c0
0000000000000002 0000000100000000 ffff81000ac507c0 ffff8100043ca240
ffff81000ac50a38 ffffffff802518f5 00000000000000ff ffff81000ac507c0
Call Trace:
[<ffffffff804775a9>] wait_for_completion+0x82/0xc1
[<ffffffff803439e6>] blk_execute_rq+0xb3/0xd3
[<ffffffff88061074>] :scsi_mod:scsi_execute+0xca/0xe6
[<ffffffff88061149>] :scsi_mod:scsi_execute_req+0xb9/0xde
[<ffffffff880622d2>] :scsi_mod:scsi_probe_and_add_lun+0x241/0xa8b
[<ffffffff880630f3>] :scsi_mod:__scsi_scan_target+0xb5/0x5df
[<ffffffff88063662>] :scsi_mod:scsi_scan_channel+0x45/0x70
[<ffffffff8806375c>] :scsi_mod:scsi_scan_host_selected+0xcf/0x10a
[<ffffffff88063979>] :scsi_mod:do_scan_async+0x16/0x12c
[<ffffffff8024a7ff>] kthread+0x47/0x74
[<ffffffff8020cc28>] child_rip+0xa/0x12

lsusb D ffff810006ace0c0 0 4515 4472 (NOTLB)
ffff81000ad65c58 0000000000000046 ffff81000ad65ea8 00000001045e51c0
ffff81000d01cb48 000000018024fbf1 ffff81000d01c380 ffff81000685a200
ffff81000d01c5f8 ffff81000d01c380 ffffffff8047a54b 0000000000000292
Call Trace:
[<ffffffff80479b65>] __down+0xe8/0x100
[<ffffffff80479768>] __down_failed+0x35/0x3a
[<ffffffff803d1b24>] usbdev_ioctl+0x4f/0x1333
[<ffffffff802ad2bd>] do_ioctl+0x9d/0xb6
[<ffffffff802ad523>] vfs_ioctl+0x24d/0x266
[<ffffffff802ad595>] sys_ioctl+0x59/0x7c
[<ffffffff8020bd6e>] system_call+0x7e/0x83
[<0000003b834c9367>]



2007-06-08 14:16:59

by Alan Stern

[permalink] [raw]
Subject: Re: [usb-storage] 2.6.22-rc4-mm2 - usb-storage

[Trimmed the recipients list]

On Fri, 8 Jun 2007, Peter Zijlstra wrote:

> On Thu, 2007-06-07 at 18:20 -0400, Alan Stern wrote:
> > On Thu, 7 Jun 2007, Peter Zijlstra wrote:
> >
> > > My kernel went chatty when I tried to access my usb-stick; which it
> > > didn't seem to find.
...
> > This is false-alarm output from something intended to track down a
> > reported bug. The patch responsible is this one:
>
> Right, well then I have another problem. Because it doesn't find my
> usb-stick.
>
> I noticed from D states (quite easy to reproduce, just modprobe
> usb-storage):
>
> scsi_eh_6 D ffff8100079ed640 0 3568 2 (L-TLB)
> ffff81000ac45e10 0000000000000046 0000000000000000 0000000180252936
> 0000000000000002 0000000100000000 ffff81000ac42700 ffff8100043ca240
> ffff81000ac42978 ffffffff8024fc8d 00000000000000ff ffff81000ac42700
> Call Trace:
> [<ffffffff804775a9>] wait_for_completion+0x82/0xc1
> [<ffffffff88201673>] :usb_storage:command_abort+0x7c/0x86
> [<ffffffff8805f54f>] :scsi_mod:scsi_error_handler+0x28e/0x4cc
> [<ffffffff8024a7ff>] kthread+0x47/0x74
> [<ffffffff8020cc28>] child_rip+0xa/0x12

Okay, this is a separate problem. To help diagnose it, please turn on
CONFIG_USB_DEBUG and CONFIG_USB_STORAGE_DEBUG and then post the
resulting dmesg log.

Alan Stern

2007-06-08 16:30:43

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [usb-storage] 2.6.22-rc4-mm2 - usb-storage

On Fri, 2007-06-08 at 10:16 -0400, Alan Stern wrote:
> [Trimmed the recipients list]
>
> On Fri, 8 Jun 2007, Peter Zijlstra wrote:
>
> > On Thu, 2007-06-07 at 18:20 -0400, Alan Stern wrote:
> > > On Thu, 7 Jun 2007, Peter Zijlstra wrote:
> > >
> > > > My kernel went chatty when I tried to access my usb-stick; which it
> > > > didn't seem to find.
> ....
> > > This is false-alarm output from something intended to track down a
> > > reported bug. The patch responsible is this one:
> >
> > Right, well then I have another problem. Because it doesn't find my
> > usb-stick.
> >
> > I noticed from D states (quite easy to reproduce, just modprobe
> > usb-storage):
> >
> > scsi_eh_6 D ffff8100079ed640 0 3568 2 (L-TLB)
> > ffff81000ac45e10 0000000000000046 0000000000000000 0000000180252936
> > 0000000000000002 0000000100000000 ffff81000ac42700 ffff8100043ca240
> > ffff81000ac42978 ffffffff8024fc8d 00000000000000ff ffff81000ac42700
> > Call Trace:
> > [<ffffffff804775a9>] wait_for_completion+0x82/0xc1
> > [<ffffffff88201673>] :usb_storage:command_abort+0x7c/0x86
> > [<ffffffff8805f54f>] :scsi_mod:scsi_error_handler+0x28e/0x4cc
> > [<ffffffff8024a7ff>] kthread+0x47/0x74
> > [<ffffffff8020cc28>] child_rip+0xa/0x12
>
> Okay, this is a separate problem. To help diagnose it, please turn on
> CONFIG_USB_DEBUG and CONFIG_USB_STORAGE_DEBUG and then post the
> resulting dmesg log.

Here goes:

http://programming.kicks-ass.net/misc/dmesg


2007-06-08 16:54:21

by Alan Stern

[permalink] [raw]
Subject: Re: [usb-storage] 2.6.22-rc4-mm2 - usb-storage

On Fri, 8 Jun 2007, Peter Zijlstra wrote:

> > Okay, this is a separate problem. To help diagnose it, please turn on
> > CONFIG_USB_DEBUG and CONFIG_USB_STORAGE_DEBUG and then post the
> > resulting dmesg log.
>
> Here goes:
>
> http://programming.kicks-ass.net/misc/dmesg

Okay, it's not a separate problem. You didn't revert the patch I
mentioned earlier. It's generating those WARNINGs and causing
usb-storage to fail.

Alan Stern

2007-06-08 16:57:14

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [usb-storage] 2.6.22-rc4-mm2 - usb-storage

On Fri, 2007-06-08 at 12:54 -0400, Alan Stern wrote:
> On Fri, 8 Jun 2007, Peter Zijlstra wrote:
>
> > > Okay, this is a separate problem. To help diagnose it, please turn on
> > > CONFIG_USB_DEBUG and CONFIG_USB_STORAGE_DEBUG and then post the
> > > resulting dmesg log.
> >
> > Here goes:
> >
> > http://programming.kicks-ass.net/misc/dmesg
>
> Okay, it's not a separate problem. You didn't revert the patch I
> mentioned earlier. It's generating those WARNINGs and causing
> usb-storage to fail.

Ah, ok, my bad, I had understood the warning were merely cosmetic
damage.

Thanks.

2007-06-12 00:07:18

by Adrian Bunk

[permalink] [raw]
Subject: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc4-mm1:
>...
> git-kvm.patch
>...
> git trees
>...

I'm getting the following compile error with CONFIG_X86_CMPXCHG64=n
(with -Werror-implicit-function-declaration - otherwise it would be a
link error):

<-- snip -->

...
CC [M] drivers/kvm/mmu.o
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc4-mm2/drivers/kvm/mmu.c: In function ‘set_shadow_pte’:
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc4-mm2/drivers/kvm/mmu.c:199: error: implicit declaration of function ‘set_64bit’
make[3]: *** [drivers/kvm/mmu.o] Error 1

<-- snip -->

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2007-06-12 03:23:48

by Dave Jones

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

On Tue, Jun 12, 2007 at 02:07:18AM +0200, Adrian Bunk wrote:

> I'm getting the following compile error with CONFIG_X86_CMPXCHG64=n
> (with -Werror-implicit-function-declaration - otherwise it would be a
> link error):

We really should just get that flag into mainline so that it breaks
for people before they submit patches. We run into this constantly.


Add -Werror-implicit-function-declaration
This makes builds fail sooner if something is implicitly defined instead
of having to wait half an hour for it to fail at the linking stage.

Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6/Makefile~ 2007-06-04 16:46:24.000000000 -0400
+++ linux-2.6/Makefile 2007-06-04 16:46:53.000000000 -0400
@@ -313,7 +313,8 @@ LINUXINCLUDE := -Iinclude \
CPPFLAGS := -D__KERNEL__ $(LINUXINCLUDE)

CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
- -fno-strict-aliasing -fno-common
+ -fno-strict-aliasing -fno-common \
+ -Werror-implicit-function-declaration
AFLAGS := -D__ASSEMBLY__

# Read KERNELRELEASE from include/config/kernel.release (if it exists)

--
http://www.codemonkey.org.uk

2007-06-12 06:00:57

by Avi Kivity

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

Adrian Bunk wrote:
> On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
>
>> ...
>> Changes since 2.6.22-rc4-mm1:
>> ...
>> git-kvm.patch
>> ...
>> git trees
>> ...
>>
>
> I'm getting the following compile error with CONFIG_X86_CMPXCHG64=n
> (with -Werror-implicit-function-declaration - otherwise it would be a
> link error):
>
> <-- snip -->
>
> ...
> CC [M] drivers/kvm/mmu.o
> /home/bunk/linux/kernel-2.6/linux-2.6.22-rc4-mm2/drivers/kvm/mmu.c: In function ‘set_shadow_pte’:
> /home/bunk/linux/kernel-2.6/linux-2.6.22-rc4-mm2/drivers/kvm/mmu.c:199: error: implicit declaration of function ‘set_64bit’
> make[3]: *** [drivers/kvm/mmu.o] Error 1
>
> <-- snip -->
>

I've committed the following, which should disable kvm on i486 and below:

diff --git a/drivers/kvm/Kconfig b/drivers/kvm/Kconfig
index 2f661e5..33fa28a 100644
--- a/drivers/kvm/Kconfig
+++ b/drivers/kvm/Kconfig
@@ -11,6 +11,7 @@ if VIRTUALIZATION
config KVM
tristate "Kernel-based Virtual Machine (KVM) support"
depends on X86 && EXPERIMENTAL
+ depends on X86_CMPXCHG64 || 64BIT
---help---
Support hosting fully virtualized guest machines using hardware
virtualization extensions. You will need a fairly recent


--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

2007-06-12 11:07:44

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] make cmdline_parse_kernelcore() static

cmdline_parse_kernelcore() can become static.

---
--- linux-2.6.22-rc4-mm2/mm/page_alloc.c.old 2007-06-12 02:10:56.000000000 +0200
+++ linux-2.6.22-rc4-mm2/mm/page_alloc.c 2007-06-12 02:11:08.000000000 +0200
@@ -3879,7 +3879,7 @@
* kernelcore=size sets the amount of memory for use for allocations that
* cannot be reclaimed or migrated.
*/
-int __init cmdline_parse_kernelcore(char *p)
+static int __init cmdline_parse_kernelcore(char *p)
{
unsigned long long coremem;
if (!p)

2007-06-12 11:07:57

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] make mm/swap_prefetch.c:remove_from_swapped_list() static

remove_from_swapped_list() can become static.

Signed-off-by: Adrian Bunk <[email protected]>

---

include/linux/swap-prefetch.h | 5 -----
mm/swap_prefetch.c | 2 +-
2 files changed, 1 insertion(+), 6 deletions(-)

--- linux-2.6.22-rc4-mm2/include/linux/swap-prefetch.h.old 2007-06-12 02:14:51.000000000 +0200
+++ linux-2.6.22-rc4-mm2/include/linux/swap-prefetch.h 2007-06-12 02:14:59.000000000 +0200
@@ -33,7 +33,6 @@
}

extern void add_to_swapped_list(struct page *page);
-extern void remove_from_swapped_list(const unsigned long index);
extern void delay_swap_prefetch(void);
extern void prepare_swap_prefetch(void);

@@ -46,10 +45,6 @@
{
}

-static inline void remove_from_swapped_list(const unsigned long __unused)
-{
-}
-
static inline void delay_swap_prefetch(void)
{
}
--- linux-2.6.22-rc4-mm2/mm/swap_prefetch.c.old 2007-06-12 02:15:09.000000000 +0200
+++ linux-2.6.22-rc4-mm2/mm/swap_prefetch.c 2007-06-12 02:15:18.000000000 +0200
@@ -139,7 +139,7 @@
* look up the entry from the index without having to iterate over the whole
* list.
*/
-void remove_from_swapped_list(const unsigned long index)
+static void remove_from_swapped_list(const unsigned long index)
{
struct swapped_entry *entry;
unsigned long flags;

2007-06-12 11:17:26

by Con Kolivas

[permalink] [raw]
Subject: Re: [-mm patch] make mm/swap_prefetch.c:remove_from_swapped_list() static

On Tuesday 12 June 2007 21:07, Adrian Bunk wrote:
> remove_from_swapped_list() can become static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Thanks. Good pick up. It was a global function but now is only done locally
from within swap_prefetch.c lazily since the improvements.

Signed-off-by: Con Kolivas <[email protected]>

--
-ck

2007-06-12 12:52:27

by mel

[permalink] [raw]
Subject: Re: [-mm patch] make cmdline_parse_kernelcore() static

On (12/06/07 13:07), Adrian Bunk didst pronounce:
> cmdline_parse_kernelcore() can become static.
>

Agreed. I would consider this a fix to handle-kernelcore=-generic.patch

Thanks Adrian

Acked-by: Mel Gorman <[email protected]>

> ---
> --- linux-2.6.22-rc4-mm2/mm/page_alloc.c.old 2007-06-12 02:10:56.000000000 +0200
> +++ linux-2.6.22-rc4-mm2/mm/page_alloc.c 2007-06-12 02:11:08.000000000 +0200
> @@ -3879,7 +3879,7 @@
> * kernelcore=size sets the amount of memory for use for allocations that
> * cannot be reclaimed or migrated.
> */
> -int __init cmdline_parse_kernelcore(char *p)
> +static int __init cmdline_parse_kernelcore(char *p)
> {
> unsigned long long coremem;
> if (!p)

--
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab

2007-06-12 22:04:35

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

On Mon, 11 Jun 2007 23:22:24 -0400
Dave Jones <[email protected]> wrote:

> Add -Werror-implicit-function-declaration
> This makes builds fail sooner if something is implicitly defined instead
> of having to wait half an hour for it to fail at the linking stage.
>
> Signed-off-by: Dave Jones <[email protected]>
>
> --- linux-2.6/Makefile~ 2007-06-04 16:46:24.000000000 -0400
> +++ linux-2.6/Makefile 2007-06-04 16:46:53.000000000 -0400
> @@ -313,7 +313,8 @@ LINUXINCLUDE := -Iinclude \
> CPPFLAGS := -D__KERNEL__ $(LINUXINCLUDE)
>
> CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> - -fno-strict-aliasing -fno-common
> + -fno-strict-aliasing -fno-common \
> + -Werror-implicit-function-declaration
> AFLAGS := -D__ASSEMBLY__
>
> # Read KERNELRELEASE from include/config/kernel.release (if it exists)

This causes the i386 allmodconfig build to fail:

include/linux/uaccess.h: In function 'pagefault_disable':
include/linux/uaccess.h:23: error: implicit declaration of function '__memory_barrier'

I didn't look to see why...

2007-06-12 22:17:47

by Dave Jones

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

On Tue, Jun 12, 2007 at 03:03:57PM -0700, Andrew Morton wrote:
> On Mon, 11 Jun 2007 23:22:24 -0400
> Dave Jones <[email protected]> wrote:
>
> > Add -Werror-implicit-function-declaration
> > This makes builds fail sooner if something is implicitly defined instead
> > of having to wait half an hour for it to fail at the linking stage.
> >
> > Signed-off-by: Dave Jones <[email protected]>
> >
> > --- linux-2.6/Makefile~ 2007-06-04 16:46:24.000000000 -0400
> > +++ linux-2.6/Makefile 2007-06-04 16:46:53.000000000 -0400
> > @@ -313,7 +313,8 @@ LINUXINCLUDE := -Iinclude \
> > CPPFLAGS := -D__KERNEL__ $(LINUXINCLUDE)
> >
> > CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> > - -fno-strict-aliasing -fno-common
> > + -fno-strict-aliasing -fno-common \
> > + -Werror-implicit-function-declaration
> > AFLAGS := -D__ASSEMBLY__
> >
> > # Read KERNELRELEASE from include/config/kernel.release (if it exists)
>
> This causes the i386 allmodconfig build to fail:

Seems to be doing its job rather effectively.

> include/linux/uaccess.h: In function 'pagefault_disable':
> include/linux/uaccess.h:23: error: implicit declaration of function '__memory_barrier'
>
> I didn't look to see why...

include/linux/compiler.h ..

/* Optimization barrier */
#ifndef barrier
# define barrier() __memory_barrier()
#endif

We shouldn't be hitting this, because barrier should be getting defined
in the compiler specific headers above..

#if __GNUC__ >= 4
# include <linux/compiler-gcc4.h>
#elif __GNUC__ == 3 && __GNUC_MINOR__ >= 2
# include <linux/compiler-gcc3.h>
#else
# error Sorry, your compiler is too old/not recognized.
#endif

both of those include linux/compiler-gcc.h, which defines barrier.
How strange. What compiler version is this?

Dave

--
http://www.codemonkey.org.uk

2007-06-12 22:37:46

by Adrian Bunk

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

On Tue, Jun 12, 2007 at 03:03:57PM -0700, Andrew Morton wrote:
> On Mon, 11 Jun 2007 23:22:24 -0400
> Dave Jones <[email protected]> wrote:
>
> > Add -Werror-implicit-function-declaration
> > This makes builds fail sooner if something is implicitly defined instead
> > of having to wait half an hour for it to fail at the linking stage.
> >
> > Signed-off-by: Dave Jones <[email protected]>
> >
> > --- linux-2.6/Makefile~ 2007-06-04 16:46:24.000000000 -0400
> > +++ linux-2.6/Makefile 2007-06-04 16:46:53.000000000 -0400
> > @@ -313,7 +313,8 @@ LINUXINCLUDE := -Iinclude \
> > CPPFLAGS := -D__KERNEL__ $(LINUXINCLUDE)
> >
> > CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> > - -fno-strict-aliasing -fno-common
> > + -fno-strict-aliasing -fno-common \
> > + -Werror-implicit-function-declaration
> > AFLAGS := -D__ASSEMBLY__
> >
> > # Read KERNELRELEASE from include/config/kernel.release (if it exists)
>
> This causes the i386 allmodconfig build to fail:
>
> include/linux/uaccess.h: In function 'pagefault_disable':
> include/linux/uaccess.h:23: error: implicit declaration of function '__memory_barrier'
>
> I didn't look to see why...

I have -Werror-implicit-function-declaration in the CFLAGS of my
testbuilds for ages without ever hitting this.

Perhaps some change in your working tree?
Can you verify this problem with 2.6.22-rc4-mm2?

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2007-06-12 22:44:19

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

On Tue, 12 Jun 2007 18:16:29 -0400
Dave Jones <[email protected]> wrote:

> > > # Read KERNELRELEASE from include/config/kernel.release (if it exists)
> >
> > This causes the i386 allmodconfig build to fail:
>
> Seems to be doing its job rather effectively.

err, hang on. I had a different patch in there which hilariously broke
the build all over the place, and dropping that has made your patch
come good. I'll put it back.

2007-06-12 22:49:31

by Dave Jones

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

On Tue, Jun 12, 2007 at 03:43:45PM -0700, Andrew Morton wrote:
> On Tue, 12 Jun 2007 18:16:29 -0400
> Dave Jones <[email protected]> wrote:
>
> > > > # Read KERNELRELEASE from include/config/kernel.release (if it exists)
> > >
> > > This causes the i386 allmodconfig build to fail:
> >
> > Seems to be doing its job rather effectively.
>
> err, hang on. I had a different patch in there which hilariously broke
> the build all over the place, and dropping that has made your patch
> come good. I'll put it back.

This was all just a cunning trick to make me download and build an -mm
kernel wasn't it ? :-)

Dave

--
http://www.codemonkey.org.uk

2007-06-12 23:03:21

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] make drivers/acpi/osl.c:osi_linux static

On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc4-mm1:
>
> git-acpi.patch
>...
> git trees
>...


This patch makes the needlessly global osi_linux static.

Signed-off-by: Adrian Bunk <[email protected]>

---
--- linux-2.6.22-rc4-mm2/drivers/acpi/osl.c.old 2007-06-12 23:55:27.000000000 +0200
+++ linux-2.6.22-rc4-mm2/drivers/acpi/osl.c 2007-06-12 23:55:37.000000000 +0200
@@ -78,9 +78,9 @@
static char osi_additional_string[OSI_STRING_LENGTH_MAX];

#ifdef OSI_LINUX_ENABLED
-int osi_linux = 1; /* enable _OSI(Linux) by default */
+static int osi_linux = 1; /* enable _OSI(Linux) by default */
#else
-int osi_linux; /* disable _OSI(Linux) by default */
+static int osi_linux; /* disable _OSI(Linux) by default */
#endif



2007-06-12 23:03:35

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] drivers/ata/sata_nv.c: make 3 functions static

This patch makes 3 needlessly global functions static.

Signed-off-by: Adrian Bunk <[email protected]>

---

drivers/ata/sata_nv.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-2.6.22-rc4-mm2/drivers/ata/sata_nv.c.old 2007-06-13 00:02:18.000000000 +0200
+++ linux-2.6.22-rc4-mm2/drivers/ata/sata_nv.c 2007-06-13 00:03:12.000000000 +0200
@@ -314,7 +314,7 @@
static int nv_ncqintr_dmasetupfis(struct ata_port *ap);
static void ncq_clear_singlefis(struct ata_port *ap, u32 val);
static u32 ncq_ownfisintr_value (struct ata_port *ap);
-void ncq_hotplug(struct ata_port *ap, u32 fis);
+static void ncq_hotplug(struct ata_port *ap, u32 fis);
static irqreturn_t nv_mcp55_interrupt(int irq, void *dev_instance);
static int ncq_interrupt(struct ata_port *ap, u32 fis);
static int nv_scsi_queuecmd(struct scsi_cmnd *cmd,
@@ -1931,7 +1931,7 @@
ncq_clear(ap);
}

-int nv_std_prereset(struct ata_port *ap, unsigned long deadline)
+static int nv_std_prereset(struct ata_port *ap, unsigned long deadline)
{
struct ata_eh_context *ehc = &ap->eh_context;

@@ -2265,7 +2265,7 @@
return 0;
}

-u32 ncq_valid_dhfisflag(struct nv_port_priv *pp)
+static u32 ncq_valid_dhfisflag(struct nv_port_priv *pp)
{
u32 valid = (pp->dhfis_flags == pp->qc_active);

@@ -2332,7 +2332,7 @@
#endif


-void ncq_hotplug(struct ata_port *ap, u32 fis)
+static void ncq_hotplug(struct ata_port *ap, u32 fis)
{
u32 serror;
struct ata_eh_info *ehi = &ap->eh_info;

2007-06-12 23:03:50

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] drivers/acpi/processor_throttling.c: make 2 functions static

On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc4-mm1:
>
> git-acpi.patch
>...
> git trees
>...

This patch makes 2 needlessly global functions static.

Signed-off-by: Adrian Bunk <[email protected]>

---

drivers/acpi/processor_throttling.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

--- linux-2.6.22-rc4-mm2/drivers/acpi/processor_throttling.c.old 2007-06-12 23:57:53.000000000 +0200
+++ linux-2.6.22-rc4-mm2/drivers/acpi/processor_throttling.c 2007-06-12 23:58:22.000000000 +0200
@@ -410,7 +410,8 @@
return pr->throttling.acpi_processor_get_throttling(pr);
}

-int acpi_processor_set_throttling_fadt(struct acpi_processor *pr, int state)
+static int acpi_processor_set_throttling_fadt(struct acpi_processor *pr,
+ int state)
{
u32 value = 0;
u32 duty_mask = 0;
@@ -482,7 +483,8 @@
return 0;
}

-int acpi_processor_set_throttling_ptc(struct acpi_processor *pr, int state)
+static int acpi_processor_set_throttling_ptc(struct acpi_processor *pr,
+ int state)
{
u32 value = 0;


2007-06-12 23:04:11

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] make drivers/char/selection.c:store_utf8() static

This patch makes the needlessly global store_utf8() static.

Signed-off-by: Adrian Bunk <[email protected]>

---
--- linux-2.6.22-rc4-mm2/drivers/char/selection.c.old 2007-06-13 00:23:09.000000000 +0200
+++ linux-2.6.22-rc4-mm2/drivers/char/selection.c 2007-06-13 00:23:20.000000000 +0200
@@ -112,7 +112,7 @@
}

/* stores the char in UTF8 and returns the number of bytes used (1-3) */
-int store_utf8(u16 c, char *p)
+static int store_utf8(u16 c, char *p)
{
if (c < 0x80) {
/* 0******* */

2007-06-12 23:04:29

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] drivers/cpuidle/governors/menu.c: make a struct static

On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc4-mm1:
>
> git-acpi.patch
>...
> git trees
>...

This patch makes the needlessly global struct menu_governor static.

Signed-off-by: Adrian Bunk <[email protected]>

---
--- linux-2.6.22-rc4-mm2/drivers/cpuidle/governors/menu.c.old 2007-06-13 00:25:03.000000000 +0200
+++ linux-2.6.22-rc4-mm2/drivers/cpuidle/governors/menu.c 2007-06-13 00:25:13.000000000 +0200
@@ -123,7 +123,7 @@
data->deepest_bm_state = i - 1;
}

-struct cpuidle_governor menu_governor = {
+static struct cpuidle_governor menu_governor = {
.name = "menu",
.scan = menu_scan_device,
.select = menu_select,

2007-06-13 08:33:45

by Jiri Slaby

[permalink] [raw]
Subject: WARNING: at drivers/usb/core/urb.c:293 usb_submit_urb() [Was: 2.6.22-rc4-mm2]

Andrew Morton napsal(a):
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/

Hi,

after plugging my camera in, I get this:
usb 1-1: new full speed USB device using uhci_hcd and address 2
usb 1-1: new device found, idVendor=07b4, idProduct=0105
usb 1-1: new device strings: Mfr=1, Product=2, SerialNumber=3
usb 1-1: Product: C765UZ
usb 1-1: Manufacturer: OLYMPUS
usb 1-1: SerialNumber: 000375531837
usb 1-1: configuration #1 chosen from 1 choice
Initializing USB Mass Storage driver...
scsi7 : SCSI emulation for USB Mass Storage devices
usbcore: registered new interface driver usb-storage
USB Mass Storage support registered.
WARNING: at /home/l/latest/xxx/drivers/usb/core/urb.c:293 usb_submit_urb()
[<c010516a>] dump_trace+0x1d8/0x207
[<c01051b3>] show_trace_log_lvl+0x1a/0x30
[<c0105db9>] show_trace+0x12/0x14
[<c0105dd1>] dump_stack+0x16/0x18
[<c0284034>] usb_submit_urb+0x1ea/0x200
[<c02857fe>] usb_sg_wait+0xba/0x14e
[<f8985098>] usb_stor_bulk_transfer_sg+0x99/0xe3 [usb_storage]
[<f89854cc>] usb_stor_Bulk_transport+0x127/0x277 [usb_storage]
[<f8985637>] usb_stor_invoke_transport+0x1b/0x2f4 [usb_storage]
[<f89848b9>] usb_stor_transparent_scsi_command+0x8/0xa [usb_storage]
[<f8986354>] usb_stor_control_thread+0x130/0x195 [usb_storage]
[<c0136d07>] kthread+0x37/0x59
[<c0104bfb>] kernel_thread_helper+0x7/0x1c
=======================





It's not usable, some threads end up in D state. Relevant part of sysrq-t:
scsi_eh_7 D 0080027D 0 23842 2 (L-TLB)
c2e52f34 00000046 45ad4b85 0080027d c2e52f1c 00000000 c3e88230 45ad46cf
0080027d c012262a c3e88230 c3e883b8 c180b980 486cfe61 0000027d c037487f
c2e52f74 00000046 d560826b 0080027a c011c00f c2cecac0 c0545080 c0545080
Call Trace:
[<c0374f8d>] wait_for_completion+0x87/0xbc
[<f898462e>] command_abort+0x58/0x74 [usb_storage]
[<c0263be3>] __scsi_try_to_abort_cmd+0x1c/0x1e
[<c0264f10>] scsi_error_handler+0x241/0x2bf
[<c0136d07>] kthread+0x37/0x59
[<c0104bfb>] kernel_thread_helper+0x7/0x1c
=======================
usb-storage D 0080027B 0 23843 2 (L-TLB)
c2f76e94 00000046 fecf46f3 0080027b c2f76e7c 00000000 00000000 fecf4091
0080027b c012262a c3e89870 c3e899f8 c180b980 018ef9cf 0000027c c1ce9c00
c2f76e60 c0125fae c0408a64 c2f76e6c c2f76e6c c1f98e40 c0545080 c0545080
Call Trace:
[<c0374f8d>] wait_for_completion+0x87/0xbc
[<c028585a>] usb_sg_wait+0x116/0x14e
[<f8985098>] usb_stor_bulk_transfer_sg+0x99/0xe3 [usb_storage]
[<f89854cc>] usb_stor_Bulk_transport+0x127/0x277 [usb_storage]
[<f8985637>] usb_stor_invoke_transport+0x1b/0x2f4 [usb_storage]
[<f89848b9>] usb_stor_transparent_scsi_command+0x8/0xa [usb_storage]
[<f8986354>] usb_stor_control_thread+0x130/0x195 [usb_storage]
[<c0136d07>] kthread+0x37/0x59
[<c0104bfb>] kernel_thread_helper+0x7/0x1c
=======================
usb-stor-scan D 0080027B 0 23844 2 (L-TLB)
c46fecbc 00000046 febe1f98 0080027b c46feca4 00000000 c46fec68 febe17da
0080027b c012262a c4345260 c43453e8 c180b980 017dd274 0000027c c43ec000
c46fec7c c01e2964 c46fec84 c02541f8 c46fecb0 c1f98e40 c0545080 c0545080
Call Trace:
[<c0374f8d>] wait_for_completion+0x87/0xbc
[<c01da63d>] blk_execute_rq+0x5a/0x94
[<c0266479>] scsi_execute+0xc3/0xd7
[<c02664f3>] scsi_execute_req+0x66/0xc4
[<c026762f>] scsi_probe_and_add_lun+0x19b/0x891
[<c0268265>] __scsi_scan_target+0xd3/0x59f
[<c02687a0>] scsi_scan_channel+0x6f/0x84
[<c0268818>] scsi_scan_host_selected+0x63/0xd5
[<c02688f5>] do_scsi_scan_host+0x6b/0x6d
[<c026897e>] scsi_scan_host+0x87/0x153
[<f8986416>] usb_stor_scan_thread+0x5d/0x17b [usb_storage]
[<c0136d07>] kthread+0x37/0x59
[<c0104bfb>] kernel_thread_helper+0x7/0x1c
=======================



Are you aware of such problems? Any other info needed?

thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E

2007-06-13 08:47:15

by Jiri Slaby

[permalink] [raw]
Subject: Re: WARNING: at drivers/usb/core/urb.c:293 usb_submit_urb() [Was: 2.6.22-rc4-mm2]

Jiri Slaby napsal(a):
> Andrew Morton napsal(a):
>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/

> after plugging my camera in, I get this:
[...]
> USB Mass Storage support registered.
> WARNING: at /home/l/latest/xxx/drivers/usb/core/urb.c:293 usb_submit_urb()
[...]
> Are you aware of such problems? Any other info needed?

Aha, you are, going to try http://lkml.org/lkml/2007/6/7/197

regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E

2007-06-13 09:36:01

by Reuben Farrelly

[permalink] [raw]
Subject: [Serial port bug?] was Re: 2.6.22-rc4-mm2

On 7/06/2007 3:03 PM, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
>
> - Basically a bugfixed version of 2.6.22-rc4-mm1. None of the subsystem
> trees were repulled, several bad patches were dropped, a few were fixed.

I've come home to find my server has locked up hard, with a panic on the screen.
This time unlike others, I was able to grab a photo of it for further analysis.

http://www.reub.net/files/kernel/ serial-crash.jpg

[Note also the .config and dmesg in the same directory]

I have had this or a very similar traceback appear about 3 or 4 times now,
including with a 2.6.21-gentoo kernel (based on mainline), so this bug may well
be present in mainline. It is not new to this -mm release.

The bug does not occur on demand, it just seems to happen every few days without
obvious warning, I haven't reported it until now as I haven't had any other
information to provide other than "some panic seems to happen with a tty_write
something-or-other".

The other possibly crucial piece of information on this is that I have one of my
serial ports set up as a serial console. The kernel boot commands for this are:

kernel /vmlinuz-2.6.22-rc4-mm2 ro real_root=/dev/md2 console=tty0
console=ttyS0,57600 panic=30

as well as this:

# SERIAL CONSOLES
s0:12345:respawn:/sbin/agetty 57600 ttyS0 vt100

in inittab.

The other serial port is connected up to my APC UPS and is set up with apcupsd.

Reuben

2007-06-14 22:17:01

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] make fs/buffer.c:cont_expand_zero() static

cont_expand_zero() can become static.

Signed-off-by: Adrian Bunk <[email protected]>

---
--- linux-2.6.22-rc4-mm2/fs/buffer.c.old 2007-06-14 01:51:08.000000000 +0200
+++ linux-2.6.22-rc4-mm2/fs/buffer.c 2007-06-14 01:51:42.000000000 +0200
@@ -2181,8 +2181,8 @@
return err;
}

-int cont_expand_zero(struct file *file, struct address_space *mapping,
- loff_t pos, loff_t *bytes)
+static int cont_expand_zero(struct file *file, struct address_space *mapping,
+ loff_t pos, loff_t *bytes)
{
struct inode *inode = mapping->host;
unsigned blocksize = 1 << inode->i_blkbits;

2007-06-14 22:17:22

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] remove nobh_{prepare,commit}_write()

nobh_{prepare,commit}_write() are no longer used.

Signed-off-by: Adrian Bunk <[email protected]>

---

fs/buffer.c | 175 ------------------------------------
include/linux/buffer_head.h | 2
2 files changed, 177 deletions(-)

--- linux-2.6.22-rc4-mm2/include/linux/buffer_head.h.old 2007-06-14 01:54:54.000000000 +0200
+++ linux-2.6.22-rc4-mm2/include/linux/buffer_head.h 2007-06-14 01:55:08.000000000 +0200
@@ -224,8 +224,6 @@
int generic_commit_write(struct file *, struct page *, unsigned, unsigned);
int block_truncate_page(struct address_space *, loff_t, get_block_t *);
int file_fsync(struct file *, struct dentry *, int);
-int nobh_prepare_write(struct page*, unsigned, unsigned, get_block_t*);
-int nobh_commit_write(struct file *, struct page *, unsigned, unsigned);
int nobh_truncate_page(struct address_space *, loff_t);
int nobh_writepage(struct page *page, get_block_t *get_block,
struct writeback_control *wbc);
--- linux-2.6.22-rc4-mm2/fs/buffer.c.old 2007-06-14 01:55:22.000000000 +0200
+++ linux-2.6.22-rc4-mm2/fs/buffer.c 2007-06-14 01:56:12.000000000 +0200
@@ -2315,181 +2315,6 @@


/*
- * nobh_prepare_write()'s prereads are special: the buffer_heads are freed
- * immediately, while under the page lock. So it needs a special end_io
- * handler which does not touch the bh after unlocking it.
- *
- * Note: unlock_buffer() sort-of does touch the bh after unlocking it, but
- * a race there is benign: unlock_buffer() only use the bh's address for
- * hashing after unlocking the buffer, so it doesn't actually touch the bh
- * itself.
- */
-static void end_buffer_read_nobh(struct buffer_head *bh, int uptodate)
-{
- if (uptodate) {
- set_buffer_uptodate(bh);
- } else {
- /* This happens, due to failed READA attempts. */
- clear_buffer_uptodate(bh);
- }
- unlock_buffer(bh);
-}
-
-/*
- * On entry, the page is fully not uptodate.
- * On exit the page is fully uptodate in the areas outside (from,to)
- */
-int nobh_prepare_write(struct page *page, unsigned from, unsigned to,
- get_block_t *get_block)
-{
- struct inode *inode = page->mapping->host;
- const unsigned blkbits = inode->i_blkbits;
- const unsigned blocksize = 1 << blkbits;
- struct buffer_head map_bh;
- struct buffer_head *read_bh[MAX_BUF_PER_PAGE];
- unsigned block_in_page;
- unsigned block_start;
- sector_t block_in_file;
- char *kaddr;
- int nr_reads = 0;
- int i;
- int ret = 0;
- int is_mapped_to_disk = 1;
-
- if (PageMappedToDisk(page))
- return 0;
-
- block_in_file = (sector_t)page->index << (PAGE_CACHE_SHIFT - blkbits);
- map_bh.b_page = page;
-
- /*
- * We loop across all blocks in the page, whether or not they are
- * part of the affected region. This is so we can discover if the
- * page is fully mapped-to-disk.
- */
- for (block_start = 0, block_in_page = 0;
- block_start < PAGE_CACHE_SIZE;
- block_in_page++, block_start += blocksize) {
- unsigned block_end = block_start + blocksize;
- int create;
-
- map_bh.b_state = 0;
- create = 1;
- if (block_start >= to)
- create = 0;
- map_bh.b_size = blocksize;
- ret = get_block(inode, block_in_file + block_in_page,
- &map_bh, create);
- if (ret)
- goto failed;
- if (!buffer_mapped(&map_bh))
- is_mapped_to_disk = 0;
- if (buffer_new(&map_bh))
- unmap_underlying_metadata(map_bh.b_bdev,
- map_bh.b_blocknr);
- if (PageUptodate(page))
- continue;
- if (buffer_new(&map_bh) || !buffer_mapped(&map_bh)) {
- kaddr = kmap_atomic(page, KM_USER0);
- if (block_start < from)
- memset(kaddr+block_start, 0, from-block_start);
- if (block_end > to)
- memset(kaddr + to, 0, block_end - to);
- flush_dcache_page(page);
- kunmap_atomic(kaddr, KM_USER0);
- continue;
- }
- if (buffer_uptodate(&map_bh))
- continue; /* reiserfs does this */
- if (block_start < from || block_end > to) {
- struct buffer_head *bh = alloc_buffer_head(GFP_NOFS);
-
- if (!bh) {
- ret = -ENOMEM;
- goto failed;
- }
- bh->b_state = map_bh.b_state;
- atomic_set(&bh->b_count, 0);
- bh->b_this_page = NULL;
- bh->b_page = page;
- bh->b_blocknr = map_bh.b_blocknr;
- bh->b_size = blocksize;
- bh->b_data = (char *)(long)block_start;
- bh->b_bdev = map_bh.b_bdev;
- bh->b_private = NULL;
- read_bh[nr_reads++] = bh;
- }
- }
-
- if (nr_reads) {
- struct buffer_head *bh;
-
- /*
- * The page is locked, so these buffers are protected from
- * any VM or truncate activity. Hence we don't need to care
- * for the buffer_head refcounts.
- */
- for (i = 0; i < nr_reads; i++) {
- bh = read_bh[i];
- lock_buffer(bh);
- bh->b_end_io = end_buffer_read_nobh;
- submit_bh(READ, bh);
- }
- for (i = 0; i < nr_reads; i++) {
- bh = read_bh[i];
- wait_on_buffer(bh);
- if (!buffer_uptodate(bh))
- ret = -EIO;
- free_buffer_head(bh);
- read_bh[i] = NULL;
- }
- if (ret)
- goto failed;
- }
-
- if (is_mapped_to_disk)
- SetPageMappedToDisk(page);
-
- return 0;
-
-failed:
- for (i = 0; i < nr_reads; i++) {
- if (read_bh[i])
- free_buffer_head(read_bh[i]);
- }
-
- /*
- * Error recovery is pretty slack. Clear the page and mark it dirty
- * so we'll later zero out any blocks which _were_ allocated.
- */
- zero_user_page(page, 0, PAGE_CACHE_SIZE, KM_USER0);
- SetPageUptodate(page);
- set_page_dirty(page);
- return ret;
-}
-EXPORT_SYMBOL(nobh_prepare_write);
-
-/*
- * Make sure any changes to nobh_commit_write() are reflected in
- * nobh_truncate_page(), since it doesn't call commit_write().
- */
-int nobh_commit_write(struct file *file, struct page *page,
- unsigned from, unsigned to)
-{
- struct inode *inode = page->mapping->host;
- loff_t pos = ((loff_t)page->index << PAGE_CACHE_SHIFT) + to;
-
- SetPageUptodate(page);
- set_page_dirty(page);
- if (pos > inode->i_size) {
- i_size_write(inode, pos);
- mark_inode_dirty(inode);
- }
- return 0;
-}
-EXPORT_SYMBOL(nobh_commit_write);
-
-/*
* nobh_writepage() - based on block_full_write_page() except
* that it tries to operate without attaching bufferheads to
* the page.

2007-06-14 22:17:42

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] make fs/inode.c:wake_up_inode() static

wake_up_inode() can become static.

Signed-off-by: Adrian Bunk <[email protected]>

---

fs/inode.c | 18 +++++++++---------
include/linux/writeback.h | 1 -
2 files changed, 9 insertions(+), 10 deletions(-)

--- linux-2.6.22-rc4-mm2/include/linux/writeback.h.old 2007-06-14 02:00:29.000000000 +0200
+++ linux-2.6.22-rc4-mm2/include/linux/writeback.h 2007-06-14 02:00:34.000000000 +0200
@@ -69,7 +69,6 @@
* fs/fs-writeback.c
*/
int writeback_inodes(struct writeback_control *wbc);
-void wake_up_inode(struct inode *inode);
int inode_wait(void *);
int sync_inodes_sb(struct super_block *, int wait);
int sync_inodes(int wait);
--- linux-2.6.22-rc4-mm2/fs/inode.c.old 2007-06-14 02:00:40.000000000 +0200
+++ linux-2.6.22-rc4-mm2/fs/inode.c 2007-06-14 02:02:25.000000000 +0200
@@ -99,6 +99,15 @@

static struct kmem_cache * inode_cachep __read_mostly;

+static void wake_up_inode(struct inode *inode)
+{
+ /*
+ * Prevent speculative execution through spin_unlock(&inode_lock);
+ */
+ smp_mb();
+ wake_up_bit(&inode->i_state, __I_LOCK);
+}
+
static struct inode *alloc_inode(struct super_block *sb)
{
static const struct address_space_operations empty_aops;
@@ -1296,15 +1305,6 @@
spin_lock(&inode_lock);
}

-void wake_up_inode(struct inode *inode)
-{
- /*
- * Prevent speculative execution through spin_unlock(&inode_lock);
- */
- smp_mb();
- wake_up_bit(&inode->i_state, __I_LOCK);
-}
-
/*
* We rarely want to lock two inodes that do not have a parent/child
* relationship (such as directory, child inode) simultaneously. The

2007-06-14 22:17:59

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] make fs/libfs.c:simple_commit_write() static

simple_commit_write() can now become static.

Signed-off-by: Adrian Bunk <[email protected]>

---

fs/libfs.c | 5 ++---
include/linux/fs.h | 2 --
2 files changed, 2 insertions(+), 5 deletions(-)

--- linux-2.6.22-rc4-mm2/include/linux/fs.h.old 2007-06-14 02:05:36.000000000 +0200
+++ linux-2.6.22-rc4-mm2/include/linux/fs.h 2007-06-14 02:05:43.000000000 +0200
@@ -1973,8 +1973,6 @@
extern int simple_readpage(struct file *file, struct page *page);
extern int simple_prepare_write(struct file *file, struct page *page,
unsigned offset, unsigned to);
-extern int simple_commit_write(struct file *file, struct page *page,
- unsigned offset, unsigned to);
extern int simple_write_begin(struct file *file, struct address_space *mapping,
loff_t pos, unsigned len, unsigned flags,
struct page **pagep, void **fsdata);
--- linux-2.6.22-rc4-mm2/fs/libfs.c.old 2007-06-14 02:05:50.000000000 +0200
+++ linux-2.6.22-rc4-mm2/fs/libfs.c 2007-06-14 02:06:16.000000000 +0200
@@ -371,8 +371,8 @@
return simple_prepare_write(file, page, from, from+len);
}

-int simple_commit_write(struct file *file, struct page *page,
- unsigned from, unsigned to)
+static int simple_commit_write(struct file *file, struct page *page,
+ unsigned from, unsigned to)
{
struct inode *inode = page->mapping->host;
loff_t pos = ((loff_t)page->index << PAGE_CACHE_SHIFT) + to;
@@ -686,7 +686,6 @@
EXPORT_SYMBOL(get_sb_pseudo);
EXPORT_SYMBOL(simple_write_begin);
EXPORT_SYMBOL(simple_write_end);
-EXPORT_SYMBOL(simple_commit_write);
EXPORT_SYMBOL(simple_dir_inode_operations);
EXPORT_SYMBOL(simple_dir_operations);
EXPORT_SYMBOL(simple_empty);

2007-06-14 22:18:27

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] fs/reiserfs/: cleanups

This patch contains the following cleanups:
- remove the following no longer used functions:
- bitmap.c: reiserfs_claim_blocks_to_be_allocated()
- bitmap.c: reiserfs_release_claimed_blocks()
- bitmap.c: reiserfs_can_fit_pages()
- make the following functions static:
- inode.c: restart_transaction()
- journal.c: reiserfs_async_progress_wait()

Signed-off-by: Adrian Bunk <[email protected]>

---

fs/reiserfs/bitmap.c | 57 ------------------------------------
fs/reiserfs/inode.c | 4 +-
fs/reiserfs/journal.c | 3 +
include/linux/reiserfs_fs.h | 7 ----
4 files changed, 4 insertions(+), 67 deletions(-)

--- linux-2.6.22-rc4-mm2/include/linux/reiserfs_fs.h.old 2007-06-14 02:08:17.000000000 +0200
+++ linux-2.6.22-rc4-mm2/include/linux/reiserfs_fs.h 2007-06-14 02:11:20.000000000 +0200
@@ -1701,8 +1701,6 @@
return th->t_blocks_allocated - th->t_blocks_logged;
}

-int reiserfs_async_progress_wait(struct super_block *s);
-
struct reiserfs_transaction_handle *reiserfs_persistent_transaction(struct
super_block
*,
@@ -1857,8 +1855,6 @@
#define GET_BLOCK_NO_IMUX 8 /* i_mutex is not held, don't preallocate */
#define GET_BLOCK_NO_DANGLE 16 /* don't leave any transactions running */

-int restart_transaction(struct reiserfs_transaction_handle *th,
- struct inode *inode, struct treepath *path);
void reiserfs_read_locked_inode(struct inode *inode,
struct reiserfs_iget_args *args);
int reiserfs_find_actor(struct inode *inode, void *p);
@@ -2135,9 +2131,6 @@
struct inode *inode);
void reiserfs_discard_all_prealloc(struct reiserfs_transaction_handle *th);
#endif
-void reiserfs_claim_blocks_to_be_allocated(struct super_block *sb, int blocks);
-void reiserfs_release_claimed_blocks(struct super_block *sb, int blocks);
-int reiserfs_can_fit_pages(struct super_block *sb);

/* hashes.c */
__u32 keyed_hash(const signed char *msg, int len);
--- linux-2.6.22-rc4-mm2/fs/reiserfs/bitmap.c.old 2007-06-14 02:08:45.000000000 +0200
+++ linux-2.6.22-rc4-mm2/fs/reiserfs/bitmap.c 2007-06-14 02:09:59.000000000 +0200
@@ -1201,63 +1201,6 @@
return ret;
}

-/* These 2 functions are here to provide blocks reservation to the rest of kernel */
-/* Reserve @blocks amount of blocks in fs pointed by @sb. Caller must make sure
- there are actually this much blocks on the FS available */
-void reiserfs_claim_blocks_to_be_allocated(struct super_block *sb, /* super block of
- filesystem where
- blocks should be
- reserved */
- int blocks /* How much to reserve */
- )
-{
-
- /* Fast case, if reservation is zero - exit immediately. */
- if (!blocks)
- return;
-
- spin_lock(&REISERFS_SB(sb)->bitmap_lock);
- REISERFS_SB(sb)->reserved_blocks += blocks;
- spin_unlock(&REISERFS_SB(sb)->bitmap_lock);
-}
-
-/* Unreserve @blocks amount of blocks in fs pointed by @sb */
-void reiserfs_release_claimed_blocks(struct super_block *sb, /* super block of
- filesystem where
- blocks should be
- reserved */
- int blocks /* How much to unreserve */
- )
-{
-
- /* Fast case, if unreservation is zero - exit immediately. */
- if (!blocks)
- return;
-
- spin_lock(&REISERFS_SB(sb)->bitmap_lock);
- REISERFS_SB(sb)->reserved_blocks -= blocks;
- spin_unlock(&REISERFS_SB(sb)->bitmap_lock);
- RFALSE(REISERFS_SB(sb)->reserved_blocks < 0,
- "amount of blocks reserved became zero?");
-}
-
-/* This function estimates how much pages we will be able to write to FS
- used for reiserfs_file_write() purposes for now. */
-int reiserfs_can_fit_pages(struct super_block *sb /* superblock of filesystem
- to estimate space */ )
-{
- int space;
-
- spin_lock(&REISERFS_SB(sb)->bitmap_lock);
- space =
- (SB_FREE_BLOCKS(sb) -
- REISERFS_SB(sb)->reserved_blocks) >> (PAGE_CACHE_SHIFT -
- sb->s_blocksize_bits);
- spin_unlock(&REISERFS_SB(sb)->bitmap_lock);
-
- return space > 0 ? space : 0;
-}
-
void reiserfs_cache_bitmap_metadata(struct super_block *sb,
struct buffer_head *bh,
struct reiserfs_bitmap_info *info)
--- linux-2.6.22-rc4-mm2/fs/reiserfs/inode.c.old 2007-06-14 02:10:35.000000000 +0200
+++ linux-2.6.22-rc4-mm2/fs/reiserfs/inode.c 2007-06-14 02:10:59.000000000 +0200
@@ -208,8 +208,8 @@
return 0;
}

-/*static*/ int restart_transaction(struct reiserfs_transaction_handle *th,
- struct inode *inode, struct treepath *path)
+static int restart_transaction(struct reiserfs_transaction_handle *th,
+ struct inode *inode, struct treepath *path)
{
struct super_block *s = th->t_super;
int len = th->t_blocks_allocated;
--- linux-2.6.22-rc4-mm2/fs/reiserfs/journal.c.old 2007-06-14 02:11:29.000000000 +0200
+++ linux-2.6.22-rc4-mm2/fs/reiserfs/journal.c 2007-06-14 02:11:40.000000000 +0200
@@ -966,7 +966,8 @@
}
return 0;
}
-int reiserfs_async_progress_wait(struct super_block *s)
+
+static int reiserfs_async_progress_wait(struct super_block *s)
{
DEFINE_WAIT(wait);
struct reiserfs_journal *j = SB_JOURNAL(s);

2007-06-14 22:18:44

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] make init/do_mounts.c:root_wait static

root_wait can become static.

Signed-off-by: Adrian Bunk <[email protected]>

---
--- linux-2.6.22-rc4-mm2/init/do_mounts.c.old 2007-06-14 02:19:22.000000000 +0200
+++ linux-2.6.22-rc4-mm2/init/do_mounts.c 2007-06-14 02:19:47.000000000 +0200
@@ -25,7 +25,7 @@
int root_mountflags = MS_RDONLY | MS_SILENT;
char * __initdata root_device_name;
static char __initdata saved_root_name[64];
-int __initdata root_wait;
+static int __initdata root_wait;

dev_t ROOT_DEV;


2007-06-14 22:19:03

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] drivers/ide/ide-dma.c: unexport ide_set_dma

ide_set_dma no longer has any modular user.

Signed-off-by: Adrian Bunk <[email protected]>

---
--- linux-2.6.22-rc4-mm2/drivers/ide/ide-dma.c.old 2007-06-14 23:52:30.000000000 +0200
+++ linux-2.6.22-rc4-mm2/drivers/ide/ide-dma.c 2007-06-14 23:52:38.000000000 +0200
@@ -847,8 +847,6 @@
return rc;
}

-EXPORT_SYMBOL_GPL(ide_set_dma);
-
#ifdef CONFIG_BLK_DEV_IDEDMA_PCI
void ide_dma_lost_irq (ide_drive_t *drive)
{

2007-06-14 22:47:49

by Jeremy Fitzhardinge

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2 - usb-storage

Peter Zijlstra wrote:
> My kernel went chatty when I tried to access my usb-stick; which it
> didn't seem to find.
>
>
> Initializing USB Mass Storage driver...
> scsi6 : SCSI emulation for USB Mass Storage devices
> usb-storage: device found at 2
> usb-storage: waiting for device to settle before scanning
> scsi7 : SCSI emulation for USB Mass Storage devices
> usb-storage: device found at 5
> usb-storage: waiting for device to settle before scanning
> usbcore: registered new interface driver usb-storage
> USB Mass Storage support registered.
> usb-storage: device scan complete
> WARNING: at /usr/src/linux-2.6/drivers/usb/core/urb.c:293
> usb_submit_urb()
>
> Call Trace:
> [<ffffffff8020d4c7>] show_trace+0x34/0x4f
> [<ffffffff8020d4f4>] dump_stack+0x12/0x17
> [<ffffffff803cac6a>] usb_submit_urb+0x9f/0x226
> [<ffffffff803cc4c7>] usb_sg_wait+0x56/0x132
> [<ffffffff8820519d>] :usb_storage:usb_stor_bulk_transfer_sg+0x9d/0xf3
> [<ffffffff88205313>] :usb_storage:usb_stor_Bulk_transport+0x120/0x244
> [<ffffffff8820577f>] :usb_storage:usb_stor_invoke_transport+0x25/0x2d2
> [<ffffffff882066c0>] :usb_storage:usb_stor_control_thread+0x14b/0x1e7
> [<ffffffff8024a7df>] kthread+0x47/0x74
> [<ffffffff8020cc28>] child_rip+0xa/0x12
>
> usb-storage: device scan complete
> WARNING: at /usr/src/linux-2.6/drivers/usb/core/urb.c:293
> usb_submit_urb()
>
> Call Trace:
> [<ffffffff8020d4c7>] show_trace+0x34/0x4f
> [<ffffffff8020d4f4>] dump_stack+0x12/0x17
> [<ffffffff803cac6a>] usb_submit_urb+0x9f/0x226
> [<ffffffff803cc4c7>] usb_sg_wait+0x56/0x132
> [<ffffffff8820519d>] :usb_storage:usb_stor_bulk_transfer_sg+0x9d/0xf3
> [<ffffffff88205313>] :usb_storage:usb_stor_Bulk_transport+0x120/0x244
> [<ffffffff8820577f>] :usb_storage:usb_stor_invoke_transport+0x25/0x2d2
> [<ffffffff882066c0>] :usb_storage:usb_stor_control_thread+0x14b/0x1e7
> [<ffffffff8024a7df>] kthread+0x47/0x74
> [<ffffffff8020cc28>] child_rip+0xa/0x12
>

I got the same thing when I plugged my PSP in.

WARNING: at /home/jeremy/hg/xen/paravirt/linux/drivers/usb/core/urb.c:293 usb_submit_urb()
[<c01091e2>] show_trace_log_lvl+0x1a/0x2f
[<c0109cf2>] show_trace+0x12/0x14
[<c0109d0a>] dump_stack+0x16/0x18
[<c02dcaae>] usb_submit_urb+0x9f/0x205
[<c02de178>] usb_sg_wait+0x4c/0x11c
[<f8ddbfcd>] usb_stor_bulk_transfer_sg+0x8c/0xea [usb_storage]
[<f8ddc433>] usb_stor_Bulk_transport+0x136/0x249 [usb_storage]
[<f8ddc561>] usb_stor_invoke_transport+0x1b/0x292 [usb_storage]
[<f8ddb82e>] usb_stor_ATAPI_command+0x24/0x26 [usb_storage]
[<f8ddd310>] usb_stor_control_thread+0x129/0x1aa [usb_storage]
[<c013cd87>] kthread+0x3b/0x64
[<c0108da7>] kernel_thread_helper+0x7/0x10
=======================

After this the USB subsystem seems dead. For example, lsusb hangs in:

lsusb D 0000017B 6304 6964 6507 (NOTLB)
d8503ed4 00000082 199b6067 0000017b d8503ebc 00000000 22222222 d8502000
00000000 0000017b 00000000 c0127f83 d1cbcc90 d1cbce3c c2c09a40 da04cc45
00000960 00000046 00000001 c037d5f6 d716a1d4 d716a1c0 00266bc9 00000046
Call Trace:
[<c037d665>] __down+0xab/0xbf
[<c037d432>] __down_failed+0xa/0x10
[<c02e4611>] usbdev_read+0x5a/0x1f7
[<c017d517>] vfs_read+0xad/0x136
[<c017d94a>] sys_read+0x3d/0x61
[<c0108046>] sysenter_past_esp+0x6b/0xb5



Thanks,
J

2007-06-14 22:58:47

by Peter Zijlstra

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2 - usb-storage

On Thu, 2007-06-14 at 15:47 -0700, Jeremy Fitzhardinge wrote:

> I got the same thing when I plugged my PSP in.

> After this the USB subsystem seems dead. For example, lsusb hangs in:

Like Alan said, reverting this one fixes it:

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/broken-out/usb-try-to-debug-bug-8561.patch


2007-06-14 23:21:10

by Jeremy Fitzhardinge

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2 - usb-storage

Peter Zijlstra wrote:
> Like Alan said, reverting this one fixes it:
>
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/broken-out/usb-try-to-debug-bug-8561.patch
>

Yep. My mailreader was hiding the followups for some reason, but it
couldn't fool me for long.

Thanks,
J

2007-06-15 01:36:40

by Nick Piggin

[permalink] [raw]
Subject: Re: [-mm patch] make fs/buffer.c:cont_expand_zero() static

Hi Adrian,

Thanks for doing these, but can we hold them off for now?

Thanks,
Nick


On Fri, Jun 15, 2007 at 12:15:45AM +0200, Adrian Bunk wrote:
> cont_expand_zero() can become static.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
> --- linux-2.6.22-rc4-mm2/fs/buffer.c.old 2007-06-14 01:51:08.000000000 +0200
> +++ linux-2.6.22-rc4-mm2/fs/buffer.c 2007-06-14 01:51:42.000000000 +0200
> @@ -2181,8 +2181,8 @@
> return err;
> }
>
> -int cont_expand_zero(struct file *file, struct address_space *mapping,
> - loff_t pos, loff_t *bytes)
> +static int cont_expand_zero(struct file *file, struct address_space *mapping,
> + loff_t pos, loff_t *bytes)
> {
> struct inode *inode = mapping->host;
> unsigned blocksize = 1 << inode->i_blkbits;

2007-06-15 01:38:10

by Nick Piggin

[permalink] [raw]
Subject: Re: [-mm patch] fs/reiserfs/: cleanups

On Fri, Jun 15, 2007 at 12:16:28AM +0200, Adrian Bunk wrote:
> This patch contains the following cleanups:
> - remove the following no longer used functions:
> - bitmap.c: reiserfs_claim_blocks_to_be_allocated()
> - bitmap.c: reiserfs_release_claimed_blocks()
> - bitmap.c: reiserfs_can_fit_pages()
> - make the following functions static:
> - inode.c: restart_transaction()
> - journal.c: reiserfs_async_progress_wait()

If Vladimir acks this one then it's obviously fine by me.


> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
>
> fs/reiserfs/bitmap.c | 57 ------------------------------------
> fs/reiserfs/inode.c | 4 +-
> fs/reiserfs/journal.c | 3 +
> include/linux/reiserfs_fs.h | 7 ----
> 4 files changed, 4 insertions(+), 67 deletions(-)
>
> --- linux-2.6.22-rc4-mm2/include/linux/reiserfs_fs.h.old 2007-06-14 02:08:17.000000000 +0200
> +++ linux-2.6.22-rc4-mm2/include/linux/reiserfs_fs.h 2007-06-14 02:11:20.000000000 +0200
> @@ -1701,8 +1701,6 @@
> return th->t_blocks_allocated - th->t_blocks_logged;
> }
>
> -int reiserfs_async_progress_wait(struct super_block *s);
> -
> struct reiserfs_transaction_handle *reiserfs_persistent_transaction(struct
> super_block
> *,
> @@ -1857,8 +1855,6 @@
> #define GET_BLOCK_NO_IMUX 8 /* i_mutex is not held, don't preallocate */
> #define GET_BLOCK_NO_DANGLE 16 /* don't leave any transactions running */
>
> -int restart_transaction(struct reiserfs_transaction_handle *th,
> - struct inode *inode, struct treepath *path);
> void reiserfs_read_locked_inode(struct inode *inode,
> struct reiserfs_iget_args *args);
> int reiserfs_find_actor(struct inode *inode, void *p);
> @@ -2135,9 +2131,6 @@
> struct inode *inode);
> void reiserfs_discard_all_prealloc(struct reiserfs_transaction_handle *th);
> #endif
> -void reiserfs_claim_blocks_to_be_allocated(struct super_block *sb, int blocks);
> -void reiserfs_release_claimed_blocks(struct super_block *sb, int blocks);
> -int reiserfs_can_fit_pages(struct super_block *sb);
>
> /* hashes.c */
> __u32 keyed_hash(const signed char *msg, int len);
> --- linux-2.6.22-rc4-mm2/fs/reiserfs/bitmap.c.old 2007-06-14 02:08:45.000000000 +0200
> +++ linux-2.6.22-rc4-mm2/fs/reiserfs/bitmap.c 2007-06-14 02:09:59.000000000 +0200
> @@ -1201,63 +1201,6 @@
> return ret;
> }
>
> -/* These 2 functions are here to provide blocks reservation to the rest of kernel */
> -/* Reserve @blocks amount of blocks in fs pointed by @sb. Caller must make sure
> - there are actually this much blocks on the FS available */
> -void reiserfs_claim_blocks_to_be_allocated(struct super_block *sb, /* super block of
> - filesystem where
> - blocks should be
> - reserved */
> - int blocks /* How much to reserve */
> - )
> -{
> -
> - /* Fast case, if reservation is zero - exit immediately. */
> - if (!blocks)
> - return;
> -
> - spin_lock(&REISERFS_SB(sb)->bitmap_lock);
> - REISERFS_SB(sb)->reserved_blocks += blocks;
> - spin_unlock(&REISERFS_SB(sb)->bitmap_lock);
> -}
> -
> -/* Unreserve @blocks amount of blocks in fs pointed by @sb */
> -void reiserfs_release_claimed_blocks(struct super_block *sb, /* super block of
> - filesystem where
> - blocks should be
> - reserved */
> - int blocks /* How much to unreserve */
> - )
> -{
> -
> - /* Fast case, if unreservation is zero - exit immediately. */
> - if (!blocks)
> - return;
> -
> - spin_lock(&REISERFS_SB(sb)->bitmap_lock);
> - REISERFS_SB(sb)->reserved_blocks -= blocks;
> - spin_unlock(&REISERFS_SB(sb)->bitmap_lock);
> - RFALSE(REISERFS_SB(sb)->reserved_blocks < 0,
> - "amount of blocks reserved became zero?");
> -}
> -
> -/* This function estimates how much pages we will be able to write to FS
> - used for reiserfs_file_write() purposes for now. */
> -int reiserfs_can_fit_pages(struct super_block *sb /* superblock of filesystem
> - to estimate space */ )
> -{
> - int space;
> -
> - spin_lock(&REISERFS_SB(sb)->bitmap_lock);
> - space =
> - (SB_FREE_BLOCKS(sb) -
> - REISERFS_SB(sb)->reserved_blocks) >> (PAGE_CACHE_SHIFT -
> - sb->s_blocksize_bits);
> - spin_unlock(&REISERFS_SB(sb)->bitmap_lock);
> -
> - return space > 0 ? space : 0;
> -}
> -
> void reiserfs_cache_bitmap_metadata(struct super_block *sb,
> struct buffer_head *bh,
> struct reiserfs_bitmap_info *info)
> --- linux-2.6.22-rc4-mm2/fs/reiserfs/inode.c.old 2007-06-14 02:10:35.000000000 +0200
> +++ linux-2.6.22-rc4-mm2/fs/reiserfs/inode.c 2007-06-14 02:10:59.000000000 +0200
> @@ -208,8 +208,8 @@
> return 0;
> }
>
> -/*static*/ int restart_transaction(struct reiserfs_transaction_handle *th,
> - struct inode *inode, struct treepath *path)
> +static int restart_transaction(struct reiserfs_transaction_handle *th,
> + struct inode *inode, struct treepath *path)
> {
> struct super_block *s = th->t_super;
> int len = th->t_blocks_allocated;
> --- linux-2.6.22-rc4-mm2/fs/reiserfs/journal.c.old 2007-06-14 02:11:29.000000000 +0200
> +++ linux-2.6.22-rc4-mm2/fs/reiserfs/journal.c 2007-06-14 02:11:40.000000000 +0200
> @@ -966,7 +966,8 @@
> }
> return 0;
> }
> -int reiserfs_async_progress_wait(struct super_block *s)
> +
> +static int reiserfs_async_progress_wait(struct super_block *s)
> {
> DEFINE_WAIT(wait);
> struct reiserfs_journal *j = SB_JOURNAL(s);

Subject: Re: [-mm patch] drivers/ide/ide-dma.c: unexport ide_set_dma

On Friday 15 June 2007, Adrian Bunk wrote:
> ide_set_dma no longer has any modular user.
>
> Signed-off-by: Adrian Bunk <[email protected]>

applied

2007-06-17 23:43:31

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] arch/i386/video/fbdev.c should #include <asm/fb.h>

Every file should include the headers containing the prototypes for
it's global functions.

Signed-off-by: Adrian Bunk <[email protected]>

---
--- linux-2.6.22-rc4-mm2/arch/i386/video/fbdev.c.old 2007-06-17 15:48:25.000000000 +0200
+++ linux-2.6.22-rc4-mm2/arch/i386/video/fbdev.c 2007-06-17 15:48:53.000000000 +0200
@@ -11,6 +11,8 @@
#include <linux/fb.h>
#include <linux/pci.h>

+#include <asm/fb.h>
+
int fb_is_primary_device(struct fb_info *info)
{
struct device *device = info->device;

2007-06-18 04:51:48

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [-mm patch] arch/i386/video/fbdev.c should #include <asm/fb.h>

On Mon, Jun 18, 2007 at 01:42:57AM +0200, Adrian Bunk wrote:
> Every file should include the headers containing the prototypes for
> it's global functions.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
> --- linux-2.6.22-rc4-mm2/arch/i386/video/fbdev.c.old 2007-06-17 15:48:25.000000000 +0200
> +++ linux-2.6.22-rc4-mm2/arch/i386/video/fbdev.c 2007-06-17 15:48:53.000000000 +0200
> @@ -11,6 +11,8 @@
> #include <linux/fb.h>
> #include <linux/pci.h>
>
> +#include <asm/fb.h>
> +

1) Why not include asm/fb.h from linux/fb.h?
2) Is asm/fb.h an -mm thing? I do not have it in my linus tree.

Note: Ketchup is broken on my ubuntu box so no -mm right now.

Sam

2007-06-19 13:54:18

by J.A. Magallón

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Wed, 6 Jun 2007 22:03:13 -0700, Andrew Morton <[email protected]> wrote:

>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
>
> - Basically a bugfixed version of 2.6.22-rc4-mm1. None of the subsystem
> trees were repulled, several bad patches were dropped, a few were fixed.
>

I get this warning when I plug a USB stick:

Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new high speed USB device using ehci_hcd and address 4
Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new device found, idVendor=090c, idProduct=1000
Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new device strings: Mfr=1, Product=2, SerialNumber=3
Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: Product: USBDrive
Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: Manufacturer: LG
Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: SerialNumber: AA04012700012034
Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: configuration #1 chosen from 1 choice
Jun 19 15:50:53 werewolf-wl kernel: scsi7 : SCSI emulation for USB Mass Storage devices
Jun 19 15:50:53 werewolf-wl kernel: usb-storage: device found at 4
Jun 19 15:50:53 werewolf-wl kernel: usb-storage: waiting for device to settle before scanning
Jun 19 15:50:58 werewolf-wl kernel: WARNING: at drivers/usb/core/urb.c:293 usb_submit_urb()
Jun 19 15:50:58 werewolf-wl kernel: [usb_submit_urb+491/513] usb_submit_urb+0x1eb/0x201
Jun 19 15:50:58 werewolf-wl kernel: [<c02724be>] usb_submit_urb+0x1eb/0x201
Jun 19 15:50:58 werewolf-wl kernel: [usb_sg_init+580/609] usb_sg_init+0x244/0x261
Jun 19 15:50:58 werewolf-wl kernel: [<c027408b>] usb_sg_init+0x244/0x261
Jun 19 15:50:58 werewolf-wl kernel: [usb_sg_wait+175/326] usb_sg_wait+0xaf/0x146
Jun 19 15:50:58 werewolf-wl kernel: [<c0273c12>] usb_sg_wait+0xaf/0x146
Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_bulk_transfer_sg+149/220] usb_stor_bulk_transfer_sg+0x95/0xdc
Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_bulk_transfer_buf+71/114] usb_stor_bulk_transfer_buf+0x47/0x72
Jun 19 15:50:58 werewolf-wl kernel: [<c0285afe>] usb_stor_bulk_transfer_buf+0x47/0x72
Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_Bulk_transport+293/617] usb_stor_Bulk_transport+0x125/0x269
Jun 19 15:50:58 werewolf-wl kernel: [<c02860a9>] usb_stor_Bulk_transport+0x125/0x269
Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_control_thread+0/425] usb_stor_control_thread+0x0/0x1a9
Jun 19 15:50:58 werewolf-wl kernel: [<c0286d5f>] usb_stor_control_thread+0x0/0x1a9
Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_invoke_transport+21/659] usb_stor_invoke_transport+0x15/0x293
Jun 19 15:50:58 werewolf-wl kernel: [<c0286202>] usb_stor_invoke_transport+0x15/0x293
Jun 19 15:50:58 werewolf-wl kernel: [__wake_up_locked+31/33] __wake_up_locked+0x1f/0x21
Jun 19 15:50:58 werewolf-wl kernel: [<c0113a23>] __wake_up_locked+0x1f/0x21
Jun 19 15:50:58 werewolf-wl kernel: [__down_interruptible+236/270] __down_interruptible+0xec/0x10e
Jun 19 15:50:58 werewolf-wl kernel: [<c02f682a>] __down_interruptible+0xec/0x10e
Jun 19 15:50:58 werewolf-wl kernel: [default_wake_function+0/12] default_wake_function+0x0/0xc
Jun 19 15:50:58 werewolf-wl kernel: [<c0116d65>] default_wake_function+0x0/0xc
Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_control_thread+0/425] usb_stor_control_thread+0x0/0x1a9
Jun 19 15:50:58 werewolf-wl kernel: [<c0286d5f>] usb_stor_control_thread+0x0/0x1a9
Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_control_thread+0/425] usb_stor_control_thread+0x0/0x1a9
Jun 19 15:50:58 werewolf-wl kernel: [<c0286d5f>] usb_stor_control_thread+0x0/0x1a9
Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_control_thread+315/425] usb_stor_control_thread+0x13b/0x1a9
Jun 19 15:50:58 werewolf-wl kernel: [<c0286e9a>] usb_stor_control_thread+0x13b/0x1a9
Jun 19 15:50:58 werewolf-wl kernel: [kthread+0/86] kthread+0x0/0x56
Jun 19 15:50:58 werewolf-wl kernel: [<c012de72>] kthread+0x0/0x56
Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_control_thread+0/425] usb_stor_control_thread+0x0/0x1a9
Jun 19 15:50:58 werewolf-wl kernel: [<c0286d5f>] usb_stor_control_thread+0x0/0x1a9
Jun 19 15:50:58 werewolf-wl kernel: [kthread+52/86] kthread+0x34/0x56
Jun 19 15:50:58 werewolf-wl kernel: [<c012dea6>] kthread+0x34/0x56
Jun 19 15:50:58 werewolf-wl kernel: [kthread+0/86] kthread+0x0/0x56
Jun 19 15:50:58 werewolf-wl kernel: [<c012de72>] kthread+0x0/0x56
Jun 19 15:50:58 werewolf-wl kernel: [kernel_thread_helper+7/20] kernel_thread_helper+0x7/0x14
Jun 19 15:50:58 werewolf-wl kernel: [<c01033e3>] kernel_thread_helper+0x7/0x14
Jun 19 15:50:58 werewolf-wl kernel: =======================

--
J.A. Magallon <jamagallon()ono!com> \ Software is like sex:
\ It's better when it's free
Mandriva Linux release 2008.0 (Cooker) for i586
Linux 2.6.21-jam07 (gcc 4.1.2 20070302 (4.1.2-1mdv2007.1)) SMP PREEMPT
09 F9 11 02 9D 74 E3 5B D8 41 56 C5 63 56 88 C0

2007-06-19 14:34:19

by J.A. Magallón

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Tue, 19 Jun 2007 15:53:57 +0200, "J.A. Magallón" <[email protected]> wrote:

> On Wed, 6 Jun 2007 22:03:13 -0700, Andrew Morton <[email protected]> wrote:
>
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
> >
> > - Basically a bugfixed version of 2.6.22-rc4-mm1. None of the subsystem
> > trees were repulled, several bad patches were dropped, a few were fixed.
> >
>
> I get this warning when I plug a USB stick:
>

Oops, forgot to say that this is not plain -rc4-mm2, but with CFS scheduler v17.
CC'ing Ingo for if it is related...

> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new high speed USB device using ehci_hcd and address 4
> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new device found, idVendor=090c, idProduct=1000
> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new device strings: Mfr=1, Product=2, SerialNumber=3
> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: Product: USBDrive
> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: Manufacturer: LG
> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: SerialNumber: AA04012700012034
> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: configuration #1 chosen from 1 choice
> Jun 19 15:50:53 werewolf-wl kernel: scsi7 : SCSI emulation for USB Mass Storage devices
> Jun 19 15:50:53 werewolf-wl kernel: usb-storage: device found at 4
> Jun 19 15:50:53 werewolf-wl kernel: usb-storage: waiting for device to settle before scanning
> Jun 19 15:50:58 werewolf-wl kernel: WARNING: at drivers/usb/core/urb.c:293 usb_submit_urb()
> Jun 19 15:50:58 werewolf-wl kernel: [usb_submit_urb+491/513] usb_submit_urb+0x1eb/0x201
> Jun 19 15:50:58 werewolf-wl kernel: [<c02724be>] usb_submit_urb+0x1eb/0x201
> Jun 19 15:50:58 werewolf-wl kernel: [usb_sg_init+580/609] usb_sg_init+0x244/0x261
> Jun 19 15:50:58 werewolf-wl kernel: [<c027408b>] usb_sg_init+0x244/0x261
> Jun 19 15:50:58 werewolf-wl kernel: [usb_sg_wait+175/326] usb_sg_wait+0xaf/0x146
> Jun 19 15:50:58 werewolf-wl kernel: [<c0273c12>] usb_sg_wait+0xaf/0x146
> Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_bulk_transfer_sg+149/220] usb_stor_bulk_transfer_sg+0x95/0xdc
> Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_bulk_transfer_buf+71/114] usb_stor_bulk_transfer_buf+0x47/0x72
> Jun 19 15:50:58 werewolf-wl kernel: [<c0285afe>] usb_stor_bulk_transfer_buf+0x47/0x72
> Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_Bulk_transport+293/617] usb_stor_Bulk_transport+0x125/0x269
> Jun 19 15:50:58 werewolf-wl kernel: [<c02860a9>] usb_stor_Bulk_transport+0x125/0x269
> Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_control_thread+0/425] usb_stor_control_thread+0x0/0x1a9
> Jun 19 15:50:58 werewolf-wl kernel: [<c0286d5f>] usb_stor_control_thread+0x0/0x1a9
> Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_invoke_transport+21/659] usb_stor_invoke_transport+0x15/0x293
> Jun 19 15:50:58 werewolf-wl kernel: [<c0286202>] usb_stor_invoke_transport+0x15/0x293
> Jun 19 15:50:58 werewolf-wl kernel: [__wake_up_locked+31/33] __wake_up_locked+0x1f/0x21
> Jun 19 15:50:58 werewolf-wl kernel: [<c0113a23>] __wake_up_locked+0x1f/0x21
> Jun 19 15:50:58 werewolf-wl kernel: [__down_interruptible+236/270] __down_interruptible+0xec/0x10e
> Jun 19 15:50:58 werewolf-wl kernel: [<c02f682a>] __down_interruptible+0xec/0x10e
> Jun 19 15:50:58 werewolf-wl kernel: [default_wake_function+0/12] default_wake_function+0x0/0xc
> Jun 19 15:50:58 werewolf-wl kernel: [<c0116d65>] default_wake_function+0x0/0xc
> Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_control_thread+0/425] usb_stor_control_thread+0x0/0x1a9
> Jun 19 15:50:58 werewolf-wl kernel: [<c0286d5f>] usb_stor_control_thread+0x0/0x1a9
> Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_control_thread+0/425] usb_stor_control_thread+0x0/0x1a9
> Jun 19 15:50:58 werewolf-wl kernel: [<c0286d5f>] usb_stor_control_thread+0x0/0x1a9
> Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_control_thread+315/425] usb_stor_control_thread+0x13b/0x1a9
> Jun 19 15:50:58 werewolf-wl kernel: [<c0286e9a>] usb_stor_control_thread+0x13b/0x1a9
> Jun 19 15:50:58 werewolf-wl kernel: [kthread+0/86] kthread+0x0/0x56
> Jun 19 15:50:58 werewolf-wl kernel: [<c012de72>] kthread+0x0/0x56
> Jun 19 15:50:58 werewolf-wl kernel: [usb_stor_control_thread+0/425] usb_stor_control_thread+0x0/0x1a9
> Jun 19 15:50:58 werewolf-wl kernel: [<c0286d5f>] usb_stor_control_thread+0x0/0x1a9
> Jun 19 15:50:58 werewolf-wl kernel: [kthread+52/86] kthread+0x34/0x56
> Jun 19 15:50:58 werewolf-wl kernel: [<c012dea6>] kthread+0x34/0x56
> Jun 19 15:50:58 werewolf-wl kernel: [kthread+0/86] kthread+0x0/0x56
> Jun 19 15:50:58 werewolf-wl kernel: [<c012de72>] kthread+0x0/0x56
> Jun 19 15:50:58 werewolf-wl kernel: [kernel_thread_helper+7/20] kernel_thread_helper+0x7/0x14
> Jun 19 15:50:58 werewolf-wl kernel: [<c01033e3>] kernel_thread_helper+0x7/0x14
> Jun 19 15:50:58 werewolf-wl kernel: =======================
>

--
J.A. Magallon <jamagallon()ono!com> \ Software is like sex:
\ It's better when it's free
Mandriva Linux release 2008.0 (Cooker) for i586
Linux 2.6.21-jam07 (gcc 4.1.2 20070302 (4.1.2-1mdv2007.1)) SMP PREEMPT
09 F9 11 02 9D 74 E3 5B D8 41 56 C5 63 56 88 C0

2007-06-20 05:23:52

by Mattia Dongili

[permalink] [raw]
Subject: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/

Hello,
on this vaio sz72b I can't suspend if usb-storage is loaded. Bisecting
is becoming troublesome as different sets have slightly different
problems.
At one point (with the GREGKH usb stuff built) I had the kernel
reporting it cannot stop the usb-storage thread so I guess that
something later in the series made things worse (freezable workqueues?).

Clues?
--
mattia
:wq!

2007-06-20 07:23:16

by Jiri Slaby

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

J.A. Magallón napsal(a):
> On Tue, 19 Jun 2007 15:53:57 +0200, "J.A. Magallón" <[email protected]> wrote:
>
>> On Wed, 6 Jun 2007 22:03:13 -0700, Andrew Morton <[email protected]> wrote:
>>
>>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
>>>
>>> - Basically a bugfixed version of 2.6.22-rc4-mm1. None of the subsystem
>>> trees were repulled, several bad patches were dropped, a few were fixed.
>>>
>> I get this warning when I plug a USB stick:
>>
>
> Oops, forgot to say that this is not plain -rc4-mm2, but with CFS scheduler v17.
> CC'ing Ingo for if it is related...
>
>> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new high speed USB device using ehci_hcd and address 4
>> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new device found, idVendor=090c, idProduct=1000
>> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new device strings: Mfr=1, Product=2, SerialNumber=3
>> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: Product: USBDrive
>> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: Manufacturer: LG
>> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: SerialNumber: AA04012700012034
>> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: configuration #1 chosen from 1 choice
>> Jun 19 15:50:53 werewolf-wl kernel: scsi7 : SCSI emulation for USB Mass Storage devices
>> Jun 19 15:50:53 werewolf-wl kernel: usb-storage: device found at 4
>> Jun 19 15:50:53 werewolf-wl kernel: usb-storage: waiting for device to settle before scanning
>> Jun 19 15:50:58 werewolf-wl kernel: WARNING: at drivers/usb/core/urb.c:293 usb_submit_urb()

Does this help?
http://lkml.org/lkml/2007/6/7/197

regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E

2007-06-20 11:33:24

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Wednesday, 20 June 2007 07:22, Mattia Dongili wrote:
> On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
>
> Hello,
> on this vaio sz72b I can't suspend if usb-storage is loaded. Bisecting
> is becoming troublesome as different sets have slightly different
> problems.
> At one point (with the GREGKH usb stuff built) I had the kernel
> reporting it cannot stop the usb-storage thread so I guess that
> something later in the series made things worse (freezable workqueues?).
>
> Clues?

Can you please try 2.6.22-rc5 with the patches from

http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc5/patches/

applied. That should allow us to eliminate some suspects. ;-)

Greetings,
Rafael


--
"Premature optimization is the root of all evil." - Donald Knuth

2007-06-20 14:01:49

by Alan Stern

[permalink] [raw]
Subject: Re: [linux-usb-devel] can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Wed, 20 Jun 2007, Mattia Dongili wrote:

> On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
>
> Hello,
> on this vaio sz72b I can't suspend if usb-storage is loaded. Bisecting
> is becoming troublesome as different sets have slightly different
> problems.
> At one point (with the GREGKH usb stuff built) I had the kernel
> reporting it cannot stop the usb-storage thread so I guess that
> something later in the series made things worse (freezable workqueues?).
>
> Clues?

The usb-storage thread is supposed to be unfreezable. Recent changes
may have messed up the code that checks for which threads need to be
frozen and which don't.

Alan Stern

2007-06-20 14:05:40

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [linux-usb-devel] can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Wednesday, 20 June 2007 16:01, Alan Stern wrote:
> On Wed, 20 Jun 2007, Mattia Dongili wrote:
>
> > On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
> > >
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
> >
> > Hello,
> > on this vaio sz72b I can't suspend if usb-storage is loaded. Bisecting
> > is becoming troublesome as different sets have slightly different
> > problems.
> > At one point (with the GREGKH usb stuff built) I had the kernel
> > reporting it cannot stop the usb-storage thread so I guess that
> > something later in the series made things worse (freezable workqueues?).
> >
> > Clues?
>
> The usb-storage thread is supposed to be unfreezable. Recent changes
> may have messed up the code that checks for which threads need to be
> frozen and which don't.

I don't really think so, but well ...

That's why I asked Mattia to test the hibernation/suspend patches without
the rest of -mm.

Greetings,
Rafael


--
"Premature optimization is the root of all evil." - Donald Knuth

2007-06-20 15:39:24

by Mattia Dongili

[permalink] [raw]
Subject: Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Wed, Jun 20, 2007 at 01:40:18PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, 20 June 2007 07:22, Mattia Dongili wrote:
> > On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
> > >
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
> >
> > Hello,
> > on this vaio sz72b I can't suspend if usb-storage is loaded. Bisecting
> > is becoming troublesome as different sets have slightly different
> > problems.
> > At one point (with the GREGKH usb stuff built) I had the kernel
> > reporting it cannot stop the usb-storage thread so I guess that
> > something later in the series made things worse (freezable workqueues?).
> >
> > Clues?
>
> Can you please try 2.6.22-rc5 with the patches from
>
> http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc5/patches/
>
> applied. That should allow us to eliminate some suspects. ;-)

you're safe then! .22-rc5 + your suspend patch-set can suspend and
resume happily.

--
mattia
:wq!

2007-06-20 20:43:23

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Wednesday, 20 June 2007 17:38, Mattia Dongili wrote:
> On Wed, Jun 20, 2007 at 01:40:18PM +0200, Rafael J. Wysocki wrote:
> > On Wednesday, 20 June 2007 07:22, Mattia Dongili wrote:
> > > On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
> > > >
> > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
> > >
> > > Hello,
> > > on this vaio sz72b I can't suspend if usb-storage is loaded. Bisecting
> > > is becoming troublesome as different sets have slightly different
> > > problems.
> > > At one point (with the GREGKH usb stuff built) I had the kernel
> > > reporting it cannot stop the usb-storage thread so I guess that
> > > something later in the series made things worse (freezable workqueues?).
> > >
> > > Clues?
> >
> > Can you please try 2.6.22-rc5 with the patches from
> >
> > http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc5/patches/
> >
> > applied. That should allow us to eliminate some suspects. ;-)
>
> you're safe then! .22-rc5 + your suspend patch-set can suspend and
> resume happily.

OK, thanks. OTOH, that would have been less patches to check ... ;-)

I'll see if I can reproduce your problem here.

Greetings,
Rafael


--
"Premature optimization is the root of all evil." - Donald Knuth

2007-06-20 21:54:50

by J.A. Magallón

[permalink] [raw]
Subject: Re: 2.6.22-rc4-mm2

On Wed, 20 Jun 2007 09:23:07 +0200, Jiri Slaby <[email protected]> wrote:

> J.A. Magallón napsal(a):
> > On Tue, 19 Jun 2007 15:53:57 +0200, "J.A. Magallón" <[email protected]> wrote:
> >
> >> On Wed, 6 Jun 2007 22:03:13 -0700, Andrew Morton <[email protected]> wrote:
> >>
> >>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
> >>>
> >>> - Basically a bugfixed version of 2.6.22-rc4-mm1. None of the subsystem
> >>> trees were repulled, several bad patches were dropped, a few were fixed.
> >>>
> >> I get this warning when I plug a USB stick:
> >>
> >
> > Oops, forgot to say that this is not plain -rc4-mm2, but with CFS scheduler v17.
> > CC'ing Ingo for if it is related...
> >
> >> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new high speed USB device using ehci_hcd and address 4
> >> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new device found, idVendor=090c, idProduct=1000
> >> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: new device strings: Mfr=1, Product=2, SerialNumber=3
> >> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: Product: USBDrive
> >> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: Manufacturer: LG
> >> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: SerialNumber: AA04012700012034
> >> Jun 19 15:50:53 werewolf-wl kernel: usb 1-8: configuration #1 chosen from 1 choice
> >> Jun 19 15:50:53 werewolf-wl kernel: scsi7 : SCSI emulation for USB Mass Storage devices
> >> Jun 19 15:50:53 werewolf-wl kernel: usb-storage: device found at 4
> >> Jun 19 15:50:53 werewolf-wl kernel: usb-storage: waiting for device to settle before scanning
> >> Jun 19 15:50:58 werewolf-wl kernel: WARNING: at drivers/usb/core/urb.c:293 usb_submit_urb()
>
> Does this help?
> http://lkml.org/lkml/2007/6/7/197
>
> regards,

Yep, thanks !!! Oops gone.

--
J.A. Magallon <jamagallon()ono!com> \ Software is like sex:
\ It's better when it's free
Mandriva Linux release 2008.0 (Cooker) for i586
Linux 2.6.21-jam08 (gcc 4.1.2 20070302 (4.1.2-1mdv2007.1)) SMP PREEMPT
09 F9 11 02 9D 74 E3 5B D8 41 56 C5 63 56 88 C0

2007-06-20 21:56:49

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Wednesday, 20 June 2007 22:50, Rafael J. Wysocki wrote:
> On Wednesday, 20 June 2007 17:38, Mattia Dongili wrote:
> > On Wed, Jun 20, 2007 at 01:40:18PM +0200, Rafael J. Wysocki wrote:
> > > On Wednesday, 20 June 2007 07:22, Mattia Dongili wrote:
> > > > On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
> > > > >
> > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
> > > >
> > > > Hello,
> > > > on this vaio sz72b I can't suspend if usb-storage is loaded. Bisecting
> > > > is becoming troublesome as different sets have slightly different
> > > > problems.
> > > > At one point (with the GREGKH usb stuff built) I had the kernel
> > > > reporting it cannot stop the usb-storage thread so I guess that
> > > > something later in the series made things worse (freezable workqueues?).
> > > >
> > > > Clues?
> > >
> > > Can you please try 2.6.22-rc5 with the patches from
> > >
> > > http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc5/patches/
> > >
> > > applied. That should allow us to eliminate some suspects. ;-)
> >
> > you're safe then! .22-rc5 + your suspend patch-set can suspend and
> > resume happily.
>
> OK, thanks. OTOH, that would have been less patches to check ... ;-)
>
> I'll see if I can reproduce your problem here.

Yes, I can. It's only necessary to load usb-storage (without any devices
actually using it) and it fails device_suspend() immediately (I don't think
it's freezer-related).

I've got the following trace from it:

usb_endpoint usbdev3.2_ep81: PM: suspend 0->1, parent 3-1:1.0 already 2
Suspending device 3-1:1.0
Suspending device usbdev3.2_ep00
Suspending device 3-1
Suspending device eth1
Suspending device eth0
Suspending device usbdev3.1
Suspending device usbdev3.1_ep81
Suspending device 3-0:1.0
Suspending device usbdev3.1_ep00
Suspending device usb3
hub 3-0:1.0: hub_suspend
ohci_hcd 0000:00:02.1: needs reinit!
usb usb3: suspend fail, err -16
usb usb3: 'global' suspend -16
hub 3-0:1.0: hub_resume
hub 3-0:1.0: activate --> -108
suspend_device(): usb_suspend+0x0/0x30() returns -16
Could not suspend device usb3: error -16
WARNING: at /home/rafael/src/mm/linux-2.6.22-rc4-mm2/drivers/usb/core/urb.c:293 usb_submit_urb()

Call Trace:
[<ffffffff80409dd3>] usb_submit_urb+0x363/0x3b0
[<ffffffff881e21cf>] :usbhid:hid_start_in+0x8f/0xb0
[<ffffffff881e221a>] :usbhid:hid_resume+0x2a/0x30
[<ffffffff8040c832>] usb_resume_interface+0x92/0x100
[<ffffffff8040c93e>] usb_external_resume_device+0x9e/0x170
[<ffffffff8040ca3b>] usb_resume+0x2b/0x40
[<ffffffff803ed097>] resume_device+0x87/0x190
[<ffffffff803ed239>] dpm_resume+0x99/0xc0
[<ffffffff803ecef7>] device_suspend+0x147/0x190
[<ffffffff803c1891>] tty_ldisc_deref+0x61/0x80
[<ffffffff80268e1e>] hibernation_snapshot+0x3e/0xe0
[<ffffffff802e7fce>] dnotify_parent+0x3e/0x90
[<ffffffff8026c059>] snapshot_ioctl+0x379/0x540
[<ffffffff8026bce0>] snapshot_ioctl+0x0/0x540
[<ffffffff802b2b72>] do_ioctl+0x92/0xe0
[<ffffffff802b2c33>] vfs_ioctl+0x73/0x2d0
[<ffffffff804b2c7a>] trace_hardirqs_on_thunk+0x35/0x37
[<ffffffff802b2f21>] sys_ioctl+0x91/0xb0
[<ffffffff8020bc6e>] system_call+0x7e/0x83

usbhid 3-1:1.0: resume error -16
usb_endpoint usbdev3.2_ep81: PM: resume from 0, parent 3-1:1.0 still 2
input input4: PM: resume from 0, parent 3-1:1.0 still 2
Restarting tasks ... <7>hub 3-0:1.0: state 7 ports 3 chg 0000 evt 0000
hub 3-0:1.0: hub_port_status failed (err = -108)
hub 3-0:1.0: hub_port_status failed (err = -108)
hub 3-0:1.0: hub_port_status failed (err = -108)
done.
swsusp: Basic memory bitmaps freed

Greetings,
Rafael


--
"Premature optimization is the root of all evil." - Donald Knuth

2007-06-20 22:16:17

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Thursday, 21 June 2007 00:03, Rafael J. Wysocki wrote:
> On Wednesday, 20 June 2007 22:50, Rafael J. Wysocki wrote:
> > On Wednesday, 20 June 2007 17:38, Mattia Dongili wrote:
> > > On Wed, Jun 20, 2007 at 01:40:18PM +0200, Rafael J. Wysocki wrote:
> > > > On Wednesday, 20 June 2007 07:22, Mattia Dongili wrote:
> > > > > On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
> > > > > >
> > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
> > > > >
> > > > > Hello,
> > > > > on this vaio sz72b I can't suspend if usb-storage is loaded. Bisecting
> > > > > is becoming troublesome as different sets have slightly different
> > > > > problems.
> > > > > At one point (with the GREGKH usb stuff built) I had the kernel
> > > > > reporting it cannot stop the usb-storage thread so I guess that
> > > > > something later in the series made things worse (freezable workqueues?).
> > > > >
> > > > > Clues?
> > > >
> > > > Can you please try 2.6.22-rc5 with the patches from
> > > >
> > > > http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc5/patches/
> > > >
> > > > applied. That should allow us to eliminate some suspects. ;-)
> > >
> > > you're safe then! .22-rc5 + your suspend patch-set can suspend and
> > > resume happily.
> >
> > OK, thanks. OTOH, that would have been less patches to check ... ;-)
> >
> > I'll see if I can reproduce your problem here.
>
> Yes, I can. It's only necessary to load usb-storage (without any devices
> actually using it) and it fails device_suspend() immediately (I don't think
> it's freezer-related).

It seems to be 100% reproducible in arbitrary configuration.

Here's a dmesg snippet from another machine:

Suspending device usbdev4.1
Suspending device usbdev4.1_ep81
Suspending device 4-0:1.0
Suspending device usbdev4.1_ep00
Suspending device usb4
hub 4-0:1.0: activate --> -108
suspend_device(): usb_suspend+0x0/0x30() returns -16
Could not suspend device usb4: error -16
PM: Image restored successfully.
Restarting tasks ... <3>hub 4-0:1.0: hub_port_status failed (err = -108)
hub 4-0:1.0: hub_port_status failed (err = -108)
hub 4-0:1.0: hub_port_status failed (err = -108)
done.
swsusp: Basic memory bitmaps freed

Greetings,
Rafael


--
"Premature optimization is the root of all evil." - Donald Knuth

2007-06-21 15:28:18

by Alan Stern

[permalink] [raw]
Subject: Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Thu, 21 Jun 2007, Rafael J. Wysocki wrote:

> > I'll see if I can reproduce your problem here.
>
> Yes, I can. It's only necessary to load usb-storage (without any devices
> actually using it) and it fails device_suspend() immediately (I don't think
> it's freezer-related).
>
> I've got the following trace from it:
>
> usb_endpoint usbdev3.2_ep81: PM: suspend 0->1, parent 3-1:1.0 already 2
> Suspending device 3-1:1.0
> Suspending device usbdev3.2_ep00
> Suspending device 3-1
> Suspending device eth1
> Suspending device eth0
> Suspending device usbdev3.1
> Suspending device usbdev3.1_ep81
> Suspending device 3-0:1.0
> Suspending device usbdev3.1_ep00
> Suspending device usb3
> hub 3-0:1.0: hub_suspend
> ohci_hcd 0000:00:02.1: needs reinit!
> usb usb3: suspend fail, err -16
> usb usb3: 'global' suspend -16

Odd. This has nothing at all to do with usb-storage. The "needs
reinnit!" message means that an OHCI controller was in a reset state --
not running and not suspended -- when the suspend method was called.

This happened with plain old 2.6.22-rc4-mm2? I'll try to reproduce it.

Alan Stern

2007-06-21 19:39:48

by Alan Stern

[permalink] [raw]
Subject: Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Thu, 21 Jun 2007, Rafael J. Wysocki wrote:

> > I'll see if I can reproduce your problem here.
>
> Yes, I can. It's only necessary to load usb-storage (without any devices
> actually using it) and it fails device_suspend() immediately (I don't think
> it's freezer-related).
>
> I've got the following trace from it:
>
> usb_endpoint usbdev3.2_ep81: PM: suspend 0->1, parent 3-1:1.0 already 2
> Suspending device 3-1:1.0
> Suspending device usbdev3.2_ep00
> Suspending device 3-1
> Suspending device eth1
> Suspending device eth0
> Suspending device usbdev3.1
> Suspending device usbdev3.1_ep81
> Suspending device 3-0:1.0
> Suspending device usbdev3.1_ep00
> Suspending device usb3
> hub 3-0:1.0: hub_suspend
> ohci_hcd 0000:00:02.1: needs reinit!
> usb usb3: suspend fail, err -16
> usb usb3: 'global' suspend -16
> hub 3-0:1.0: hub_resume
> hub 3-0:1.0: activate --> -108
> suspend_device(): usb_suspend+0x0/0x30() returns -16
> Could not suspend device usb3: error -16
> WARNING: at /home/rafael/src/mm/linux-2.6.22-rc4-mm2/drivers/usb/core/urb.c:293 usb_submit_urb()

Well, a large part of the problem is that

usb-try-to-debug-bug-8561.patch

hasn't been reverted in 2.6.22-rc4-mm2. Andrew, that patch is supposed
to be completely gone. It isn't still present in your tree, is it?

Alan Stern

2007-06-21 21:43:17

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Thursday, 21 June 2007 21:39, Alan Stern wrote:
> On Thu, 21 Jun 2007, Rafael J. Wysocki wrote:
>
> > > I'll see if I can reproduce your problem here.
> >
> > Yes, I can. It's only necessary to load usb-storage (without any devices
> > actually using it) and it fails device_suspend() immediately (I don't think
> > it's freezer-related).
> >
> > I've got the following trace from it:
> >
> > usb_endpoint usbdev3.2_ep81: PM: suspend 0->1, parent 3-1:1.0 already 2
> > Suspending device 3-1:1.0
> > Suspending device usbdev3.2_ep00
> > Suspending device 3-1
> > Suspending device eth1
> > Suspending device eth0
> > Suspending device usbdev3.1
> > Suspending device usbdev3.1_ep81
> > Suspending device 3-0:1.0
> > Suspending device usbdev3.1_ep00
> > Suspending device usb3
> > hub 3-0:1.0: hub_suspend
> > ohci_hcd 0000:00:02.1: needs reinit!
> > usb usb3: suspend fail, err -16
> > usb usb3: 'global' suspend -16
> > hub 3-0:1.0: hub_resume
> > hub 3-0:1.0: activate --> -108
> > suspend_device(): usb_suspend+0x0/0x30() returns -16
> > Could not suspend device usb3: error -16
> > WARNING: at /home/rafael/src/mm/linux-2.6.22-rc4-mm2/drivers/usb/core/urb.c:293 usb_submit_urb()
>
> Well, a large part of the problem is that
>
> usb-try-to-debug-bug-8561.patch
>
> hasn't been reverted in 2.6.22-rc4-mm2.

Yes, the problem is not present after reverting this patch.

Greetings,
Rafael


--
"Premature optimization is the root of all evil." - Donald Knuth

2007-06-21 23:53:25

by Adrian Bunk

[permalink] [raw]
Subject: [-mm patch] mark calibrate_xor_blocks() __init

On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc4-mm1:
>...
> git-md-accel.patch
>...
> git trees
>...

calibrate_xor_blocks() can be marked __init.

Signed-off-by: Adrian Bunk <[email protected]>

---
--- linux-2.6.22-rc4-mm2/crypto/xor.c.old 2007-06-21 23:47:56.000000000 +0200
+++ linux-2.6.22-rc4-mm2/crypto/xor.c 2007-06-21 23:48:39.000000000 +0200
@@ -94,7 +94,7 @@
speed / 1000, speed % 1000);
}

-static int
+static int __init
calibrate_xor_blocks(void)
{
void *b1, *b2;

2007-06-22 09:27:13

by Mattia Dongili

[permalink] [raw]
Subject: Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Thu, Jun 21, 2007 at 11:49:37PM +0200, Rafael J. Wysocki wrote:
> On Thursday, 21 June 2007 21:39, Alan Stern wrote:
> > On Thu, 21 Jun 2007, Rafael J. Wysocki wrote:
> >
> > > > I'll see if I can reproduce your problem here.
> > >
> > > Yes, I can. It's only necessary to load usb-storage (without any devices
> > > actually using it) and it fails device_suspend() immediately (I don't think
> > > it's freezer-related).
> > >
> > > I've got the following trace from it:
> > >
> > > usb_endpoint usbdev3.2_ep81: PM: suspend 0->1, parent 3-1:1.0 already 2
> > > Suspending device 3-1:1.0
> > > Suspending device usbdev3.2_ep00
> > > Suspending device 3-1
> > > Suspending device eth1
> > > Suspending device eth0
> > > Suspending device usbdev3.1
> > > Suspending device usbdev3.1_ep81
> > > Suspending device 3-0:1.0
> > > Suspending device usbdev3.1_ep00
> > > Suspending device usb3
> > > hub 3-0:1.0: hub_suspend
> > > ohci_hcd 0000:00:02.1: needs reinit!
> > > usb usb3: suspend fail, err -16
> > > usb usb3: 'global' suspend -16
> > > hub 3-0:1.0: hub_resume
> > > hub 3-0:1.0: activate --> -108
> > > suspend_device(): usb_suspend+0x0/0x30() returns -16
> > > Could not suspend device usb3: error -16
> > > WARNING: at /home/rafael/src/mm/linux-2.6.22-rc4-mm2/drivers/usb/core/urb.c:293 usb_submit_urb()
> >
> > Well, a large part of the problem is that
> >
> > usb-try-to-debug-bug-8561.patch
> >
> > hasn't been reverted in 2.6.22-rc4-mm2.
>
> Yes, the problem is not present after reverting this patch.

Not for me, I had that patch already reverted. As I said there was a
point when bisecting which the kernel came back to life instead of just
hanging trying to suspend.
I'll try to get a trace with that. May the usb_storage verbose debug
help there?

--
mattia
:wq!

2007-06-22 13:59:58

by Alan Stern

[permalink] [raw]
Subject: Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Fri, 22 Jun 2007, Mattia Dongili wrote:

> > Yes, the problem is not present after reverting this patch.
>
> Not for me, I had that patch already reverted. As I said there was a
> point when bisecting which the kernel came back to life instead of just
> hanging trying to suspend.
> I'll try to get a trace with that. May the usb_storage verbose debug
> help there?

I've lost track of the start of this thread, so it would help to see a
dmesg log with CONFIG_USB_DEBUG turned on. CONFIG_USB_STORAGE_DEBUG
doesn't matter so much because the usb-storage suspend and resume
routines don't do a lot of work.

Alan Stern

2007-06-24 05:29:15

by Mattia Dongili

[permalink] [raw]
Subject: Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Fri, Jun 22, 2007 at 09:59:47AM -0400, Alan Stern wrote:
> On Fri, 22 Jun 2007, Mattia Dongili wrote:
>
> > > Yes, the problem is not present after reverting this patch.
> >
> > Not for me, I had that patch already reverted. As I said there was a
> > point when bisecting which the kernel came back to life instead of just
> > hanging trying to suspend.
> > I'll try to get a trace with that. May the usb_storage verbose debug
> > help there?
>
> I've lost track of the start of this thread, so it would help to see a
> dmesg log with CONFIG_USB_DEBUG turned on. CONFIG_USB_STORAGE_DEBUG
> doesn't matter so much because the usb-storage suspend and resume
> routines don't do a lot of work.

Sorry, it was probably me who messed things up. It looks like it's not
usb-storage who's preventing suspend here. I have this diff between a
single user mode where I can suspend and a multiuser environment where
suspend hangs, will go loading the missing modules one by one and get a
better idea...
Sorry for the noise.

--- /root/lsmod-str.txt 2007-06-24 10:58:09.953207666 +0900
+++ /root/lsmod-str-nono.txt 2007-06-24 14:21:33.354417422 +0900
@@ -1,10 +1,20 @@
+ac
+acpi_cpufreq
agpgart
arc4
+auth_rpcgss
backlight
+battery
blkcipher
bluetooth
+button
cdrom
cfg80211
+cpufreq_conservative
+cpufreq_ondemand
+cpufreq_powersave
+cpufreq_stats
+cpufreq_userspace
dm_crypt
dm_mirror
dm_mod
@@ -12,20 +22,39 @@
ecb
ehci_hcd
evdev
+exportfs
+fan
firmware_class
+freq_table
fuse
hci_usb
i2c_i801
ide_cd
+inet_diag
intel_agp
+iptable_filter
+iptable_nat
+ip_tables
+ipt_MASQUERADE
+ipv6
iwl3945
+l2cap
+lockd
loop
mac80211
+nf_conntrack
+nf_conntrack_ipv4
+nf_nat
+nfnetlink
+nfs
+nfs_acl
+nfsd
pcmcia
pcmcia_core
psmouse
r5u870
rc80211_simple
+rfcomm
rsrc_nonstatic
rtc
sky2
@@ -38,16 +67,22 @@
snd_timer
sony_laptop
soundcore
+sunrpc
+tcp_diag
+thermal
tifm_7xx1
tifm_core
tpm
tpm_bios
tpm_infineon
uhci_hcd
-usb_storage
usbcore
+usb_storage
v4l1_compat
v4l2_common
video_buf
videodev
+x_tables
+xt_state
+xt_tcpudp
yenta_socket

--
mattia
:wq!

2007-06-24 08:35:22

by Mattia Dongili

[permalink] [raw]
Subject: it's iwl3945 [Re: can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

On Fri, Jun 22, 2007 at 09:59:47AM -0400, Alan Stern wrote:
> I've lost track of the start of this thread, so it would help to see a
...

Hi,
sorry for the previous spam about not suspending.

It turns out it's actually due to iwl3945.
Looking at the changelog there's been a recent fix for suspend/resume
issues, I just tested the latest snapshot (0.0.32) which indeed works.

apologies again,
--
mattia
:wq!

2007-06-26 20:32:29

by Andrew Morton

[permalink] [raw]
Subject: Re: [-mm patch] remove nobh_{prepare,commit}_write()

On Fri, 15 Jun 2007 00:15:55 +0200
Adrian Bunk <[email protected]> wrote:

> nobh_{prepare,commit}_write() are no longer used.

wth? What happened to ext2 and ext3 nobh mode? They seem to
have magically and unchangeloggedly disappeared?

2007-06-26 20:49:16

by Dave Kleikamp

[permalink] [raw]
Subject: Re: [-mm patch] remove nobh_{prepare,commit}_write()

On Tue, 2007-06-26 at 13:32 -0700, Andrew Morton wrote:
> On Fri, 15 Jun 2007 00:15:55 +0200
> Adrian Bunk <[email protected]> wrote:
>
> > nobh_{prepare,commit}_write() are no longer used.
>
> wth? What happened to ext2 and ext3 nobh mode? They seem to
> have magically and unchangeloggedly disappeared?

They were removed with Nick's new aops patches.

Shaggy
--
David Kleikamp
IBM Linux Technology Center

2007-06-26 21:24:28

by Andrew Morton

[permalink] [raw]
Subject: Re: [-mm patch] remove nobh_{prepare,commit}_write()

On Tue, 26 Jun 2007 15:48:58 -0500
Dave Kleikamp <[email protected]> wrote:

> On Tue, 2007-06-26 at 13:32 -0700, Andrew Morton wrote:
> > On Fri, 15 Jun 2007 00:15:55 +0200
> > Adrian Bunk <[email protected]> wrote:
> >
> > > nobh_{prepare,commit}_write() are no longer used.
> >
> > wth? What happened to ext2 and ext3 nobh mode? They seem to
> > have magically and unchangeloggedly disappeared?
>
> They were removed with Nick's new aops patches.
^secretly
>

That much I worked out for myself. It's kinda staggering that a fairly
major feature in two fairly major filesystems got removed without even a
mention in the changelog. I don't recall having seen it discussed in email
but I obviously missed that bit.

Look, I'm one micron from just dropping the whole lot. These changes
simply have not received the amount of energy, effort, care, attention and
testing which a change of this magnitude requires.

2007-06-26 21:35:06

by Randy Dunlap

[permalink] [raw]
Subject: Re: [-mm patch] remove nobh_{prepare,commit}_write()

On Tue, 26 Jun 2007 14:23:20 -0700 Andrew Morton wrote:

> On Tue, 26 Jun 2007 15:48:58 -0500
> Dave Kleikamp <[email protected]> wrote:
>
> > On Tue, 2007-06-26 at 13:32 -0700, Andrew Morton wrote:
> > > On Fri, 15 Jun 2007 00:15:55 +0200
> > > Adrian Bunk <[email protected]> wrote:
> > >
> > > > nobh_{prepare,commit}_write() are no longer used.
> > >
> > > wth? What happened to ext2 and ext3 nobh mode? They seem to
> > > have magically and unchangeloggedly disappeared?
> >
> > They were removed with Nick's new aops patches.
> ^secretly
> >
>
> That much I worked out for myself. It's kinda staggering that a fairly
> major feature in two fairly major filesystems got removed without even a
> mention in the changelog. I don't recall having seen it discussed in email
> but I obviously missed that bit.
>
> Look, I'm one micron from just dropping the whole lot. These changes
> simply have not received the amount of energy, effort, care, attention and
> testing which a change of this magnitude requires.

so be sure to discuss that (not the patches themselves so much,
but the process(es)) at the kernel summit etc....


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

2007-06-27 01:39:20

by Nick Piggin

[permalink] [raw]
Subject: Re: [-mm patch] remove nobh_{prepare,commit}_write()

On Tue, Jun 26, 2007 at 02:33:35PM -0700, Randy Dunlap wrote:
> On Tue, 26 Jun 2007 14:23:20 -0700 Andrew Morton wrote:
>
> > On Tue, 26 Jun 2007 15:48:58 -0500
> > Dave Kleikamp <[email protected]> wrote:
> >
> > > On Tue, 2007-06-26 at 13:32 -0700, Andrew Morton wrote:
> > > > On Fri, 15 Jun 2007 00:15:55 +0200
> > > > Adrian Bunk <[email protected]> wrote:
> > > >
> > > > > nobh_{prepare,commit}_write() are no longer used.
> > > >
> > > > wth? What happened to ext2 and ext3 nobh mode? They seem to
> > > > have magically and unchangeloggedly disappeared?
> > >
> > > They were removed with Nick's new aops patches.
> > ^secretly
> > >
> >
> > That much I worked out for myself. It's kinda staggering that a fairly
> > major feature in two fairly major filesystems got removed without even a
> > mention in the changelog. I don't recall having seen it discussed in email
> > but I obviously missed that bit.
> >
> > Look, I'm one micron from just dropping the whole lot. These changes
> > simply have not received the amount of energy, effort, care, attention and
> > testing which a change of this magnitude requires.
>
> so be sure to discuss that (not the patches themselves so much,
> but the process(es)) at the kernel summit etc....

I did of course mention that nobh wasn't converted when sending the
patches.

I asked for comments about how much it is used in real world. Badari
was the only one who replied about that but we didn't reach a conclusion.

I don't know about energy, but I have seen lots of other patches cause
a lot more problems...