2007-08-30 22:45:34

by Gaston, Jason D

Subject: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai

This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.

Signed-off-by: ?Jason Gaston <[email protected]>

--- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000
-0700
+++ linux-2.6.23-rc4/arch/i386/pci/irq.c 2007-08-28 16:58:31.000000000 -0700
@@ -550,6 +550,7 @@
case PCI_DEVICE_ID_INTEL_ICH9_3:
case PCI_DEVICE_ID_INTEL_ICH9_4:
case PCI_DEVICE_ID_INTEL_ICH9_5:
+ case PCI_DEVICE_ID_INTEL_Tolapai_0:
r->name = "PIIX/ICH";
r->get = pirq_piix_get;
r->set = pirq_piix_set;
--- linux-2.6.23-rc4/include/linux/pci_ids.h.orig 2007-08-27
18:32:35.000000000 -0700
+++ linux-2.6.23-rc4/include/linux/pci_ids.h 2007-08-28 16:58:31.000000000
-0700
@@ -2293,6 +2293,8 @@
#define PCI_DEVICE_ID_INTEL_MCH_PC 0x3599
#define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
#define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
+#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031
+#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032
#define PCI_DEVICE_ID_INTEL_82371SB_0 0x7000
#define PCI_DEVICE_ID_INTEL_82371SB_1 0x7010
#define PCI_DEVICE_ID_INTEL_82371SB_2 0x7020

2007-08-31 01:41:19

by Matthew Wilcox

Subject: Re: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai

On Thu, Aug 30, 2007 at 03:46:56PM -0700, Jason Gaston wrote:
> This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
> +#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031
> +#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032

NACK -- use all upper-case.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."

2007-09-01 21:20:08

by Grant Grundler

Subject: Re: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai

On Thu, Aug 30, 2007 at 03:46:56PM -0700, Jason Gaston wrote:
> This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
>
> Signed-off-by: ?Jason Gaston <[email protected]>
>
> --- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000
> -0700
> +++ linux-2.6.23-rc4/arch/i386/pci/irq.c 2007-08-28 16:58:31.000000000 -0700
> @@ -550,6 +550,7 @@
> case PCI_DEVICE_ID_INTEL_ICH9_3:
> case PCI_DEVICE_ID_INTEL_ICH9_4:
> case PCI_DEVICE_ID_INTEL_ICH9_5:
> + case PCI_DEVICE_ID_INTEL_Tolapai_0:

If this is the only place it's used, the prefence is to define the
constant locally (in the file) and not in pci_ids.h.

Please do submit new PCI device IDs to pciids.sf.net project.

thanks,
grant

> r->name = "PIIX/ICH";
> r->get = pirq_piix_get;
> r->set = pirq_piix_set;
> --- linux-2.6.23-rc4/include/linux/pci_ids.h.orig 2007-08-27
> 18:32:35.000000000 -0700
> +++ linux-2.6.23-rc4/include/linux/pci_ids.h 2007-08-28 16:58:31.000000000
> -0700
> @@ -2293,6 +2293,8 @@
> #define PCI_DEVICE_ID_INTEL_MCH_PC 0x3599
> #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
> #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
> +#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031
> +#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032
> #define PCI_DEVICE_ID_INTEL_82371SB_0 0x7000
> #define PCI_DEVICE_ID_INTEL_82371SB_1 0x7010
> #define PCI_DEVICE_ID_INTEL_82371SB_2 0x7020

2007-09-01 21:31:17

by Jeff Garzik

Subject: Re: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai

Grant Grundler wrote:
> On Thu, Aug 30, 2007 at 03:46:56PM -0700, Jason Gaston wrote:
>> This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
>>
>> Signed-off-by: ?Jason Gaston <[email protected]>
>>
>> --- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000
>> -0700
>> +++ linux-2.6.23-rc4/arch/i386/pci/irq.c 2007-08-28 16:58:31.000000000 -0700
>> @@ -550,6 +550,7 @@
>> case PCI_DEVICE_ID_INTEL_ICH9_3:
>> case PCI_DEVICE_ID_INTEL_ICH9_4:
>> case PCI_DEVICE_ID_INTEL_ICH9_5:
>> + case PCI_DEVICE_ID_INTEL_Tolapai_0:
>
> If this is the only place it's used, the prefence is to define the
> constant locally (in the file) and not in pci_ids.h.

Kinda sorta: if you must define a constant, it should go into
linux/pci_ids.h. Otherwise someone will come along later, do the same
locally in another file, then you have two independent symbols with the
same meaning.

Ideally, in pci_device_id tables and such, you can just use the hex
number, since they are all arbitrary and lack meaning anyway.


> Please do submit new PCI device IDs to pciids.sf.net project.

Yep.


>> #define PCI_DEVICE_ID_INTEL_MCH_PC 0x3599
>> #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
>> #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
>> +#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031
>> +#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032

And change the StudlyCaps to ALLCAPS.

Jeff

2007-09-04 17:17:20

by Gaston, Jason D

Subject: RE: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai

>> Please do submit new PCI device IDs to pciids.sf.net project.
>
>Yep.


FYI: I have already posted the Tolapai DID's and device strings to
pciids.sf.net.

Thanks,

Jason