2007-10-12 13:03:21

by Hinko Kocevar

[permalink] [raw]

Subject: [PATCH] mcs7780 needs to free allocated rx buffer

---

--- linux-2.6.23/drivers/net/irda/mcs7780.c.orig 2007-10-12 14:02:55.000000000 +0200
+++ linux-2.6.23/drivers/net/irda/mcs7780.c 2007-10-12 14:05:03.000000000 +0200
@@ -678,6 +678,8 @@ static int mcs_net_close(struct net_devi
/* Stop transmit processing */
netif_stop_queue(netdev);

+ kfree_skb(mcs->rx_buff.skb);
+
/* kill and free the receive and transmit URBs */
usb_kill_urb(mcs->rx_urb);
usb_free_urb(mcs->rx_urb);

---

Attachments:

mcs7780-free-rx_buff.diff (432.00 B)

2007-10-13 01:00:22

by Samuel Ortiz

[permalink] [raw]

Subject: Re: [irda-users] [PATCH] mcs7780 needs to free allocated rx buffer

---

Hi Hinko,

On Fri, Oct 12, 2007 at 02:36:46PM +0200, [email protected] wrote:
> Hi,
>
> While testing the mcs7780 based IrDA USB dongle I've stumbled upon
> memory leak in mcs_net_close(). Patch below fixes it.
Thanks for the fix. Applied to my local git, will push forward.

Cheers,
Samuel.


> Signed-off-by: Hinko Kocevar <[email protected]>
>
> Best regards,
> Hinko
>
> ----
>
>

> --- linux-2.6.23/drivers/net/irda/mcs7780.c.orig 2007-10-12 14:02:55.000000000 +0200
> +++ linux-2.6.23/drivers/net/irda/mcs7780.c 2007-10-12 14:05:03.000000000 +0200
> @@ -678,6 +678,8 @@ static int mcs_net_close(struct net_devi
> /* Stop transmit processing */
> netif_stop_queue(netdev);
>
> + kfree_skb(mcs->rx_buff.skb);
> +
> /* kill and free the receive and transmit URBs */
> usb_kill_urb(mcs->rx_urb);
> usb_free_urb(mcs->rx_urb);

> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems? Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> irda-users mailing list
> [email protected]
> http://lists.sourceforge.net/lists/listinfo/irda-users