2007-11-05 11:46:20

by Swen Schillig

[permalink] [raw]
Subject: [patch 1/6] zfcp: Remove unnecessary eh_bus_reset_handler callback

From: Christof Schmitt <[email protected]>

The callback function used by zfcp always returns success,
which is an indication for the SCSI midlayer to stop error
handling. Remove the bus_reset callback, since the same
function will be called via the host_reset callback.

Signed-off-by: Christof Schmitt <[email protected]>
Signed-off-by: Swen Schillig <[email protected]>
---

drivers/s390/scsi/zfcp_scsi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Index: scsi-misc/drivers/s390/scsi/zfcp_scsi.c
===================================================================
--- scsi-misc.orig/drivers/s390/scsi/zfcp_scsi.c
+++ scsi-misc/drivers/s390/scsi/zfcp_scsi.c
@@ -51,7 +51,6 @@ struct zfcp_data zfcp_data = {
.queuecommand = zfcp_scsi_queuecommand,
.eh_abort_handler = zfcp_scsi_eh_abort_handler,
.eh_device_reset_handler = zfcp_scsi_eh_device_reset_handler,
- .eh_bus_reset_handler = zfcp_scsi_eh_host_reset_handler,
.eh_host_reset_handler = zfcp_scsi_eh_host_reset_handler,
.can_queue = 4096,
.this_id = -1,
@@ -542,7 +541,7 @@ zfcp_task_management_function(struct zfc
}

/**
- * zfcp_scsi_eh_host_reset_handler - handler for host and bus reset
+ * zfcp_scsi_eh_host_reset_handler - handler for host reset
*/
static int zfcp_scsi_eh_host_reset_handler(struct scsi_cmnd *scpnt)
{
@@ -552,7 +551,7 @@ static int zfcp_scsi_eh_host_reset_handl
unit = (struct zfcp_unit*) scpnt->device->hostdata;
adapter = unit->port->adapter;

- ZFCP_LOG_NORMAL("host/bus reset because of problems with "
+ ZFCP_LOG_NORMAL("host reset because of problems with "
"unit 0x%016Lx\n", unit->fcp_lun);

zfcp_erp_adapter_reopen(adapter, 0);

--