2007-12-20 10:10:16

by Jesper Nilsson

[permalink] [raw]
Subject: [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h

This is very old code, it hasn't changed since 2001 and
it is not used anywhere. Noticed by Clemens Koller.

Signed-off-by: Jesper Nilsson <[email protected]>
---
include/asm-cris/bitops.h | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/include/asm-cris/bitops.h b/include/asm-cris/bitops.h
index e2f49c2..75ea6e0 100644
--- a/include/asm-cris/bitops.h
+++ b/include/asm-cris/bitops.h
@@ -24,13 +24,6 @@
#include <linux/compiler.h>

/*
- * Some hacks to defeat gcc over-optimizations..
- */
-struct __dummy { unsigned long a[100]; };
-#define ADDR (*(struct __dummy *) addr)
-#define CONST_ADDR (*(const struct __dummy *) addr)
-
-/*
* set_bit - Atomically set a bit in memory
* @nr: the bit to set
* @addr: the address to start counting from
--
1.5.3.6.970.gd25430

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]


2007-12-22 08:30:43

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h

On Thu, 20 Dec 2007 11:09:44 +0100 Jesper Nilsson <[email protected]> wrote:

> Subject: [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h

It's nice (and conventional) to prefix the patch title with the subsystem
name. So this one would become


Subject: [PATCH] cris: remove unused __dummy, CONST_ADDR and ADDR from bitops.h

Thanks.

2008-01-03 16:54:23

by Jesper Nilsson

[permalink] [raw]
Subject: Re: [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h

On Sat, Dec 22, 2007 at 12:30:25AM -0800, Andrew Morton wrote:
> On Thu, 20 Dec 2007 11:09:44 +0100 Jesper Nilsson <[email protected]> wrote:
> > Subject: [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h
>
> It's nice (and conventional) to prefix the patch title with the subsystem
> name.

Sorry about that, will add that to my checklist.

> So this one would become
>
> Subject: [PATCH] cris: remove unused __dummy, CONST_ADDR and ADDR from bitops.h
>
> Thanks.

No, thank you. :-)

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]