2008-01-30 16:46:02

by Nicolas Ferre

[permalink] [raw]

Subject: [PATCH] at91_mci: minor cleanup

---

From: Marc Pignat <[email protected]>

MMC_POWER_ON is a noop, no need to set the power pin again.

Signed-off-by: Marc Pignat <[email protected]>
Signed-off-by: Nicolas Ferre <[email protected]>
---
MMC_POWER_OFF/MMC_POWER_UP turn the power OFF/ON, there is nothing to change
when ios->power_mode==MMC_POWER_ON.

Also changed indentation for the switch (CodingStyle), because there is no other
switch statement in this driver.

--- a/drivers/mmc/host/at91_mci.c
+++ b/drivers/mmc/host/at91_mci.c
@@ -658,13 +658,14 @@ static void at91_mci_set_ios(struct mmc_
/* maybe switch power to the card */
if (host->board->vcc_pin) {
switch (ios->power_mode) {
- case MMC_POWER_OFF:
- at91_set_gpio_value(host->board->vcc_pin, 0);
- break;
- case MMC_POWER_UP:
- case MMC_POWER_ON:
- at91_set_gpio_value(host->board->vcc_pin, 1);
- break;
+ case MMC_POWER_OFF:
+ at91_set_gpio_value(host->board->vcc_pin, 0);
+ break;
+ case MMC_POWER_UP:
+ at91_set_gpio_value(host->board->vcc_pin, 1);
+ break;
+ default:
+ break;
}
}
}

2008-02-05 06:52:59

by Pierre Ossman

[permalink] [raw]

Subject: Re: [PATCH] at91_mci: minor cleanup

---

On Wed, 30 Jan 2008 17:45:48 +0100
Nicolas Ferre <[email protected]> wrote:

> From: Marc Pignat <[email protected]>
>
> MMC_POWER_ON is a noop, no need to set the power pin again.
>
> Signed-off-by: Marc Pignat <[email protected]>
> Signed-off-by: Nicolas Ferre <[email protected]>
> ---

Perhaps also a WARN_ON() or something in the default case to catch bad invokations?

Rgds
Pierre

---

Attachments:

signature.asc (197.00 B)