2008-02-08 16:48:41

by Jiri Olsa

Subject: [PATCH] misc: ifdef KMOD, saving some bytes probably

found some code in misc.c that could be ifdef'ed for KMOD

Signed-off-by: Jiri Olsa <[email protected]>
---
drivers/char/misc.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index a39101f..3455b09 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -126,7 +126,8 @@ static int misc_open(struct inode * inode, struct file * file)
break;
}
}
-
+
+#if defined(CONFIG_KMOD)
if (!new_fops) {
mutex_unlock(&misc_mtx);
request_module("char-major-%d-%d", MISC_MAJOR, minor);
@@ -141,6 +142,10 @@ static int misc_open(struct inode * inode, struct file * file)
if (!new_fops)
goto fail;
}
+#else
+ if (!new_fops)
+ goto fail;
+#endif

err = 0;
old_fops = file->f_op;

2008-02-08 17:30:14

by Sam Ravnborg

Subject: Re: [PATCH] misc: ifdef KMOD, saving some bytes probably

On Fri, Feb 08, 2008 at 05:48:14PM +0100, Jiri Olsa wrote:
> found some code in misc.c that could be ifdef'ed for KMOD
>
We need very good arguments in order to introduce
#ifdef/#endif in code.
So this patch needs to come with hard fatcs about .text
savings and where it matters.

Sam