2008-02-21 16:13:20

by David Howells

Subject: [PATCH] MM: Fix macro argument substitution in PageHead() and PageTail()

From: David Howells <[email protected]>

Fix macro argument substitution in PageHead() and PageTail() - 'page' should
have brackets surrounding it (commit 6d7779538f765963ced45a3fa4bed7ba8d2c277d).

Signed-off-by: David Howells <[email protected]>
---

include/linux/page-flags.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index bbad43f..b5b30f1 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -266,7 +266,7 @@ static inline void SetPageUptodate(struct page *page)

#define PG_head_tail_mask ((1L << PG_compound) | (1L << PG_reclaim))

-#define PageTail(page) ((page->flags & PG_head_tail_mask) \
+#define PageTail(page) (((page)->flags & PG_head_tail_mask) \
== PG_head_tail_mask)

static inline void __SetPageTail(struct page *page)
@@ -279,7 +279,7 @@ static inline void __ClearPageTail(struct page *page)
page->flags &= ~PG_head_tail_mask;
}

-#define PageHead(page) ((page->flags & PG_head_tail_mask) \
+#define PageHead(page) (((page)->flags & PG_head_tail_mask) \
== (1L << PG_compound))
#define __SetPageHead(page) __SetPageCompound(page)
#define __ClearPageHead(page) __ClearPageCompound(page)

2008-02-27 23:13:50

by Christoph Lameter

Subject: Re: [PATCH] MM: Fix macro argument substitution in PageHead() and PageTail()

On Thu, 21 Feb 2008, David Howells wrote:

> Fix macro argument substitution in PageHead() and PageTail() - 'page' should
> have brackets surrounding it (commit 6d7779538f765963ced45a3fa4bed7ba8d2c277d).

Acked-by: Christoph Lameter <[email protected]>