2008-06-07 01:28:55

by Chris Wright

[permalink] [raw]
Subject: [patch 31/50] Revert "PCI: remove default PCI expansion ROM memory allocation"

-stable review patch. If anyone has any objections, please let us know.
---------------------

From: Linus Torvalds <[email protected]>

upstream commit: 8d539108560ec121d59eee05160236488266221c

This reverts commit 9f8daccaa05c14e5643bdd4faf5aed9cc8e6f11e, which was
reported to break X startup (xf86-video-ati-6.8.0). See

http://bugs.freedesktop.org/show_bug.cgi?id=15523

for details.

Reported-by: Laurence Withers <[email protected]>
Cc: Gary Hade <[email protected]>
Cc: Greg KH <[email protected]>
Cc: Jan Beulich <[email protected]>
Cc: "Jun'ichi Nomura" <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
[[email protected]: backport, remove first hunk to make port easier]
[[email protected]: add back first hunk]
Signed-off-by: Chris Wright <[email protected]>
---
arch/x86/pci/common.c | 17 -----------------
1 file changed, 17 deletions(-)

--- a/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -130,19 +130,6 @@ static void __devinit pcibios_fixup_ghos
}
}

-static void __devinit pcibios_fixup_device_resources(struct pci_dev *dev)
-{
- struct resource *rom_r = &dev->resource[PCI_ROM_RESOURCE];
-
- if (rom_r->parent)
- return;
- if (rom_r->start)
- /* we deal with BIOS assigned ROM later */
- return;
- if (!(pci_probe & PCI_ASSIGN_ROMS))
- rom_r->start = rom_r->end = rom_r->flags = 0;
-}
-
/*
* Called after each bus is probed, but before its children
* are examined.
@@ -150,12 +137,8 @@ static void __devinit pcibios_fixup_devi

void __devinit pcibios_fixup_bus(struct pci_bus *b)
{
- struct pci_dev *dev;
-
pcibios_fixup_ghosts(b);
pci_read_bridge_bases(b);
- list_for_each_entry(dev, &b->devices, bus_list)
- pcibios_fixup_device_resources(dev);
}

/*

--