2008-12-17 16:44:35

by Geert Uytterhoeven

Subject: [PATCH/RFC 1/8] crypto: testmgr - Correct comment about deflate parameters

From: Geert Uytterhoeven <[email protected]>

The comment for the deflate test vectors says the winbits parameter is 11,
while the deflate module actually uses -11 (a negative window bits parameter
enables the raw deflate format instead of the zlib format).
Correct this, to avoid confusion about the format used.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
crypto/testmgr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/crypto/testmgr.h
+++ b/crypto/testmgr.h
@@ -8349,7 +8349,7 @@ struct comp_testvec {

/*
* Deflate test vectors (null-terminated strings).
- * Params: winbits=11, Z_DEFAULT_COMPRESSION, MAX_MEM_LEVEL.
+ * Params: winbits=-11, Z_DEFAULT_COMPRESSION, MAX_MEM_LEVEL.
*/
#define DEFLATE_COMP_TEST_VECTORS 2
#define DEFLATE_DECOMP_TEST_VECTORS 2

--
With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: [email protected]
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010

2008-12-18 06:18:19

by Herbert Xu

Subject: Re: [PATCH/RFC 1/8] crypto: testmgr - Correct comment about deflate parameters

On Wed, Dec 17, 2008 at 05:36:36PM +0100, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <[email protected]>
>
> The comment for the deflate test vectors says the winbits parameter is 11,
> while the deflate module actually uses -11 (a negative window bits parameter
> enables the raw deflate format instead of the zlib format).
> Correct this, to avoid confusion about the format used.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Patch applied. Thanks.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt