2009-01-10 00:26:21

by Pallipadi, Venkatesh

[permalink] [raw]
Subject: [patch 0/6] PAT fixes/cleanup following the pfnmap changes

Individual patch header has descriptions.

--


2009-01-10 13:03:17

by Kevin Winchester

[permalink] [raw]
Subject: Re: [patch 0/6] PAT fixes/cleanup following the pfnmap changes

[email protected] wrote:
> Individual patch header has descriptions.
>

$ git am Patches
Applying: x86 PAT: change track_pfn_vma_new to take pgprot_t pointer param
error: patch failed: mm/memory.c:1604
error: mm/memory.c: patch does not apply
Patch failed at 0001.
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".


These do not apply for me to latest Linus git, which is the tree where I experienced the problem. Is there some way to fuzz them to get them to apply?

--
Kevin Winchester

2009-01-11 02:05:30

by Ingo Molnar

[permalink] [raw]
Subject: Re: [patch 0/6] PAT fixes/cleanup following the pfnmap changes


* Kevin Winchester <[email protected]> wrote:

> [email protected] wrote:
> > Individual patch header has descriptions.
> >
>
> $ git am Patches
> Applying: x86 PAT: change track_pfn_vma_new to take pgprot_t pointer param
> error: patch failed: mm/memory.c:1604
> error: mm/memory.c: patch does not apply
> Patch failed at 0001.
> When you have resolved this problem run "git am --resolved".
> If you would prefer to skip this patch, instead run "git am --skip".
> To restore the original branch and stop patching run "git am --abort".
>
> These do not apply for me to latest Linus git, which is the tree where I
> experienced the problem. Is there some way to fuzz them to get them to
> apply?

Could you check tip/master:

http://people.redhat.com/mingo/tip.git/README

do you still get the messages? [ Btw., did you also experience any 3D
performance problems that are solved via Venki's fixes in tip/master? ]

Ingo

2009-01-11 17:00:26

by Kevin Winchester

[permalink] [raw]
Subject: Re: [patch 0/6] PAT fixes/cleanup following the pfnmap changes

Ingo Molnar wrote:
> * Kevin Winchester <[email protected]> wrote:
>
>> [email protected] wrote:
>>> Individual patch header has descriptions.
>>>
>> $ git am Patches
>> Applying: x86 PAT: change track_pfn_vma_new to take pgprot_t pointer param
>> error: patch failed: mm/memory.c:1604
>> error: mm/memory.c: patch does not apply
>> Patch failed at 0001.
>> When you have resolved this problem run "git am --resolved".
>> If you would prefer to skip this patch, instead run "git am --skip".
>> To restore the original branch and stop patching run "git am --abort".
>>
>> These do not apply for me to latest Linus git, which is the tree where I
>> experienced the problem. Is there some way to fuzz them to get them to
>> apply?
>
> Could you check tip/master:
>
> http://people.redhat.com/mingo/tip.git/README
>
> do you still get the messages? [ Btw., did you also experience any 3D
> performance problems that are solved via Venki's fixes in tip/master? ]
>

I just checked tip/master, and I do still get the messages:

[ 66.895807] X:5022 map pfn expected mapping type write-back for d0000000-d0101000, got write-combining
[ 66.895873] X:5022 freeing invalid memtype d0000000-d0101000

As for 3D performance issues, glxgears without any other applications running gives:

457 frames in 5.0 seconds = 91.312 FPS
475 frames in 5.0 seconds = 94.887 FPS
478 frames in 5.0 seconds = 95.411 FPS

I can't say for sure, but I expect those numbers should be much higher for a 3D accelerated radeon card (even if it is a little old):

01:00.0 VGA compatible controller: ATI Technologies Inc M9+ 5C61 [Radeon Mobility 9200 (AGP)] (rev 01)

glxinfo gives:

direct rendering: Yes


Anything else I can try?

--
Kevin Winchester

2009-01-15 00:03:27

by Kevin Winchester

[permalink] [raw]
Subject: Re: [patch 0/6] PAT fixes/cleanup following the pfnmap changes

Ingo Molnar wrote:
> * Kevin Winchester <[email protected]> wrote:
>
>> [email protected] wrote:
>>> Individual patch header has descriptions.
>>>
>> $ git am Patches
>> Applying: x86 PAT: change track_pfn_vma_new to take pgprot_t pointer param
>> error: patch failed: mm/memory.c:1604
>> error: mm/memory.c: patch does not apply
>> Patch failed at 0001.
>> When you have resolved this problem run "git am --resolved".
>> If you would prefer to skip this patch, instead run "git am --skip".
>> To restore the original branch and stop patching run "git am --abort".
>>
>> These do not apply for me to latest Linus git, which is the tree where I
>> experienced the problem. Is there some way to fuzz them to get them to
>> apply?
>
> Could you check tip/master:
>
> http://people.redhat.com/mingo/tip.git/README
>
> do you still get the messages? [ Btw., did you also experience any 3D
> performance problems that are solved via Venki's fixes in tip/master? ]
>

(I had noted in another email that tip/master still had the problem.)

However, with latest Linus' git tree (2.6.29-rc1-00224-ga652504),
I no longer see the error messages I had noted before. Instead I now see:

[ 475.132031] agpgart-amd64 0000:00:00.0: AGP 3.0 bridge
[ 475.132056] agpgart-amd64 0000:00:00.0: putting AGP V3 device into 8x mode
[ 475.132123] pci 0000:01:00.0: putting AGP V3 device into 8x mode
[ 475.502856] [drm:radeon_do_init_cp] *ERROR* could not find ioremap agp regions!

Is this related? I added Dave Airlie to the CC since perhaps he would be the one
to ask about it?

Thanks,

--
Kevin Winchester