On Thu, Feb 12, 2009 at 5:12 PM, Dan Williams <[email protected]> wrote:
> On Thu, Feb 12, 2009 at 5:30 AM, Thierry Reding
> <[email protected]> wrote:
>> This patch fixes an oops that happens when the dmatest module is unloaded. The
>> dma_release_channel() function is called on channels that have already been
>> cleaned up (and therefore freed) with dmatest_cleanup_channel().
>>
>> Signed-off-by: Thierry Reding <[email protected]>
>
> Thanks, applied with Atsushi's ack.
>
...and now it is unapplied :-). The problem with this patch is that
it releases the channel before dmatest is done with it. 'Cleanup'
followed by 'release' is the right order, just need to save ->chan
before it gets freed.
--
Dan
On Wed, 4 Mar 2009 16:03:47 -0700, Dan Williams <[email protected]> wrote:
> ...and now it is unapplied :-). The problem with this patch is that
> it releases the channel before dmatest is done with it. 'Cleanup'
> followed by 'release' is the right order, just need to save ->chan
> before it gets freed.
Oh that's right. I tested your fix in async_tx tree and it works
fine. Thanks!
---
Atsushi Nemoto