2009-03-11 14:55:50

by David Newall

[permalink] [raw]
Subject: [PATCH] make dequeue_task less confusing

The dequeue_patch function in kernel/sched.c is complicated by including
a sleep parameter. This parameter is always zero except in one
instance. This patch clarifies the task of dequeue_patch by removing
the sleep parameter and moving the code that handles non-zero sleep to
that one place where it is needed.


Attachments:
sched.patch (1.58 kB)

2009-03-11 16:50:44

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] make dequeue_task less confusing


* David Newall <[email protected]> wrote:

> The dequeue_patch function in kernel/sched.c is complicated by
> including a sleep parameter. This parameter is always zero
> except in one instance. This patch clarifies the task of
> dequeue_patch by removing the sleep parameter and moving the
> code that handles non-zero sleep to that one place where it is
> needed.

> --- linux-2.6.27.19/kernel/sched.c 2009-02-21 09:09:34.000000000 +1030
> +++ linux-2.6.27.19/kernel/sched.c.dn 2009-03-12 01:01:48.000000000 +1030

The patch does not apply cleanly to the latest scheduler tree:

1 out of 5 hunks FAILED -- rejects in file kernel/sched.c

You can find it at:

http://people.redhat.com/mingo/tip.git/README

Thanks,

Ingo