2009-03-08 21:03:52

by Pavel Machek

Subject: hp_accel: add two more axis information

Add two more laptops to whitelist.

Signed-off-by: Michal Marek <[email protected]>
Signed-off-by: Pavel Machek <[email protected]>


diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
index 29c83b5..448a462 100644
--- a/drivers/hwmon/hp_accel.c
+++ b/drivers/hwmon/hp_accel.c
@@ -187,6 +187,7 @@ static struct dmi_system_id lis3lv02d_dmi_ids[] = {
AXIS_DMI_MATCH("NC2510", "HP Compaq 2510", y_inverted),
AXIS_DMI_MATCH("NC8510", "HP Compaq 8510", xy_swap_inverted),
AXIS_DMI_MATCH("HP2133", "HP 2133", xy_rotated_left),
+ AXIS_DMI_MATCH("HP2140", "HP 2140", xy_swap_inverted),
AXIS_DMI_MATCH("NC653x", "HP Compaq 653", xy_rotated_left_usd),
AXIS_DMI_MATCH("NC673x", "HP Compaq 673", xy_rotated_left_usd),
AXIS_DMI_MATCH("NC651xx", "HP Compaq 651", xy_rotated_right),
@@ -201,6 +202,7 @@ static struct dmi_system_id lis3lv02d_dmi_ids[] = {
PRODUCT_NAME, "HP Pavilion dv5",
BOARD_NAME, "3600",
y_inverted),
+ AXIS_DMI_MATCH("DV7", "HP Pavilion dv7", x_inverted),
{ NULL, }
/* Laptop models without axis info (yet):
* "NC6910" "HP Compaq 6910"

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2009-03-08 21:06:44

by Daniel Mack

Subject: Re: hp_accel: add two more axis information

On Sun, Mar 08, 2009 at 10:03:30PM +0100, Pavel Machek wrote:
> Add two more laptops to whitelist.
>
> Signed-off-by: Michal Marek <[email protected]>
> Signed-off-by: Pavel Machek <[email protected]>
>
>
> diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
> index 29c83b5..448a462 100644
> --- a/drivers/hwmon/hp_accel.c
> +++ b/drivers/hwmon/hp_accel.c
> @@ -187,6 +187,7 @@ static struct dmi_system_id lis3lv02d_dmi_ids[] = {
> AXIS_DMI_MATCH("NC2510", "HP Compaq 2510", y_inverted),
> AXIS_DMI_MATCH("NC8510", "HP Compaq 8510", xy_swap_inverted),
> AXIS_DMI_MATCH("HP2133", "HP 2133", xy_rotated_left),
> + AXIS_DMI_MATCH("HP2140", "HP 2140", xy_swap_inverted),
> AXIS_DMI_MATCH("NC653x", "HP Compaq 653", xy_rotated_left_usd),
> AXIS_DMI_MATCH("NC673x", "HP Compaq 673", xy_rotated_left_usd),
> AXIS_DMI_MATCH("NC651xx", "HP Compaq 651", xy_rotated_right),
> @@ -201,6 +202,7 @@ static struct dmi_system_id lis3lv02d_dmi_ids[] = {
> PRODUCT_NAME, "HP Pavilion dv5",
> BOARD_NAME, "3600",
> y_inverted),
> + AXIS_DMI_MATCH("DV7", "HP Pavilion dv7", x_inverted),
> { NULL, }
> /* Laptop models without axis info (yet):
> * "NC6910" "HP Compaq 6910"

Does this apply on top of my recent ACPI resolve patches? Could you test
the latest versions already?

Daniel

2009-03-08 21:08:21

by Pavel Machek

Subject: Re: hp_accel: add two more axis information

On Sun 2009-03-08 22:06:25, Daniel Mack wrote:
> On Sun, Mar 08, 2009 at 10:03:30PM +0100, Pavel Machek wrote:
> > Add two more laptops to whitelist.
> >
> > Signed-off-by: Michal Marek <[email protected]>
> > Signed-off-by: Pavel Machek <[email protected]>
> >
> >
> > diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
> > index 29c83b5..448a462 100644
> > --- a/drivers/hwmon/hp_accel.c
> > +++ b/drivers/hwmon/hp_accel.c
> > @@ -187,6 +187,7 @@ static struct dmi_system_id lis3lv02d_dmi_ids[] = {
> > AXIS_DMI_MATCH("NC2510", "HP Compaq 2510", y_inverted),
> > AXIS_DMI_MATCH("NC8510", "HP Compaq 8510", xy_swap_inverted),
> > AXIS_DMI_MATCH("HP2133", "HP 2133", xy_rotated_left),
> > + AXIS_DMI_MATCH("HP2140", "HP 2140", xy_swap_inverted),
> > AXIS_DMI_MATCH("NC653x", "HP Compaq 653", xy_rotated_left_usd),
> > AXIS_DMI_MATCH("NC673x", "HP Compaq 673", xy_rotated_left_usd),
> > AXIS_DMI_MATCH("NC651xx", "HP Compaq 651", xy_rotated_right),
> > @@ -201,6 +202,7 @@ static struct dmi_system_id lis3lv02d_dmi_ids[] = {
> > PRODUCT_NAME, "HP Pavilion dv5",
> > BOARD_NAME, "3600",
> > y_inverted),
> > + AXIS_DMI_MATCH("DV7", "HP Pavilion dv7", x_inverted),
> > { NULL, }
> > /* Laptop models without axis info (yet):
> > * "NC6910" "HP Compaq 6910"
>
> Does this apply on top of my recent ACPI resolve patches? Could you test
> the latest versions already?

I guess it should; you did not change anything in the
whitelist. Unfortunately, I no longer have hardware to do testing.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2009-03-23 00:19:49

by Andrew Morton

Subject: Re: hp_accel: add two more axis information

On Sun, 8 Mar 2009 22:07:57 +0100 Pavel Machek <[email protected]> wrote:

> On Sun 2009-03-08 22:06:25, Daniel Mack wrote:
> > On Sun, Mar 08, 2009 at 10:03:30PM +0100, Pavel Machek wrote:
> > > Add two more laptops to whitelist.
> > >
> > > Signed-off-by: Michal Marek <[email protected]>
> > > Signed-off-by: Pavel Machek <[email protected]>
> > >
> > >
> > > diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
> > > index 29c83b5..448a462 100644
> > > --- a/drivers/hwmon/hp_accel.c
> > > +++ b/drivers/hwmon/hp_accel.c
> > > @@ -187,6 +187,7 @@ static struct dmi_system_id lis3lv02d_dmi_ids[] = {
> > > AXIS_DMI_MATCH("NC2510", "HP Compaq 2510", y_inverted),
> > > AXIS_DMI_MATCH("NC8510", "HP Compaq 8510", xy_swap_inverted),
> > > AXIS_DMI_MATCH("HP2133", "HP 2133", xy_rotated_left),
> > > + AXIS_DMI_MATCH("HP2140", "HP 2140", xy_swap_inverted),
> > > AXIS_DMI_MATCH("NC653x", "HP Compaq 653", xy_rotated_left_usd),
> > > AXIS_DMI_MATCH("NC673x", "HP Compaq 673", xy_rotated_left_usd),
> > > AXIS_DMI_MATCH("NC651xx", "HP Compaq 651", xy_rotated_right),
> > > @@ -201,6 +202,7 @@ static struct dmi_system_id lis3lv02d_dmi_ids[] = {
> > > PRODUCT_NAME, "HP Pavilion dv5",
> > > BOARD_NAME, "3600",
> > > y_inverted),
> > > + AXIS_DMI_MATCH("DV7", "HP Pavilion dv7", x_inverted),
> > > { NULL, }
> > > /* Laptop models without axis info (yet):
> > > * "NC6910" "HP Compaq 6910"
> >
> > Does this apply on top of my recent ACPI resolve patches? Could you test
> > the latest versions already?
>
> I guess it should; you did not change anything in the
> whitelist. Unfortunately, I no longer have hardware to do testing.

I'm all confused and don't know what to do with this patch.

I guess I'll just apply it and see if I get shouted at.

2009-03-23 10:04:36

by Pavel Machek

Subject: Re: hp_accel: add two more axis information

On Sun 2009-03-22 17:11:28, Andrew Morton wrote:
> On Sun, 8 Mar 2009 22:07:57 +0100 Pavel Machek <[email protected]> wrote:
>
> > On Sun 2009-03-08 22:06:25, Daniel Mack wrote:
> > > On Sun, Mar 08, 2009 at 10:03:30PM +0100, Pavel Machek wrote:
> > > > Add two more laptops to whitelist.
> > > >
> > > > Signed-off-by: Michal Marek <[email protected]>
> > > > Signed-off-by: Pavel Machek <[email protected]>
> > > >
> > > >
> > > > diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
> > > > index 29c83b5..448a462 100644
> > > > --- a/drivers/hwmon/hp_accel.c
> > > > +++ b/drivers/hwmon/hp_accel.c
> > > > @@ -187,6 +187,7 @@ static struct dmi_system_id lis3lv02d_dmi_ids[] = {
> > > > AXIS_DMI_MATCH("NC2510", "HP Compaq 2510", y_inverted),
> > > > AXIS_DMI_MATCH("NC8510", "HP Compaq 8510", xy_swap_inverted),
> > > > AXIS_DMI_MATCH("HP2133", "HP 2133", xy_rotated_left),
> > > > + AXIS_DMI_MATCH("HP2140", "HP 2140", xy_swap_inverted),
> > > > AXIS_DMI_MATCH("NC653x", "HP Compaq 653", xy_rotated_left_usd),
> > > > AXIS_DMI_MATCH("NC673x", "HP Compaq 673", xy_rotated_left_usd),
> > > > AXIS_DMI_MATCH("NC651xx", "HP Compaq 651", xy_rotated_right),
> > > > @@ -201,6 +202,7 @@ static struct dmi_system_id lis3lv02d_dmi_ids[] = {
> > > > PRODUCT_NAME, "HP Pavilion dv5",
> > > > BOARD_NAME, "3600",
> > > > y_inverted),
> > > > + AXIS_DMI_MATCH("DV7", "HP Pavilion dv7", x_inverted),
> > > > { NULL, }
> > > > /* Laptop models without axis info (yet):
> > > > * "NC6910" "HP Compaq 6910"
> > >
> > > Does this apply on top of my recent ACPI resolve patches? Could you test
> > > the latest versions already?
> >
> > I guess it should; you did not change anything in the
> > whitelist. Unfortunately, I no longer have hardware to do testing.
>
> I'm all confused and don't know what to do with this patch.
>
> I guess I'll just apply it and see if I get shouted at.

That sounds like a plan :-). And I don't think you'll get shouted at,
the patch should be very safe.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html