2009-03-31 23:34:42

by Chris Wright

[permalink] [raw]
Subject: [patch 38/45] x86: fix 64k corruption-check

-stable review patch. If anyone has any objections, please let us know.
---------------------

From: Yinghai Lu <[email protected]>

upstream commit: 6d7942dc2a70a7e74c352107b150265602671588

Impact: fix boot crash

Need to exit early if the addr is far above 64k.

The crash got exposed by:

78a8b35: x86: make e820_update_range() handle small range update

Signed-off-by: Yinghai Lu <[email protected]>
Cc: <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
---
arch/x86/kernel/check.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--- a/arch/x86/kernel/check.c
+++ b/arch/x86/kernel/check.c
@@ -86,12 +86,12 @@ void __init setup_bios_corruption_check(
if (addr == 0)
break;

+ if (addr >= corruption_check_size)
+ break;
+
if ((addr + size) > corruption_check_size)
size = corruption_check_size - addr;

- if (size == 0)
- break;
-
e820_update_range(addr, size, E820_RAM, E820_RESERVED);
scan_areas[num_scan_areas].addr = addr;
scan_areas[num_scan_areas].size = size;