2009-04-27 09:32:44

by Adrian Bunk

Subject: [2.6 patch] usb/storage/usual-tables.c: add MODULE_LICENSE

This patch adds the missing MODULE_LICENSE("GPL").

Signed-off-by: Adrian Bunk <[email protected]>

---

diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
index 468bde7..d62ea8f 100644
--- a/drivers/usb/storage/usual-tables.c
+++ b/drivers/usb/storage/usual-tables.c
@@ -114,3 +114,5 @@ int usb_usual_ignore_device(struct usb_interface *intf)
return 0;
}
EXPORT_SYMBOL_GPL(usb_usual_ignore_device);
+
+MODULE_LICENSE("GPL");

2009-04-27 15:32:07

by Greg KH

Subject: Re: [2.6 patch] usb/storage/usual-tables.c: add MODULE_LICENSE

On Mon, Apr 27, 2009 at 12:33:01PM +0300, Adrian Bunk wrote:
> This patch adds the missing MODULE_LICENSE("GPL").
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
>
> diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
> index 468bde7..d62ea8f 100644
> --- a/drivers/usb/storage/usual-tables.c
> +++ b/drivers/usb/storage/usual-tables.c
> @@ -114,3 +114,5 @@ int usb_usual_ignore_device(struct usb_interface *intf)
> return 0;
> }
> EXPORT_SYMBOL_GPL(usb_usual_ignore_device);
> +
> +MODULE_LICENSE("GPL");

Why is this needed? This .c file gets built into either the libusual
module, or the usb-storage module, both of which have module licenses,
right?

confused,

greg k-h

2009-04-27 16:37:35

by Adrian Bunk

Subject: Re: [2.6 patch] usb/storage/usual-tables.c: add MODULE_LICENSE

On Mon, Apr 27, 2009 at 08:28:19AM -0700, Greg KH wrote:
> On Mon, Apr 27, 2009 at 12:33:01PM +0300, Adrian Bunk wrote:
> > This patch adds the missing MODULE_LICENSE("GPL").
> >
> > Signed-off-by: Adrian Bunk <[email protected]>
> >
> > ---
> >
> > diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
> > index 468bde7..d62ea8f 100644
> > --- a/drivers/usb/storage/usual-tables.c
> > +++ b/drivers/usb/storage/usual-tables.c
> > @@ -114,3 +114,5 @@ int usb_usual_ignore_device(struct usb_interface *intf)
> > return 0;
> > }
> > EXPORT_SYMBOL_GPL(usb_usual_ignore_device);
> > +
> > +MODULE_LICENSE("GPL");
>
> Why is this needed? This .c file gets built into either the libusual
> module, or the usb-storage module, both of which have module licenses,
> right?

My fault, I ran into it some time ago, and missed that the actual
problem was fixed by commit dfc15e8955338fedf5c5d15622c4042c1e4ee332

> confused,
>
> greg k-h

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed