2009-09-04 10:50:07

by Andrea Righi

Subject: Re: [RFC v1 PATCH 3/7] sched: Bandwidth initialization for fair task groups

On Tue, Aug 25, 2009 at 03:19:50PM +0530, Bharata B Rao wrote:
> +config CFS_HARD_LIMITS
> + bool "Hard Limits for CFS Group Scheduler"
> + depends on EXPERIMENTAL
> + depends on FAIR_GROUP_SCHED

Shouldn't depend also on CGROUPS and CGROUP_SCHED? without them hard
limits can't be defined, right?

Signed-off-by: Andrea Righi <[email protected]>
---
init/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index 71868a0..19c0290 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -459,7 +459,7 @@ config FAIR_GROUP_SCHED
config CFS_HARD_LIMITS
bool "Hard Limits for CFS Group Scheduler"
depends on EXPERIMENTAL
- depends on FAIR_GROUP_SCHED
+ depends on FAIR_GROUP_SCHED && CGROUPS && CGROUP_SCHED
default n
help
This option enables hard limiting of CPU time obtained by

2009-09-04 12:32:33

by Bharata B Rao

Subject: Re: [RFC v1 PATCH 3/7] sched: Bandwidth initialization for fair task groups

On Fri, Sep 04, 2009 at 12:43:25PM +0200, Andrea Righi wrote:
> On Tue, Aug 25, 2009 at 03:19:50PM +0530, Bharata B Rao wrote:
> > +config CFS_HARD_LIMITS
> > + bool "Hard Limits for CFS Group Scheduler"
> > + depends on EXPERIMENTAL
> > + depends on FAIR_GROUP_SCHED
>
> Shouldn't depend also on CGROUPS and CGROUP_SCHED? without them hard
> limits can't be defined, right?

Right, but do we need to explicitly mention CGROUPS as dependency since
CGROUP_SCHED is already dependent on it ?

>
> Signed-off-by: Andrea Righi <[email protected]>
> ---
> init/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index 71868a0..19c0290 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -459,7 +459,7 @@ config FAIR_GROUP_SCHED
> config CFS_HARD_LIMITS
> bool "Hard Limits for CFS Group Scheduler"
> depends on EXPERIMENTAL
> - depends on FAIR_GROUP_SCHED
> + depends on FAIR_GROUP_SCHED && CGROUPS && CGROUP_SCHED
> default n
> help
> This option enables hard limiting of CPU time obtained by

Thanks for looking at the patches.

Regards,
Bharata.

2009-09-04 12:36:33

by Andrea Righi

Subject: Re: [RFC v1 PATCH 3/7] sched: Bandwidth initialization for fair task groups

On Fri, Sep 04, 2009 at 06:02:15PM +0530, Bharata B Rao wrote:
> On Fri, Sep 04, 2009 at 12:43:25PM +0200, Andrea Righi wrote:
> > On Tue, Aug 25, 2009 at 03:19:50PM +0530, Bharata B Rao wrote:
> > > +config CFS_HARD_LIMITS
> > > + bool "Hard Limits for CFS Group Scheduler"
> > > + depends on EXPERIMENTAL
> > > + depends on FAIR_GROUP_SCHED
> >
> > Shouldn't depend also on CGROUPS and CGROUP_SCHED? without them hard
> > limits can't be defined, right?
>
> Right, but do we need to explicitly mention CGROUPS as dependency since
> CGROUP_SCHED is already dependent on it ?

Correct, CGROUP_SCHED is enough.

Thanks,
-Andrea

--
Andrea Righi - Develer s.r.l
http://www.develer.com