2009-09-27 18:29:22

by John David Anglin

[permalink] [raw]
Subject: Re: [PATCH] arch/parisc: correct use of SHF_ALLOC

Hi Kyle,

I noticed today that this change is not in 2.6.31.1.

Dave

On Tue, 04 Aug 2009, Julia Lawall wrote:

> From: Julia Lawall <[email protected]>
>
> SHF_ALLOC is suitable for testing against the sh_flags field, not the
> sh_type field.
>
> Signed-off-by: Julia Lawall <[email protected]>
>
> ---
> arch/parisc/kernel/module.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/parisc/kernel/module.c b/arch/parisc/kernel/module.c
> index ef5caf2..c904817 100644
> --- a/arch/parisc/kernel/module.c
> +++ b/arch/parisc/kernel/module.c
> @@ -853,7 +853,7 @@ int module_finalize(const Elf_Ehdr *hdr,
> * ourselves */
> for (i = 1; i < hdr->e_shnum; i++) {
> if(sechdrs[i].sh_type == SHT_SYMTAB
> - && (sechdrs[i].sh_type & SHF_ALLOC)) {
> + && (sechdrs[i].sh_flags & SHF_ALLOC)) {
> int strindex = sechdrs[i].sh_link;
> /* FIXME: AWFUL HACK
> * The cast is to drop the const from
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
J. David Anglin [email protected]
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)


2009-09-28 03:29:58

by Kyle McMartin

[permalink] [raw]
Subject: Re: [PATCH] arch/parisc: correct use of SHF_ALLOC

On Sun, Sep 27, 2009 at 02:21:50PM -0400, John David Anglin wrote:
> Hi Kyle,
>
> I noticed today that this change is not in 2.6.31.1.
>

Dunno what happened... I must have updated patchwork and missed it in a
rebase locally.